From 7d09db22b4ce2bcd63633cc8f94aef3186a460f9 Mon Sep 17 00:00:00 2001 From: alanb Date: Mon, 1 Oct 2012 15:36:57 +0100 Subject: [PATCH] 8000269: Cleanup javadoc warnings Reviewed-by: lancea, darcy, ulfzibis, iris, naoto, dholmes --- src/share/classes/java/io/FilePermission.java | 53 ++++++------------- src/share/classes/java/io/PrintWriter.java | 8 +-- src/share/classes/java/io/Reader.java | 2 +- src/share/classes/java/lang/Class.java | 2 +- .../java/lang/InheritableThreadLocal.java | 1 - src/share/classes/java/lang/Integer.java | 2 +- src/share/classes/java/lang/Package.java | 5 +- src/share/classes/java/lang/StrictMath.java | 4 +- src/share/classes/java/lang/String.java | 4 +- src/share/classes/java/lang/System.java | 2 +- src/share/classes/java/lang/ThreadGroup.java | 3 -- src/share/classes/java/lang/ThreadLocal.java | 5 +- .../java/lang/management/ThreadInfo.java | 5 +- .../net/AbstractPlainDatagramSocketImpl.java | 18 +++---- .../java/net/AbstractPlainSocketImpl.java | 2 +- .../classes/java/net/DatagramSocket.java | 2 +- src/share/classes/java/net/Inet4Address.java | 1 - .../classes/java/net/SocketInputStream.java | 4 +- .../classes/java/net/SocketPermission.java | 33 +++++------- .../classes/java/net/SocksSocketImpl.java | 2 +- src/share/classes/java/net/URLConnection.java | 3 +- .../classes/java/nio/channels/Channels.java | 2 +- .../classes/java/nio/file/FileSystem.java | 2 +- src/share/classes/java/nio/file/Files.java | 4 +- src/share/classes/java/nio/file/Path.java | 2 +- .../file/attribute/AclFileAttributeView.java | 2 +- .../java/nio/file/attribute/FileTime.java | 2 +- .../classes/java/security/AllPermission.java | 26 ++++----- .../java/security/BasicPermission.java | 34 ++++-------- .../classes/java/security/CodeSource.java | 2 +- src/share/classes/java/security/KeyStore.java | 4 +- .../security/cert/PKIXRevocationChecker.java | 2 +- .../classes/java/sql/CallableStatement.java | 2 +- .../java/text/CollationElementIterator.java | 4 +- src/share/classes/java/text/DigitList.java | 2 +- src/share/classes/java/text/Format.java | 2 +- .../classes/java/text/RBCollationTables.java | 22 ++++---- .../classes/java/text/RBTableBuilder.java | 2 +- .../classes/java/text/SimpleDateFormat.java | 2 +- src/share/classes/java/util/Calendar.java | 1 - src/share/classes/java/util/Currency.java | 2 +- src/share/classes/java/util/Formatter.java | 2 +- .../java/util/JapaneseImperialCalendar.java | 6 +-- src/share/classes/java/util/JumboEnumSet.java | 2 +- src/share/classes/java/util/Locale.java | 4 +- .../classes/java/util/PropertyPermission.java | 49 ++++++----------- .../classes/java/util/RegularEnumSet.java | 2 +- src/share/classes/java/util/Scanner.java | 3 +- src/share/classes/java/util/TimeZone.java | 2 +- .../classes/java/util/logging/Logging.java | 4 +- .../classes/java/util/prefs/XmlSupport.java | 2 +- .../javax/crypto/CryptoAllPermission.java | 8 ++- .../javax/crypto/CryptoPermission.java | 16 +++--- .../javax/crypto/CryptoPolicyParser.java | 2 +- .../classes/javax/crypto/NullCipherSpi.java | 2 +- .../javax/management/loading/MLet.java | 2 +- .../modelmbean/ModelMBeanAttributeInfo.java | 4 +- .../CompositeDataInvocationHandler.java | 5 -- .../javax/naming/spi/NamingManager.java | 2 +- .../auth/kerberos/DelegationPermission.java | 11 ++-- .../auth/kerberos/ServicePermission.java | 13 ++--- .../javax/sql/ConnectionPoolDataSource.java | 4 +- .../classes/javax/sql/PooledConnection.java | 4 +- .../javax/sql/rowset/spi/SyncProvider.java | 2 +- 64 files changed, 172 insertions(+), 261 deletions(-) diff --git a/src/share/classes/java/io/FilePermission.java b/src/share/classes/java/io/FilePermission.java index b2ba8bdf7..97ca19597 100644 --- a/src/share/classes/java/io/FilePermission.java +++ b/src/share/classes/java/io/FilePermission.java @@ -76,7 +76,7 @@ import sun.security.util.SecurityConstants; *

* Be careful when granting FilePermissions. Think about the implications * of granting read and especially write access to various files and - * directories. The "<<ALL FILES>>" permission with write action is + * directories. The "<<ALL FILES>>" permission with write action is * especially dangerous. This grants permission to write to the entire * file system. One thing this effectively allows is replacement of the * system binary, including the JVM runtime environment. @@ -180,9 +180,7 @@ public final class FilePermission extends Permission implements Serializable { * @param mask the actions mask to use. * */ - private void init(int mask) - { - + private void init(int mask) { if ((mask & ALL) != mask) throw new IllegalArgumentException("invalid actions mask"); @@ -274,9 +272,7 @@ public final class FilePermission extends Permission implements Serializable { * If actions is null, empty or contains an action * other than the specified possible actions. */ - - public FilePermission(String path, String actions) - { + public FilePermission(String path, String actions) { super(path); init(getMask(actions)); } @@ -293,8 +289,7 @@ public final class FilePermission extends Permission implements Serializable { */ // package private for use by the FilePermissionCollection add method - FilePermission(String path, int mask) - { + FilePermission(String path, int mask) { super(path); init(mask); } @@ -337,7 +332,6 @@ public final class FilePermission extends Permission implements Serializable { * this FilePermission's path also implies that FilePermission's path. * * @param that the FilePermission to check against. - * @param exact return immediately if the masks are not equal * @return the effective mask */ boolean impliesIgnoreMask(FilePermission that) { @@ -412,7 +406,6 @@ public final class FilePermission extends Permission implements Serializable { * * @return a hash code value for this object. */ - public int hashCode() { return this.cpath.hashCode(); } @@ -424,7 +417,6 @@ public final class FilePermission extends Permission implements Serializable { * @return the actions mask. */ private static int getMask(String actions) { - int mask = NONE; // Null action valid? @@ -552,7 +544,6 @@ public final class FilePermission extends Permission implements Serializable { * * @return the actions mask. */ - int getMask() { return mask; } @@ -564,8 +555,7 @@ public final class FilePermission extends Permission implements Serializable { * * @return the canonical string representation of the actions. */ - private static String getActions(int mask) - { + private static String getActions(int mask) { StringBuilder sb = new StringBuilder(); boolean comma = false; @@ -610,15 +600,13 @@ public final class FilePermission extends Permission implements Serializable { * * @return the canonical string representation of the actions. */ - public String getActions() - { + public String getActions() { if (actions == null) actions = getActions(this.mask); return actions; } - /** * Returns a new PermissionCollection object for storing FilePermission * objects. @@ -650,7 +638,6 @@ public final class FilePermission extends Permission implements Serializable { * @return a new PermissionCollection object suitable for storing * FilePermissions. */ - public PermissionCollection newPermissionCollection() { return new FilePermissionCollection(); } @@ -712,22 +699,20 @@ public final class FilePermission extends Permission implements Serializable { */ final class FilePermissionCollection extends PermissionCollection -implements Serializable { - + implements Serializable +{ // Not serialized; see serialization section at end of class private transient List perms; /** - * Create an empty FilePermissions object. - * + * Create an empty FilePermissionCollection object. */ - public FilePermissionCollection() { perms = new ArrayList<>(); } /** - * Adds a permission to the FilePermissions. The key for the hash is + * Adds a permission to the FilePermissionCollection. The key for the hash is * permission.path. * * @param permission the Permission object to add. @@ -738,9 +723,7 @@ implements Serializable { * @exception SecurityException - if this FilePermissionCollection object * has been marked readonly */ - - public void add(Permission permission) - { + public void add(Permission permission) { if (! (permission instanceof FilePermission)) throw new IllegalArgumentException("invalid permission: "+ permission); @@ -757,16 +740,14 @@ implements Serializable { * Check and see if this set of permissions implies the permissions * expressed in "permission". * - * @param p the Permission object to compare + * @param permission the Permission object to compare * * @return true if "permission" is a proper subset of a permission in * the set, false if not. */ - - public boolean implies(Permission permission) - { + public boolean implies(Permission permission) { if (! (permission instanceof FilePermission)) - return false; + return false; FilePermission fp = (FilePermission) permission; @@ -795,7 +776,6 @@ implements Serializable { * * @return an enumeration of all the FilePermission objects. */ - public Enumeration elements() { // Convert Iterator into Enumeration synchronized (this) { @@ -841,8 +821,9 @@ implements Serializable { /* * Reads in a Vector of FilePermissions and saves them in the perms field. */ - private void readObject(ObjectInputStream in) throws IOException, - ClassNotFoundException { + private void readObject(ObjectInputStream in) + throws IOException, ClassNotFoundException + { // Don't call defaultReadObject() // Read in serialized fields diff --git a/src/share/classes/java/io/PrintWriter.java b/src/share/classes/java/io/PrintWriter.java index 102c3a29a..2db17d0e7 100644 --- a/src/share/classes/java/io/PrintWriter.java +++ b/src/share/classes/java/io/PrintWriter.java @@ -784,7 +784,7 @@ public class PrintWriter extends Writer { * null argument depends on the conversion. * - * @throws IllegalFormatException + * @throws java.util.IllegalFormatException * If a format string contains an illegal syntax, a format * specifier that is incompatible with the given arguments, * insufficient arguments given the format string, or other @@ -835,7 +835,7 @@ public class PrintWriter extends Writer { * null argument depends on the conversion. * - * @throws IllegalFormatException + * @throws java.util.IllegalFormatException * If a format string contains an illegal syntax, a format * specifier that is incompatible with the given arguments, * insufficient arguments given the format string, or other @@ -879,7 +879,7 @@ public class PrintWriter extends Writer { * null argument depends on the conversion. * - * @throws IllegalFormatException + * @throws java.util.IllegalFormatException * If a format string contains an illegal syntax, a format * specifier that is incompatible with the given arguments, * insufficient arguments given the format string, or other @@ -939,7 +939,7 @@ public class PrintWriter extends Writer { * null argument depends on the conversion. * - * @throws IllegalFormatException + * @throws java.util.IllegalFormatException * If a format string contains an illegal syntax, a format * specifier that is incompatible with the given arguments, * insufficient arguments given the format string, or other diff --git a/src/share/classes/java/io/Reader.java b/src/share/classes/java/io/Reader.java index e2248c412..076055c73 100644 --- a/src/share/classes/java/io/Reader.java +++ b/src/share/classes/java/io/Reader.java @@ -91,7 +91,7 @@ public abstract class Reader implements Readable, Closeable { * -1 if this source of characters is at its end * @throws IOException if an I/O error occurs * @throws NullPointerException if target is null - * @throws ReadOnlyBufferException if target is a read only buffer + * @throws java.nio.ReadOnlyBufferException if target is a read only buffer * @since 1.5 */ public int read(java.nio.CharBuffer target) throws IOException { diff --git a/src/share/classes/java/lang/Class.java b/src/share/classes/java/lang/Class.java index 267d7d457..ec9d97256 100644 --- a/src/share/classes/java/lang/Class.java +++ b/src/share/classes/java/lang/Class.java @@ -2970,7 +2970,7 @@ public final /** * Returns a map from simple name to enum constant. This package-private * method is used internally by Enum to implement - * public static > T valueOf(Class, String) + * {@code public static > T valueOf(Class, String)} * efficiently. Note that the map is returned by this method is * created lazily on first use. Typically it won't ever get created. */ diff --git a/src/share/classes/java/lang/InheritableThreadLocal.java b/src/share/classes/java/lang/InheritableThreadLocal.java index 859e651dd..ea287b749 100644 --- a/src/share/classes/java/lang/InheritableThreadLocal.java +++ b/src/share/classes/java/lang/InheritableThreadLocal.java @@ -76,7 +76,6 @@ public class InheritableThreadLocal extends ThreadLocal { * * @param t the current thread * @param firstValue value for the initial entry of the table. - * @param map the map to store. */ void createMap(Thread t, T firstValue) { t.inheritableThreadLocals = new ThreadLocalMap(this, firstValue); diff --git a/src/share/classes/java/lang/Integer.java b/src/share/classes/java/lang/Integer.java index 48ef1bbbb..0943a3473 100644 --- a/src/share/classes/java/lang/Integer.java +++ b/src/share/classes/java/lang/Integer.java @@ -752,7 +752,7 @@ public final class Integer extends Number implements Comparable { * -128 and 127 (inclusive) as required by JLS. * * The cache is initialized on first usage. The size of the cache - * may be controlled by the -XX:AutoBoxCacheMax= option. + * may be controlled by the {@code -XX:AutoBoxCacheMax=} option. * During VM initialization, java.lang.Integer.IntegerCache.high property * may be set and saved in the private system properties in the * sun.misc.VM class. diff --git a/src/share/classes/java/lang/Package.java b/src/share/classes/java/lang/Package.java index f7af97a65..58fd8e20c 100644 --- a/src/share/classes/java/lang/Package.java +++ b/src/share/classes/java/lang/Package.java @@ -316,7 +316,7 @@ public class Package implements java.lang.reflect.AnnotatedElement { * attributes are defined in the manifests that accompany * the classes. * - * @param class the class to get the package of. + * @param c the class to get the package of. * @return the package of the class. It may be null if no package * information is available from the archive or codebase. */ static Package getPackage(Class c) { @@ -411,14 +411,13 @@ public class Package implements java.lang.reflect.AnnotatedElement { /** * Construct a package instance with the specified version * information. - * @param pkgName the name of the package + * @param name the name of the package * @param spectitle the title of the specification * @param specversion the version of the specification * @param specvendor the organization that maintains the specification * @param impltitle the title of the implementation * @param implversion the version of the implementation * @param implvendor the organization that maintains the implementation - * @return a new package for containing the specified information. */ Package(String name, String spectitle, String specversion, String specvendor, diff --git a/src/share/classes/java/lang/StrictMath.java b/src/share/classes/java/lang/StrictMath.java index 1a06f7615..ced79c747 100644 --- a/src/share/classes/java/lang/StrictMath.java +++ b/src/share/classes/java/lang/StrictMath.java @@ -365,7 +365,7 @@ public final class StrictMath { * @param a the value to be floored or ceiled * @param negativeBoundary result for values in (-1, 0) * @param positiveBoundary result for values in (0, 1) - * @param increment value to add when the argument is non-integral + * @param sign the sign of the result */ private static double floorOrCeil(double a, double negativeBoundary, @@ -811,7 +811,7 @@ public final class StrictMath { * @param value the long value * @return the argument as an int * @throws ArithmeticException if the {@code argument} overflows an int - * @see Math#toIntExact(int) + * @see Math#toIntExact(long) * @since 1.8 */ public static int toIntExact(long value) { diff --git a/src/share/classes/java/lang/String.java b/src/share/classes/java/lang/String.java index ea27b357e..f9550874c 100644 --- a/src/share/classes/java/lang/String.java +++ b/src/share/classes/java/lang/String.java @@ -2782,7 +2782,7 @@ public final class String * null argument depends on the conversion. * - * @throws IllegalFormatException + * @throws java.util.IllegalFormatException * If a format string contains an illegal syntax, a format * specifier that is incompatible with the given arguments, * insufficient arguments given the format string, or other @@ -2826,7 +2826,7 @@ public final class String * null argument depends on the conversion. * - * @throws IllegalFormatException + * @throws java.util.IllegalFormatException * If a format string contains an illegal syntax, a format * specifier that is incompatible with the given arguments, * insufficient arguments given the format string, or other diff --git a/src/share/classes/java/lang/System.java b/src/share/classes/java/lang/System.java index 95693767b..2384e01bc 100644 --- a/src/share/classes/java/lang/System.java +++ b/src/share/classes/java/lang/System.java @@ -545,7 +545,7 @@ public final class System { * java.version * Java Runtime Environment version * java.vendor - * Java Runtime Environment vendorJava Runtime Environment vendor * java.vendor.url * Java vendor URL * java.home diff --git a/src/share/classes/java/lang/ThreadGroup.java b/src/share/classes/java/lang/ThreadGroup.java index 8b93210aa..195b1c2fd 100644 --- a/src/share/classes/java/lang/ThreadGroup.java +++ b/src/share/classes/java/lang/ThreadGroup.java @@ -918,9 +918,6 @@ class ThreadGroup implements Thread.UncaughtExceptionHandler { * * @param t * the Thread whose start method was invoked - * - * @param failed - * true if the thread could not be started successfully */ void threadStartFailed(Thread t) { synchronized(this) { diff --git a/src/share/classes/java/lang/ThreadLocal.java b/src/share/classes/java/lang/ThreadLocal.java index e5c6e1f78..20a665787 100644 --- a/src/share/classes/java/lang/ThreadLocal.java +++ b/src/share/classes/java/lang/ThreadLocal.java @@ -47,8 +47,8 @@ import java.util.concurrent.atomic.AtomicInteger; * private static final AtomicInteger nextId = new AtomicInteger(0); * * // Thread local variable containing each thread's ID - * private static final ThreadLocal<Integer> threadId = - * new ThreadLocal<Integer>() { + * private static final ThreadLocal<Integer> threadId = + * new ThreadLocal<Integer>() { * @Override protected Integer initialValue() { * return nextId.getAndIncrement(); * } @@ -222,7 +222,6 @@ public class ThreadLocal { * * @param t the current thread * @param firstValue value for the initial entry of the map - * @param map the map to store. */ void createMap(Thread t, T firstValue) { t.threadLocals = new ThreadLocalMap(this, firstValue); diff --git a/src/share/classes/java/lang/management/ThreadInfo.java b/src/share/classes/java/lang/management/ThreadInfo.java index d64effd69..9ea54347b 100644 --- a/src/share/classes/java/lang/management/ThreadInfo.java +++ b/src/share/classes/java/lang/management/ThreadInfo.java @@ -147,8 +147,9 @@ public class ThreadInfo { * @param waitedCount Number of times waited on a lock * @param waitedTime Approx time waited on a lock * @param stackTrace Thread stack trace - * @param lockedMonitors List of locked monitors - * @param lockedSynchronizers List of locked synchronizers + * @param monitors List of locked monitors + * @param stackDepths List of stack depths + * @param synchronizers List of locked synchronizers */ private ThreadInfo(Thread t, int state, Object lockObj, Thread lockOwner, long blockedCount, long blockedTime, diff --git a/src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java b/src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java index 4999dfa5f..349c9a008 100644 --- a/src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java +++ b/src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java @@ -99,7 +99,7 @@ abstract class AbstractPlainDatagramSocketImpl extends DatagramSocketImpl /** * Sends a datagram packet. The packet contains the data and the * destination address to send the packet to. - * @param packet to be sent. + * @param p the packet to be sent. */ protected abstract void send(DatagramPacket p) throws IOException; @@ -130,13 +130,13 @@ abstract class AbstractPlainDatagramSocketImpl extends DatagramSocketImpl /** * Peek at the packet to see who it is from. - * @param return the address which the packet came from. + * @param i the address to populate with the sender address */ protected abstract int peek(InetAddress i) throws IOException; protected abstract int peekData(DatagramPacket p) throws IOException; /** * Receive the datagram packet. - * @param Packet Received. + * @param p the packet to receive into */ protected synchronized void receive(DatagramPacket p) throws IOException { @@ -148,7 +148,7 @@ abstract class AbstractPlainDatagramSocketImpl extends DatagramSocketImpl /** * Set the TTL (time-to-live) option. - * @param TTL to be set. + * @param ttl TTL to be set. */ protected abstract void setTimeToLive(int ttl) throws IOException; @@ -159,7 +159,7 @@ abstract class AbstractPlainDatagramSocketImpl extends DatagramSocketImpl /** * Set the TTL (time-to-live) option. - * @param TTL to be set. + * @param ttl TTL to be set. */ @Deprecated protected abstract void setTTL(byte ttl) throws IOException; @@ -172,7 +172,7 @@ abstract class AbstractPlainDatagramSocketImpl extends DatagramSocketImpl /** * Join the multicast group. - * @param multicast address to join. + * @param inetaddr multicast address to join. */ protected void join(InetAddress inetaddr) throws IOException { join(inetaddr, null); @@ -180,14 +180,14 @@ abstract class AbstractPlainDatagramSocketImpl extends DatagramSocketImpl /** * Leave the multicast group. - * @param multicast address to leave. + * @param inetaddr multicast address to leave. */ protected void leave(InetAddress inetaddr) throws IOException { leave(inetaddr, null); } /** * Join the multicast group. - * @param multicast address to join. + * @param mcastaddr multicast address to join. * @param netIf specifies the local interface to receive multicast * datagram packets * @throws IllegalArgumentException if mcastaddr is null or is a @@ -207,7 +207,7 @@ abstract class AbstractPlainDatagramSocketImpl extends DatagramSocketImpl /** * Leave the multicast group. - * @param multicast address to leave. + * @param mcastaddr multicast address to leave. * @param netIf specified the local interface to leave the group at * @throws IllegalArgumentException if mcastaddr is null or is a * SocketAddress subclass not supported by this socket diff --git a/src/share/classes/java/net/AbstractPlainSocketImpl.java b/src/share/classes/java/net/AbstractPlainSocketImpl.java index e3373e821..749580594 100644 --- a/src/share/classes/java/net/AbstractPlainSocketImpl.java +++ b/src/share/classes/java/net/AbstractPlainSocketImpl.java @@ -368,7 +368,7 @@ abstract class AbstractPlainSocketImpl extends SocketImpl /** * Binds the socket to the specified address of the specified local port. * @param address the address - * @param port the port + * @param lport the port */ protected synchronized void bind(InetAddress address, int lport) throws IOException diff --git a/src/share/classes/java/net/DatagramSocket.java b/src/share/classes/java/net/DatagramSocket.java index 9e3bec3e4..749cf7820 100644 --- a/src/share/classes/java/net/DatagramSocket.java +++ b/src/share/classes/java/net/DatagramSocket.java @@ -105,7 +105,7 @@ class DatagramSocket implements java.io.Closeable { * Connects this socket to a remote socket address (IP address + port number). * Binds socket if not already bound. *

- * @param addr The remote address. + * @param address The remote address. * @param port The remote port * @throws SocketException if binding the socket fails. */ diff --git a/src/share/classes/java/net/Inet4Address.java b/src/share/classes/java/net/Inet4Address.java index 190b56353..5e98724a3 100644 --- a/src/share/classes/java/net/Inet4Address.java +++ b/src/share/classes/java/net/Inet4Address.java @@ -177,7 +177,6 @@ class Inet4Address extends InetAddress { * a loopback address; or false otherwise. * @since 1.4 */ - private static final int loopback = 2130706433; /* 127.0.0.1 */ public boolean isLoopbackAddress() { /* 127.x.x.x */ byte[] byteAddr = getAddress(); diff --git a/src/share/classes/java/net/SocketInputStream.java b/src/share/classes/java/net/SocketInputStream.java index 219cf0ab0..c6cefc725 100644 --- a/src/share/classes/java/net/SocketInputStream.java +++ b/src/share/classes/java/net/SocketInputStream.java @@ -112,7 +112,7 @@ class SocketInputStream extends FileInputStream * length bytes of data. * @param b the buffer into which the data is read * @param off the start offset of the data - * @param len the maximum number of bytes read + * @param length the maximum number of bytes read * @return the actual number of bytes read, -1 is * returned when the end of the stream is reached. * @exception IOException If an I/O error has occurred. @@ -209,7 +209,7 @@ class SocketInputStream extends FileInputStream /** * Skips n bytes of input. - * @param n the number of bytes to skip + * @param numbytes the number of bytes to skip * @return the actual number of bytes skipped. * @exception IOException If an I/O error has occurred. */ diff --git a/src/share/classes/java/net/SocketPermission.java b/src/share/classes/java/net/SocketPermission.java index da9abee01..02b86f171 100644 --- a/src/share/classes/java/net/SocketPermission.java +++ b/src/share/classes/java/net/SocketPermission.java @@ -138,7 +138,7 @@ import sun.security.util.Debug; */ public final class SocketPermission extends Permission -implements java.io.Serializable + implements java.io.Serializable { private static final long serialVersionUID = -7204263841984476862L; @@ -232,8 +232,7 @@ implements java.io.Serializable trustNameService = tmp.booleanValue(); } - private static synchronized Debug getDebug() - { + private static synchronized Debug getDebug() { if (!debugInit) { debug = Debug.getInstance("access"); debugInit = true; @@ -288,8 +287,7 @@ implements java.io.Serializable defaultDeny = true; } - private static String getHost(String host) - { + private static String getHost(String host) { if (host.equals("")) { return "localhost"; } else { @@ -679,8 +677,8 @@ implements java.io.Serializable } private boolean authorizedIPv4(String cname, byte[] addr) { - String authHost = ""; - InetAddress auth; + String authHost = ""; + InetAddress auth; try { authHost = "auth." + @@ -708,8 +706,8 @@ implements java.io.Serializable } private boolean authorizedIPv6(String cname, byte[] addr) { - String authHost = ""; - InetAddress auth; + String authHost = ""; + InetAddress auth; try { StringBuffer sb = new StringBuffer(39); @@ -810,7 +808,6 @@ implements java.io.Serializable * @return true if the specified permission is implied by this object, * false if not. */ - public boolean implies(Permission p) { int i,j; @@ -844,12 +841,11 @@ implements java.io.Serializable * to find a match based on the IP addresses in both objects. *

  • Attempt to match on the canonical hostnames of both objects. * - * @param p the incoming permission request + * @param that the incoming permission request * * @return true if "permission" is a proper subset of the current object, * false if not. */ - boolean impliesIgnoreMask(SocketPermission that) { int i,j; @@ -1229,7 +1225,7 @@ else its the cname? */ final class SocketPermissionCollection extends PermissionCollection -implements Serializable + implements Serializable { // Not serialized; see serialization section at end of class private transient List perms; @@ -1255,9 +1251,7 @@ implements Serializable * @exception SecurityException - if this SocketPermissionCollection object * has been marked readonly */ - - public void add(Permission permission) - { + public void add(Permission permission) { if (! (permission instanceof SocketPermission)) throw new IllegalArgumentException("invalid permission: "+ permission); @@ -1276,7 +1270,7 @@ implements Serializable * Check and see if this collection of permissions implies the permissions * expressed in "permission". * - * @param p the Permission object to compare + * @param permission the Permission object to compare * * @return true if "permission" is a proper subset of a permission in * the collection, false if not. @@ -1369,8 +1363,9 @@ implements Serializable /* * Reads in a Vector of SocketPermissions and saves them in the perms field. */ - private void readObject(ObjectInputStream in) throws IOException, - ClassNotFoundException { + private void readObject(ObjectInputStream in) + throws IOException, ClassNotFoundException + { // Don't call in.defaultReadObject() // Read in serialized fields diff --git a/src/share/classes/java/net/SocksSocketImpl.java b/src/share/classes/java/net/SocksSocketImpl.java index 4fb61efe6..f87f07449 100644 --- a/src/share/classes/java/net/SocksSocketImpl.java +++ b/src/share/classes/java/net/SocksSocketImpl.java @@ -644,7 +644,7 @@ class SocksSocketImpl extends PlainSocketImpl implements SocksConsts { * means "accept incoming connection from", so the SocketAddress is the * the one of the host we do accept connection from. * - * @param addr the Socket address of the remote host. + * @param saddr the Socket address of the remote host. * @exception IOException if an I/O error occurs when binding this socket. */ protected synchronized void socksBind(InetSocketAddress saddr) throws IOException { diff --git a/src/share/classes/java/net/URLConnection.java b/src/share/classes/java/net/URLConnection.java index cc747a8ee..d198578a2 100644 --- a/src/share/classes/java/net/URLConnection.java +++ b/src/share/classes/java/net/URLConnection.java @@ -1241,10 +1241,9 @@ public abstract class URLConnection { /** * Gets the Content Handler appropriate for this connection. - * @param connection the connection to use. */ synchronized ContentHandler getContentHandler() - throws UnknownServiceException + throws UnknownServiceException { String contentType = stripOffParameters(getContentType()); ContentHandler handler = null; diff --git a/src/share/classes/java/nio/channels/Channels.java b/src/share/classes/java/nio/channels/Channels.java index c1ad782d0..7f0266b43 100644 --- a/src/share/classes/java/nio/channels/Channels.java +++ b/src/share/classes/java/nio/channels/Channels.java @@ -84,7 +84,7 @@ public final class Channels { /** * Write all remaining bytes in buffer to the given channel. * - * @throws IllegalBlockingException + * @throws IllegalBlockingModeException * If the channel is selectable and configured non-blocking. */ private static void writeFully(WritableByteChannel ch, ByteBuffer bb) diff --git a/src/share/classes/java/nio/file/FileSystem.java b/src/share/classes/java/nio/file/FileSystem.java index 9091f4aae..707d1750d 100644 --- a/src/share/classes/java/nio/file/FileSystem.java +++ b/src/share/classes/java/nio/file/FileSystem.java @@ -347,7 +347,7 @@ public abstract class FileSystem * C:\\* * Matches C:\foo and C:\bar on the Windows * platform (note that the backslash is escaped; as a string literal in the - * Java Language the pattern would be "C:\\\\*") + * Java Language the pattern would be "C:\\\\*") * * * diff --git a/src/share/classes/java/nio/file/Files.java b/src/share/classes/java/nio/file/Files.java index e3449b048..1e15e770f 100644 --- a/src/share/classes/java/nio/file/Files.java +++ b/src/share/classes/java/nio/file/Files.java @@ -510,7 +510,7 @@ public final class Files { * 
          *     DirectoryStream.Filter<Path> filter = new DirectoryStream.Filter<Path>() {
      *         public boolean accept(Path file) throws IOException {
-     *             return (Files.size(file) > 8192L);
+     *             return (Files.size(file) > 8192L);
      *         }
      *     };
      *     Path dir = ...
@@ -1592,7 +1592,7 @@ public final class Files {
      *     Path path = ...
      *     AclFileAttributeView view = Files.getFileAttributeView(path, AclFileAttributeView.class);
      *     if (view != null) {
-     *         List<AclEntry> acl = view.getAcl();
+     *         List<AclEntry> acl = view.getAcl();
      *         :
      *     }
      *
    diff --git a/src/share/classes/java/nio/file/Path.java b/src/share/classes/java/nio/file/Path.java index afe07a387..eec1e631c 100644 --- a/src/share/classes/java/nio/file/Path.java +++ b/src/share/classes/java/nio/file/Path.java @@ -522,7 +522,7 @@ public interface Path * * @return a {@code Path} object representing the absolute path * - * @throws IOError + * @throws java.io.IOError * if an I/O error occurs * @throws SecurityException * In the case of the default provider, a security manager diff --git a/src/share/classes/java/nio/file/attribute/AclFileAttributeView.java b/src/share/classes/java/nio/file/attribute/AclFileAttributeView.java index f82ed445a..aefa8f95b 100644 --- a/src/share/classes/java/nio/file/attribute/AclFileAttributeView.java +++ b/src/share/classes/java/nio/file/attribute/AclFileAttributeView.java @@ -85,7 +85,7 @@ import java.io.IOException; * .build(); * * // read ACL, insert ACE, re-write ACL - * List<AclEntry> acl = view.getAcl(); + * List<AclEntry> acl = view.getAcl(); * acl.add(0, entry); // insert before any DENY entries * view.setAcl(acl); * diff --git a/src/share/classes/java/nio/file/attribute/FileTime.java b/src/share/classes/java/nio/file/attribute/FileTime.java index 988ad2177..fbc90b72c 100644 --- a/src/share/classes/java/nio/file/attribute/FileTime.java +++ b/src/share/classes/java/nio/file/attribute/FileTime.java @@ -310,7 +310,7 @@ public final class FileTime private final long days; /** - * The excess (in nanoseconds); can be negative if days <= 0. + * The excess (in nanoseconds); can be negative if days <= 0. */ private final long excessNanos; diff --git a/src/share/classes/java/security/AllPermission.java b/src/share/classes/java/security/AllPermission.java index 0c56f089e..bbfe954c9 100644 --- a/src/share/classes/java/security/AllPermission.java +++ b/src/share/classes/java/security/AllPermission.java @@ -62,9 +62,7 @@ public final class AllPermission extends Permission { /** * Creates a new AllPermission object. */ - - public AllPermission() - { + public AllPermission() { super(""); } @@ -77,8 +75,7 @@ public final class AllPermission extends Permission { * @param name ignored * @param actions ignored. */ - public AllPermission(String name, String actions) - { + public AllPermission(String name, String actions) { this(); } @@ -120,8 +117,7 @@ public final class AllPermission extends Permission { * * @return the actions. */ - public String getActions() - { + public String getActions() { return ""; } @@ -133,7 +129,6 @@ public final class AllPermission extends Permission { * @return a new PermissionCollection object suitable for * storing AllPermissions. */ - public PermissionCollection newPermissionCollection() { return new AllPermissionCollection(); } @@ -157,8 +152,8 @@ public final class AllPermission extends Permission { */ final class AllPermissionCollection -extends PermissionCollection -implements java.io.Serializable + extends PermissionCollection + implements java.io.Serializable { // use serialVersionUID from JDK 1.2.2 for interoperability @@ -188,8 +183,7 @@ implements java.io.Serializable * has been marked readonly */ - public void add(Permission permission) - { + public void add(Permission permission) { if (! (permission instanceof AllPermission)) throw new IllegalArgumentException("invalid permission: "+ permission); @@ -203,13 +197,12 @@ implements java.io.Serializable * Check and see if this set of permissions implies the permissions * expressed in "permission". * - * @param p the Permission object to compare + * @param permission the Permission object to compare * * @return always returns true. */ - public boolean implies(Permission permission) - { + public boolean implies(Permission permission) { return all_allowed; // No sync; staleness OK } @@ -219,8 +212,7 @@ implements java.io.Serializable * * @return an enumeration of all the AllPermission objects. */ - public Enumeration elements() - { + public Enumeration elements() { return new Enumeration() { private boolean hasMore = all_allowed; diff --git a/src/share/classes/java/security/BasicPermission.java b/src/share/classes/java/security/BasicPermission.java index e6a28cbb2..7a3d981eb 100644 --- a/src/share/classes/java/security/BasicPermission.java +++ b/src/share/classes/java/security/BasicPermission.java @@ -68,7 +68,7 @@ import java.io.IOException; */ public abstract class BasicPermission extends Permission -implements java.io.Serializable + implements java.io.Serializable { private static final long serialVersionUID = 6279438298436773498L; @@ -84,10 +84,8 @@ implements java.io.Serializable /** * initialize a BasicPermission object. Common to all constructors. - * */ - private void init(String name) - { + private void init(String name) { if (name == null) throw new NullPointerException("name can't be null"); @@ -129,9 +127,7 @@ implements java.io.Serializable * @throws NullPointerException if name is null. * @throws IllegalArgumentException if name is empty. */ - - public BasicPermission(String name) - { + public BasicPermission(String name) { super(name); init(name); } @@ -148,8 +144,7 @@ implements java.io.Serializable * @throws NullPointerException if name is null. * @throws IllegalArgumentException if name is empty. */ - public BasicPermission(String name, String actions) - { + public BasicPermission(String name, String actions) { super(name); init(name); } @@ -238,8 +233,7 @@ implements java.io.Serializable * * @return the empty string "". */ - public String getActions() - { + public String getActions() { return ""; } @@ -296,7 +290,6 @@ implements java.io.Serializable * * @see java.security.Permission * @see java.security.Permissions - * @see java.security.PermissionsImpl * * * @author Roland Schemers @@ -305,8 +298,8 @@ implements java.io.Serializable */ final class BasicPermissionCollection -extends PermissionCollection -implements java.io.Serializable + extends PermissionCollection + implements java.io.Serializable { private static final long serialVersionUID = 739301742472979399L; @@ -360,9 +353,7 @@ implements java.io.Serializable * @exception SecurityException - if this BasicPermissionCollection object * has been marked readonly */ - - public void add(Permission permission) - { + public void add(Permission permission) { if (! (permission instanceof BasicPermission)) throw new IllegalArgumentException("invalid permission: "+ permission); @@ -398,16 +389,14 @@ implements java.io.Serializable * Check and see if this set of permissions implies the permissions * expressed in "permission". * - * @param p the Permission object to compare + * @param permission the Permission object to compare * * @return true if "permission" is a proper subset of a permission in * the set, false if not. */ - - public boolean implies(Permission permission) - { + public boolean implies(Permission permission) { if (! (permission instanceof BasicPermission)) - return false; + return false; BasicPermission bp = (BasicPermission) permission; @@ -468,7 +457,6 @@ implements java.io.Serializable * * @return an enumeration of all the BasicPermission objects. */ - public Enumeration elements() { // Convert Iterator of Map values into an Enumeration synchronized (this) { diff --git a/src/share/classes/java/security/CodeSource.java b/src/share/classes/java/security/CodeSource.java index 94cdcef59..7ab761114 100644 --- a/src/share/classes/java/security/CodeSource.java +++ b/src/share/classes/java/security/CodeSource.java @@ -207,7 +207,7 @@ public class CodeSource implements java.io.Serializable { * Returns the code signers associated with this CodeSource. *

    * If this CodeSource object was created using the - * {@link #CodeSource(URL url, Certificate[] certs)} + * {@link #CodeSource(URL url, java.security.cert.Certificate[] certs)} * constructor then its certificate chains are extracted and used to * create an array of CodeSigner objects. Note that only X.509 certificates * are examined - all other certificate types are ignored. diff --git a/src/share/classes/java/security/KeyStore.java b/src/share/classes/java/security/KeyStore.java index 26faa9ca9..010344bde 100644 --- a/src/share/classes/java/security/KeyStore.java +++ b/src/share/classes/java/security/KeyStore.java @@ -32,6 +32,7 @@ import java.security.cert.CertificateException; import java.util.*; import javax.crypto.SecretKey; +import javax.security.auth.DestroyFailedException; import javax.security.auth.callback.*; /** @@ -278,8 +279,7 @@ public class KeyStore { * @exception DestroyFailedException if this method was unable * to clear the password */ - public synchronized void destroy() - throws javax.security.auth.DestroyFailedException { + public synchronized void destroy() throws DestroyFailedException { destroyed = true; if (password != null) { Arrays.fill(password, ' '); diff --git a/src/share/classes/java/security/cert/PKIXRevocationChecker.java b/src/share/classes/java/security/cert/PKIXRevocationChecker.java index a97f834c3..ba85686c5 100644 --- a/src/share/classes/java/security/cert/PKIXRevocationChecker.java +++ b/src/share/classes/java/security/cert/PKIXRevocationChecker.java @@ -50,7 +50,7 @@ import java.util.Set; * status of certificates with OCSP and CRLs. By default, OCSP is the * preferred mechanism for checking revocation status, with CRLs as the * fallback mechanism. However, this preference can be switched to CRLs with - * the {@link Option.PREFER_CRLS} option. + * the {@link Option#PREFER_CRLS PREFER_CRLS} option. * *

    A {@code PKIXRevocationChecker} is obtained by calling the * {@link CertPathValidator#getRevocationChecker getRevocationChecker} method diff --git a/src/share/classes/java/sql/CallableStatement.java b/src/share/classes/java/sql/CallableStatement.java index 2f2a77594..460b02858 100644 --- a/src/share/classes/java/sql/CallableStatement.java +++ b/src/share/classes/java/sql/CallableStatement.java @@ -1562,7 +1562,7 @@ public interface CallableStatement extends PreparedStatement { * @param parameterName the name of the parameter * @return the parameter value in full precision. If the value is * SQL NULL, the result is null. - * @exception SQLExceptionif parameterName does not correspond to a named + * @exception SQLException if parameterName does not correspond to a named * parameter; if a database access error occurs or * this method is called on a closed CallableStatement * @exception SQLFeatureNotSupportedException if the JDBC driver does not support diff --git a/src/share/classes/java/text/CollationElementIterator.java b/src/share/classes/java/text/CollationElementIterator.java index 62b6a12c3..5ab68769e 100644 --- a/src/share/classes/java/text/CollationElementIterator.java +++ b/src/share/classes/java/text/CollationElementIterator.java @@ -119,7 +119,7 @@ public final class CollationElementIterator * on the predefined collation rules. If the source string is empty, * NULLORDER will be returned on the calls to next(). * @param sourceText the source string. - * @param order the collation object. + * @param owner the collation object. */ CollationElementIterator(String sourceText, RuleBasedCollator owner) { this.owner = owner; @@ -137,7 +137,7 @@ public final class CollationElementIterator * on the predefined collation rules. If the source string is empty, * NULLORDER will be returned on the calls to next(). * @param sourceText the source string. - * @param order the collation object. + * @param owner the collation object. */ CollationElementIterator(CharacterIterator sourceText, RuleBasedCollator owner) { this.owner = owner; diff --git a/src/share/classes/java/text/DigitList.java b/src/share/classes/java/text/DigitList.java index ec489dbd4..1f866e4f7 100644 --- a/src/share/classes/java/text/DigitList.java +++ b/src/share/classes/java/text/DigitList.java @@ -62,7 +62,7 @@ import java.math.RoundingMode; * derived by placing all the digits of the list to the right of the * decimal point, by 10^exponent. * - * @see Locale + * @see java.util.Locale * @see Format * @see NumberFormat * @see DecimalFormat diff --git a/src/share/classes/java/text/Format.java b/src/share/classes/java/text/Format.java index 2eec66718..ad7d95a53 100644 --- a/src/share/classes/java/text/Format.java +++ b/src/share/classes/java/text/Format.java @@ -370,7 +370,7 @@ public abstract class Format implements Serializable, Cloneable { * Delegates should NOT assume that the Format will notify * the delegate of fields in any particular order. * - * @see FieldPosition.Delegate + * @see FieldPosition#getFieldDelegate * @see CharacterIteratorFieldDelegate */ interface FieldDelegate { diff --git a/src/share/classes/java/text/RBCollationTables.java b/src/share/classes/java/text/RBCollationTables.java index aa349e68d..8285fa79e 100644 --- a/src/share/classes/java/text/RBCollationTables.java +++ b/src/share/classes/java/text/RBCollationTables.java @@ -192,13 +192,12 @@ final class RBCollationTables { * * @see CollationElementIterator#getMaxExpansion */ - int getMaxExpansion(int order) - { + int getMaxExpansion(int order) { int result = 1; if (expandTable != null) { // Right now this does a linear search through the entire - // expandsion table. If a collator had a large number of expansions, + // expansion table. If a collator had a large number of expansions, // this could cause a performance problem, but in practise that // rarely happens for (int i = 0; i < expandTable.size(); i++) { @@ -215,20 +214,19 @@ final class RBCollationTables { } /** - * Get the entry of hash table of the expanding string in the collation - * table. - * @param idx the index of the expanding string value list + * Get the entry of hash table of the expanding string in the collation + * table. + * @param idx the index of the expanding string value list */ - final int[] getExpandValueList(int order) { - return expandTable.elementAt(order - EXPANDCHARINDEX); + final int[] getExpandValueList(int idx) { + return expandTable.elementAt(idx - EXPANDCHARINDEX); } /** - * Get the comarison order of a character from the collation table. - * @return the comparison order of a character. + * Get the comarison order of a character from the collation table. + * @return the comparison order of a character. */ - int getUnicodeOrder(int ch) - { + int getUnicodeOrder(int ch) { return mapping.elementAt(ch); } diff --git a/src/share/classes/java/text/RBTableBuilder.java b/src/share/classes/java/text/RBTableBuilder.java index a78872949..d8ff4fe70 100644 --- a/src/share/classes/java/text/RBTableBuilder.java +++ b/src/share/classes/java/text/RBTableBuilder.java @@ -71,7 +71,7 @@ final class RBTableBuilder { * This is the main function that actually builds the tables and * stores them back in the RBCollationTables object. It is called * ONLY by the RBCollationTables constructor. - * @see java.util.RuleBasedCollator#RuleBasedCollator + * @see RuleBasedCollator#RuleBasedCollator * @exception ParseException If the rules format is incorrect. */ diff --git a/src/share/classes/java/text/SimpleDateFormat.java b/src/share/classes/java/text/SimpleDateFormat.java index b2751d20f..b434b6b78 100644 --- a/src/share/classes/java/text/SimpleDateFormat.java +++ b/src/share/classes/java/text/SimpleDateFormat.java @@ -1787,7 +1787,7 @@ public class SimpleDateFormat extends DateFormat { * timeFields. Returns -start (for ParsePosition) if failed. * @param text the time text to be parsed. * @param start where to start parsing. - * @param ch the pattern character for the date field text to be parsed. + * @param patternCharIndex the index of the pattern character. * @param count the count of a pattern character. * @param obeyCount if true, then the next field directly abuts this one, * and we should use the count to know when to stop parsing. diff --git a/src/share/classes/java/util/Calendar.java b/src/share/classes/java/util/Calendar.java index 602115ae1..d8c407bdb 100644 --- a/src/share/classes/java/util/Calendar.java +++ b/src/share/classes/java/util/Calendar.java @@ -1788,7 +1788,6 @@ public abstract class Calendar implements Serializable, Cloneable, Comparable If the {@code '0'} flag is given then the output will be padded * with leading zeros to the field width following any indication of sign. * - *

    If {@code '('}, {@code '+'}, '  ', or {@code ','} flags + *

    If {@code '('}, {@code '+'}, '  ', or {@code ','} flags * are given then a {@link FormatFlagsConversionMismatchException} will be * thrown. * diff --git a/src/share/classes/java/util/JapaneseImperialCalendar.java b/src/share/classes/java/util/JapaneseImperialCalendar.java index f277efe8c..566d59ade 100644 --- a/src/share/classes/java/util/JapaneseImperialCalendar.java +++ b/src/share/classes/java/util/JapaneseImperialCalendar.java @@ -1932,7 +1932,7 @@ class JapaneseImperialCalendar extends Calendar { * Computes the fixed date under either the Gregorian or the * Julian calendar, using the given year and the specified calendar fields. * - * @param cal the CalendarSystem to be used for the date calculation + * @param era era index * @param year the normalized year number, with 0 indicating the * year 1 BCE, -1 indicating 2 BCE, etc. * @param fieldMask the calendar fields to be used for the date calculation @@ -2141,7 +2141,7 @@ class JapaneseImperialCalendar extends Calendar { * Returns the length of the specified month in the specified * Gregorian year. The year number must be normalized. * - * @see #isLeapYear(int) + * @see GregorianCalendar#isLeapYear(int) */ private int monthLength(int month, int gregorianYear) { return CalendarUtils.isGregorianLeapYear(gregorianYear) ? @@ -2152,7 +2152,7 @@ class JapaneseImperialCalendar extends Calendar { * Returns the length of the specified month in the year provided * by internalGet(YEAR). * - * @see #isLeapYear(int) + * @see GregorianCalendar#isLeapYear(int) */ private int monthLength(int month) { assert jdate.isNormalized(); diff --git a/src/share/classes/java/util/JumboEnumSet.java b/src/share/classes/java/util/JumboEnumSet.java index d2f3e83f7..679851182 100644 --- a/src/share/classes/java/util/JumboEnumSet.java +++ b/src/share/classes/java/util/JumboEnumSet.java @@ -345,7 +345,7 @@ class JumboEnumSet> extends EnumSet { * the same size, and every member of the given set is contained in * this set. * - * @param e object to be compared for equality with this set + * @param o object to be compared for equality with this set * @return true if the specified object is equal to this set */ public boolean equals(Object o) { diff --git a/src/share/classes/java/util/Locale.java b/src/share/classes/java/util/Locale.java index b7bed24f4..9d469e466 100644 --- a/src/share/classes/java/util/Locale.java +++ b/src/share/classes/java/util/Locale.java @@ -1492,7 +1492,7 @@ public final class Locale implements Cloneable, Serializable { * // returns "ja-JP-u-ca-japanese-x-lvariant-JP" * Locale.forLanguageTag("th-TH-x-lvariant-TH").toLanguageTag(); * // returns "th-TH-u-nu-thai-x-lvariant-TH" - * 

    
+     *
    * *

    This implements the 'Language-Tag' production of BCP47, and * so supports grandfathered (regular and irregular) as well as @@ -2143,7 +2143,7 @@ public final class Locale implements Cloneable, Serializable { * @param in the ObjectInputStream to read * @throws IOException * @throws ClassNotFoundException - * @throws IllformdLocaleException + * @throws IllformedLocaleException * @since 1.7 */ private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException { diff --git a/src/share/classes/java/util/PropertyPermission.java b/src/share/classes/java/util/PropertyPermission.java index aed6f5c48..de8a23d77 100644 --- a/src/share/classes/java/util/PropertyPermission.java +++ b/src/share/classes/java/util/PropertyPermission.java @@ -130,18 +130,15 @@ public final class PropertyPermission extends BasicPermission { * @param mask the actions mask to use. * */ - - private void init(int mask) - { - + private void init(int mask) { if ((mask & ALL) != mask) - throw new IllegalArgumentException("invalid actions mask"); + throw new IllegalArgumentException("invalid actions mask"); if (mask == NONE) - throw new IllegalArgumentException("invalid actions mask"); + throw new IllegalArgumentException("invalid actions mask"); if (getName() == null) - throw new NullPointerException("name can't be null"); + throw new NullPointerException("name can't be null"); this.mask = mask; } @@ -160,9 +157,7 @@ public final class PropertyPermission extends BasicPermission { * @throws IllegalArgumentException if name is empty or if * actions is invalid. */ - - public PropertyPermission(String name, String actions) - { + public PropertyPermission(String name, String actions) { super(name,actions); init(getMask(actions)); } @@ -196,7 +191,6 @@ public final class PropertyPermission extends BasicPermission { return ((this.mask & that.mask) == that.mask) && super.implies(that); } - /** * Checks two PropertyPermission objects for equality. Checks that obj is * a PropertyPermission, and has the same name and actions as this object. @@ -226,16 +220,14 @@ public final class PropertyPermission extends BasicPermission { * * @return a hash code value for this object. */ - public int hashCode() { return this.getName().hashCode(); } - /** * Converts an actions String to an actions mask. * - * @param action the action string. + * @param actions the action string. * @return the actions mask. */ private static int getMask(String actions) { @@ -332,8 +324,7 @@ public final class PropertyPermission extends BasicPermission { * * @return the canonical string representation of the actions. */ - static String getActions(int mask) - { + static String getActions(int mask) { StringBuilder sb = new StringBuilder(); boolean comma = false; @@ -359,8 +350,7 @@ public final class PropertyPermission extends BasicPermission { * * @return the canonical string representation of the actions. */ - public String getActions() - { + public String getActions() { if (actions == null) actions = getActions(this.mask); @@ -373,7 +363,6 @@ public final class PropertyPermission extends BasicPermission { * * @return the actions mask. */ - int getMask() { return mask; } @@ -386,7 +375,6 @@ public final class PropertyPermission extends BasicPermission { * @return a new PermissionCollection object suitable for storing * PropertyPermissions. */ - public PermissionCollection newPermissionCollection() { return new PropertyPermissionCollection(); } @@ -436,7 +424,7 @@ public final class PropertyPermission extends BasicPermission { * @serial include */ final class PropertyPermissionCollection extends PermissionCollection -implements Serializable + implements Serializable { /** @@ -454,10 +442,8 @@ implements Serializable private boolean all_allowed; /** - * Create an empty PropertyPermissions object. - * + * Create an empty PropertyPermissionCollection object. */ - public PropertyPermissionCollection() { perms = new HashMap<>(32); // Capacity for default policy all_allowed = false; @@ -475,9 +461,7 @@ implements Serializable * @exception SecurityException - if this PropertyPermissionCollection * object has been marked readonly */ - - public void add(Permission permission) - { + public void add(Permission permission) { if (! (permission instanceof PropertyPermission)) throw new IllegalArgumentException("invalid permission: "+ permission); @@ -514,14 +498,12 @@ implements Serializable * Check and see if this set of permissions implies the permissions * expressed in "permission". * - * @param p the Permission object to compare + * @param permission the Permission object to compare * * @return true if "permission" is a proper subset of a permission in * the set, false if not. */ - - public boolean implies(Permission permission) - { + public boolean implies(Permission permission) { if (! (permission instanceof PropertyPermission)) return false; @@ -655,8 +637,9 @@ implements Serializable * Reads in a Hashtable of PropertyPermissions and saves them in the * perms field. Reads in all_allowed. */ - private void readObject(ObjectInputStream in) throws IOException, - ClassNotFoundException { + private void readObject(ObjectInputStream in) + throws IOException, ClassNotFoundException + { // Don't call defaultReadObject() // Read in serialized fields diff --git a/src/share/classes/java/util/RegularEnumSet.java b/src/share/classes/java/util/RegularEnumSet.java index 63f5f52e6..bf01c5193 100644 --- a/src/share/classes/java/util/RegularEnumSet.java +++ b/src/share/classes/java/util/RegularEnumSet.java @@ -289,7 +289,7 @@ class RegularEnumSet> extends EnumSet { * the same size, and every member of the given set is contained in * this set. * - * @param e object to be compared for equality with this set + * @param o object to be compared for equality with this set * @return true if the specified object is equal to this set */ public boolean equals(Object o) { diff --git a/src/share/classes/java/util/Scanner.java b/src/share/classes/java/util/Scanner.java index e80b27a39..4530371ac 100644 --- a/src/share/classes/java/util/Scanner.java +++ b/src/share/classes/java/util/Scanner.java @@ -568,9 +568,8 @@ public final class Scanner implements Iterator, Closeable { * Constructs a Scanner that returns values scanned * from the specified source delimited by the specified pattern. * - * @param source A character source implementing the Readable interface + * @param source A character source implementing the Readable interface * @param pattern A delimiting pattern - * @return A scanner with the specified source and pattern */ private Scanner(Readable source, Pattern pattern) { assert source != null : "source should not be null"; diff --git a/src/share/classes/java/util/TimeZone.java b/src/share/classes/java/util/TimeZone.java index 3613328ca..648191a47 100644 --- a/src/share/classes/java/util/TimeZone.java +++ b/src/share/classes/java/util/TimeZone.java @@ -221,7 +221,7 @@ abstract public class TimeZone implements Serializable, Cloneable { * @param date the milliseconds (since January 1, 1970, * 00:00:00.000 GMT) at which the time zone offset and daylight * saving amount are found - * @param offset an array of int where the raw GMT offset + * @param offsets an array of int where the raw GMT offset * (offset[0]) and daylight saving amount (offset[1]) are stored, * or null if those values are not needed. The method assumes that * the length of the given array is two or larger. diff --git a/src/share/classes/java/util/logging/Logging.java b/src/share/classes/java/util/logging/Logging.java index 6221a7e69..249234918 100644 --- a/src/share/classes/java/util/logging/Logging.java +++ b/src/share/classes/java/util/logging/Logging.java @@ -41,8 +41,8 @@ import java.util.ArrayList; * @since 1.5 * * @see javax.management - * @see java.util.Logger - * @see java.util.LogManager + * @see Logger + * @see LogManager */ class Logging implements LoggingMXBean { diff --git a/src/share/classes/java/util/prefs/XmlSupport.java b/src/share/classes/java/util/prefs/XmlSupport.java index 08f19d82d..e47f0401a 100644 --- a/src/share/classes/java/util/prefs/XmlSupport.java +++ b/src/share/classes/java/util/prefs/XmlSupport.java @@ -92,7 +92,7 @@ class XmlSupport { * @throws BackingStoreException if preference data cannot be read from * backing store. * @throws IllegalStateException if this node (or an ancestor) has been - * removed with the {@link #removeNode()} method. + * removed with the {@link Preferences#removeNode()} method. */ static void export(OutputStream os, final Preferences p, boolean subTree) throws IOException, BackingStoreException { diff --git a/src/share/classes/javax/crypto/CryptoAllPermission.java b/src/share/classes/javax/crypto/CryptoAllPermission.java index ad5e7fb7b..08ea24244 100644 --- a/src/share/classes/javax/crypto/CryptoAllPermission.java +++ b/src/share/classes/javax/crypto/CryptoAllPermission.java @@ -136,8 +136,7 @@ final class CryptoAllPermissionCollection extends PermissionCollection * @exception SecurityException - if this CryptoAllPermissionCollection * object has been marked readonly */ - public void add(Permission permission) - { + public void add(Permission permission) { if (isReadOnly()) throw new SecurityException("attempt to add a Permission to " + "a readonly PermissionCollection"); @@ -152,13 +151,12 @@ final class CryptoAllPermissionCollection extends PermissionCollection * Check and see if this set of permissions implies the permissions * expressed in "permission". * - * @param p the Permission object to compare + * @param permission the Permission object to compare * * @return true if the given permission is implied by this * CryptoAllPermissionCollection. */ - public boolean implies(Permission permission) - { + public boolean implies(Permission permission) { if (!(permission instanceof CryptoPermission)) { return false; } diff --git a/src/share/classes/javax/crypto/CryptoPermission.java b/src/share/classes/javax/crypto/CryptoPermission.java index 6241e5fdb..b259bec0e 100644 --- a/src/share/classes/javax/crypto/CryptoPermission.java +++ b/src/share/classes/javax/crypto/CryptoPermission.java @@ -471,8 +471,8 @@ class CryptoPermission extends java.security.Permission { * @author Sharon Liu */ final class CryptoPermissionCollection extends PermissionCollection -implements Serializable { - + implements Serializable +{ private static final long serialVersionUID = -511215555898802763L; private Vector permissions; @@ -493,8 +493,7 @@ implements Serializable { * @exception SecurityException - if this CryptoPermissionCollection * object has been marked readOnly. */ - public void add(Permission permission) - { + public void add(Permission permission) { if (isReadOnly()) throw new SecurityException("attempt to add a Permission " + "to a readonly PermissionCollection"); @@ -506,10 +505,10 @@ implements Serializable { } /** - * Check and see if this CryptoPermission object implies - * the given Permission object. + * Check and see if this CryptoPermission object implies + * the given Permission object. * - * @param p the Permission object to compare + * @param permission the Permission object to compare * * @return true if the given permission is implied by this * CryptoPermissionCollection, false if not. @@ -538,8 +537,7 @@ implements Serializable { * @return an enumeration of all the CryptoPermission objects. */ - public Enumeration elements() - { + public Enumeration elements() { return permissions.elements(); } } diff --git a/src/share/classes/javax/crypto/CryptoPolicyParser.java b/src/share/classes/javax/crypto/CryptoPolicyParser.java index e44d3299f..617d2a44c 100644 --- a/src/share/classes/javax/crypto/CryptoPolicyParser.java +++ b/src/share/classes/javax/crypto/CryptoPolicyParser.java @@ -54,7 +54,7 @@ import java.lang.reflect.*; * @author Sharon Liu * * @see java.security.Permissions - * @see java.security.spec.AlgrithomParameterSpec + * @see java.security.spec.AlgorithmParameterSpec * @see javax.crypto.CryptoPermission * @see javax.crypto.CryptoAllPermission * @see javax.crypto.CryptoPermissions diff --git a/src/share/classes/javax/crypto/NullCipherSpi.java b/src/share/classes/javax/crypto/NullCipherSpi.java index 7f429c14f..15c27d6f5 100644 --- a/src/share/classes/javax/crypto/NullCipherSpi.java +++ b/src/share/classes/javax/crypto/NullCipherSpi.java @@ -33,7 +33,7 @@ import java.security.spec.*; * tranform the plaintext. * * @author Li Gong - * @see Nullcipher + * @see NullCipher * * @since 1.4 */ diff --git a/src/share/classes/javax/management/loading/MLet.java b/src/share/classes/javax/management/loading/MLet.java index 3d6a5b71a..b1dc72aa6 100644 --- a/src/share/classes/javax/management/loading/MLet.java +++ b/src/share/classes/javax/management/loading/MLet.java @@ -798,7 +798,7 @@ public class MLet extends java.net.URLClassLoader * Allows the m-let to perform any operations it needs before being unregistered * by the MBean server. * - * @exception java.langException This exception should be caught + * @exception java.lang.Exception This exception should be caught * by the MBean server and re-thrown as an * MBeanRegistrationException. */ diff --git a/src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java b/src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java index 4b13db029..ec8201386 100644 --- a/src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java +++ b/src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java @@ -189,7 +189,7 @@ public class ModelMBeanAttributeInfo * May be null if the property is write-only. * @param setter The method used for writing the attribute value. * May be null if the attribute is read-only. - * @exception IntrospectionException There is a consistency + * @exception javax.management.IntrospectionException There is a consistency * problem in the definition of this attribute. * */ @@ -233,7 +233,7 @@ public class ModelMBeanAttributeInfo * it is null, then a default descriptor will be created. If * the descriptor does not contain the field "displayName" this field is added * in the descriptor with its default value. - * @exception IntrospectionException There is a consistency + * @exception javax.management.IntrospectionException There is a consistency * problem in the definition of this attribute. * @exception RuntimeOperationsException Wraps an * IllegalArgumentException. The descriptor is invalid, or descriptor diff --git a/src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java b/src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java index 691fdbaa9..771905443 100644 --- a/src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java +++ b/src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java @@ -124,11 +124,6 @@ public class CompositeDataInvocationHandler implements InvocationHandler {

    Construct a handler backed by the given {@code CompositeData}.

    - @param mbsc the {@code MBeanServerConnection} related to this - {@code CompositeData}. This is only relevant if a method in - the interface for which this is an invocation handler returns - a type that is an MXBean interface. Otherwise, it can be null. - @param compositeData the {@code CompositeData} that will supply information to getters. diff --git a/src/share/classes/javax/naming/spi/NamingManager.java b/src/share/classes/javax/naming/spi/NamingManager.java index 13bd52991..fb4f68527 100644 --- a/src/share/classes/javax/naming/spi/NamingManager.java +++ b/src/share/classes/javax/naming/spi/NamingManager.java @@ -416,7 +416,7 @@ public class NamingManager { * specified. * See the getObjectInstance method for * details. - * @param ctx The context relative to which name is + * @param nameCtx The context relative to which name is * specified, or null for the default initial context. * See the getObjectInstance method for * details. diff --git a/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java b/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java index 3304ac872..6a712d0a0 100644 --- a/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java +++ b/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java @@ -178,7 +178,6 @@ public final class DelegationPermission extends BasicPermission * * @return a hash code value for this object. */ - public int hashCode() { return getName().hashCode(); } @@ -278,12 +277,11 @@ final class KrbDelegationPermissionCollection extends PermissionCollection * Check and see if this collection of permissions implies the permissions * expressed in "permission". * - * @param p the Permission object to compare + * @param permission the Permission object to compare * * @return true if "permission" is a proper subset of a permission in * the collection, false if not. */ - public boolean implies(Permission permission) { if (! (permission instanceof DelegationPermission)) return false; @@ -310,7 +308,6 @@ final class KrbDelegationPermissionCollection extends PermissionCollection * @exception SecurityException - if this PermissionCollection object * has been marked readonly */ - public void add(Permission permission) { if (! (permission instanceof DelegationPermission)) throw new IllegalArgumentException("invalid permission: "+ @@ -329,7 +326,6 @@ final class KrbDelegationPermissionCollection extends PermissionCollection * * @return an enumeration of all the DelegationPermission objects. */ - public Enumeration elements() { // Convert Iterator into Enumeration synchronized (this) { @@ -376,8 +372,9 @@ final class KrbDelegationPermissionCollection extends PermissionCollection * Reads in a Vector of DelegationPermissions and saves them in the perms field. */ @SuppressWarnings("unchecked") - private void readObject(ObjectInputStream in) throws IOException, - ClassNotFoundException { + private void readObject(ObjectInputStream in) + throws IOException, ClassNotFoundException + { // Don't call defaultReadObject() // Read in serialized fields diff --git a/src/share/classes/javax/security/auth/kerberos/ServicePermission.java b/src/share/classes/javax/security/auth/kerberos/ServicePermission.java index a22e8cc42..da6c9fe3f 100644 --- a/src/share/classes/javax/security/auth/kerberos/ServicePermission.java +++ b/src/share/classes/javax/security/auth/kerberos/ServicePermission.java @@ -259,7 +259,6 @@ public final class ServicePermission extends Permission * Always returns present actions in the following order: * initiate, accept. */ - public String getActions() { if (actions == null) actions = getActions(this.mask); @@ -280,7 +279,6 @@ public final class ServicePermission extends Permission * @return a new PermissionCollection object suitable for storing * ServicePermissions. */ - public PermissionCollection newPermissionCollection() { return new KrbServicePermissionCollection(); } @@ -290,7 +288,6 @@ public final class ServicePermission extends Permission * * @return the actions mask. */ - int getMask() { return mask; } @@ -301,7 +298,6 @@ public final class ServicePermission extends Permission * @param action the action string * @return the action mask */ - private static int getMask(String action) { if (action == null) { @@ -468,12 +464,11 @@ final class KrbServicePermissionCollection extends PermissionCollection * Check and see if this collection of permissions implies the permissions * expressed in "permission". * - * @param p the Permission object to compare + * @param permission the Permission object to compare * * @return true if "permission" is a proper subset of a permission in * the collection, false if not. */ - public boolean implies(Permission permission) { if (! (permission instanceof ServicePermission)) return false; @@ -517,7 +512,6 @@ final class KrbServicePermissionCollection extends PermissionCollection * @exception SecurityException - if this PermissionCollection object * has been marked readonly */ - public void add(Permission permission) { if (! (permission instanceof ServicePermission)) throw new IllegalArgumentException("invalid permission: "+ @@ -584,8 +578,9 @@ final class KrbServicePermissionCollection extends PermissionCollection * Reads in a Vector of ServicePermissions and saves them in the perms field. */ @SuppressWarnings("unchecked") - private void readObject(ObjectInputStream in) throws IOException, - ClassNotFoundException { + private void readObject(ObjectInputStream in) + throws IOException, ClassNotFoundException + { // Don't call defaultReadObject() // Read in serialized fields diff --git a/src/share/classes/javax/sql/ConnectionPoolDataSource.java b/src/share/classes/javax/sql/ConnectionPoolDataSource.java index cdaa3290f..9664fcc83 100644 --- a/src/share/classes/javax/sql/ConnectionPoolDataSource.java +++ b/src/share/classes/javax/sql/ConnectionPoolDataSource.java @@ -48,7 +48,7 @@ public interface ConnectionPoolDataSource extends CommonDataSource { * connection to the database that this * ConnectionPoolDataSource object represents * @exception SQLException if a database access error occurs - * @exception SQLFeatureNotSupportedException if the JDBC driver does not support + * @exception java.sql.SQLFeatureNotSupportedException if the JDBC driver does not support * this method * @since 1.4 */ @@ -64,7 +64,7 @@ public interface ConnectionPoolDataSource extends CommonDataSource { * connection to the database that this * ConnectionPoolDataSource object represents * @exception SQLException if a database access error occurs - * @exception SQLFeatureNotSupportedException if the JDBC driver does not support + * @exception java.sql.SQLFeatureNotSupportedException if the JDBC driver does not support * this method * @since 1.4 */ diff --git a/src/share/classes/javax/sql/PooledConnection.java b/src/share/classes/javax/sql/PooledConnection.java index e5d9ec442..799b46d83 100644 --- a/src/share/classes/javax/sql/PooledConnection.java +++ b/src/share/classes/javax/sql/PooledConnection.java @@ -102,7 +102,7 @@ public interface PooledConnection { * @return a Connection object that is a handle to * this PooledConnection object * @exception SQLException if a database access error occurs - * @exception SQLFeatureNotSupportedException if the JDBC driver does not support + * @exception java.sql.SQLFeatureNotSupportedException if the JDBC driver does not support * this method * @since 1.4 */ @@ -117,7 +117,7 @@ public interface PooledConnection { * information. * * @exception SQLException if a database access error occurs - * @exception SQLFeatureNotSupportedException if the JDBC driver does not support + * @exception java.sql.SQLFeatureNotSupportedException if the JDBC driver does not support * this method * @since 1.4 */ diff --git a/src/share/classes/javax/sql/rowset/spi/SyncProvider.java b/src/share/classes/javax/sql/rowset/spi/SyncProvider.java index 814259988..f18ab57f1 100644 --- a/src/share/classes/javax/sql/rowset/spi/SyncProvider.java +++ b/src/share/classes/javax/sql/rowset/spi/SyncProvider.java @@ -293,7 +293,7 @@ public abstract class SyncProvider { * SyncProvider.DATASOURCE_TABLE_LOCK, * SyncProvider.DATASOURCE_DB_LOCK * - * @throws SyncProviderExceptiom if an error occurs determining the data + * @throws SyncProviderException if an error occurs determining the data * source locking level. * @see #setDataSourceLock -- GitLab