From 73368c0eaa33b4dff52bc6298d68e9a8fd589942 Mon Sep 17 00:00:00 2001 From: ohair Date: Tue, 30 Nov 2010 17:46:42 -0800 Subject: [PATCH] 6987107: Add variable to add to but not modify non-fcs version string Reviewed-by: jcoomes, dholmes, andrew, kvn --- make/common/shared/Defs.gmk | 13 +++++++++---- make/jprt.gmk | 3 --- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/make/common/shared/Defs.gmk b/make/common/shared/Defs.gmk index ca5556456..43e27a5a4 100644 --- a/make/common/shared/Defs.gmk +++ b/make/common/shared/Defs.gmk @@ -287,9 +287,12 @@ ifdef BUILD_NUMBER FULL_VERSION = $(RELEASE)-$(BUILD_NUMBER) else BUILD_NUMBER = b00 - BUILD_DATE := $(shell $(DATE) '+%Y_%m_%d_%H_%M') - CLEAN_USERNAME := $(shell $(ECHO) "$(USER)" | $(TR) -d -c '[:alnum:]') - USER_RELEASE_SUFFIX := $(shell $(ECHO) "$(CLEAN_USERNAME)_$(BUILD_DATE)" | $(TR) '[:upper:]' '[:lower:]' ) + ifndef USER_RELEASE_SUFFIX + BUILD_DATE := $(shell $(DATE) '+%Y_%m_%d_%H_%M') + CLEAN_USERNAME := $(shell $(ECHO) "$(USER)" | $(TR) -d -c '[:alnum:]') + USER_RELEASE_SUFFIX := $(shell $(ECHO) "$(CLEAN_USERNAME)_$(BUILD_DATE)" | $(TR) '[:upper:]' '[:lower:]' ) + endif + export USER_RELEASE_SUFFIX FULL_VERSION = $(RELEASE)-$(USER_RELEASE_SUFFIX)-$(BUILD_NUMBER) endif @@ -335,7 +338,9 @@ endif # Include any private definitions for this set of workspaces _PRIVATE_DEFS_FILE=$(JDK_MAKE_SHARED_DIR)/PrivateDefs.gmk -USING_PRIVATE_DEFS:=$(shell if [ -f $(_PRIVATE_DEFS_FILE) ]; then echo true; else echo false; fi) +ifeq ($(USING_PRIVATE_DEFS),) + USING_PRIVATE_DEFS:=$(shell if [ -f $(_PRIVATE_DEFS_FILE) ]; then echo true; else echo false; fi) +endif ifeq ($(USING_PRIVATE_DEFS),true) dummy:=$(warning "WARNING: Using definitions from $(_PRIVATE_DEFS_FILE)") include $(_PRIVATE_DEFS_FILE) diff --git a/make/jprt.gmk b/make/jprt.gmk index bd1189bf4..3ad4c1882 100644 --- a/make/jprt.gmk +++ b/make/jprt.gmk @@ -26,9 +26,6 @@ # JPRT rule to build this workspace JPRT_ARCHIVE_BUNDLE=$(ABS_OUTPUTDIR)/$(JPRT_BUILD_FLAVOR)-bundle.zip -ifdef JPRT_BUILD_VERSION - MILESTONE=$(JPRT_BUILD_VERSION) -endif jprt_build_product: all images ( $(CD) $(OUTPUTDIR)/j2sdk-image && \ -- GitLab