From 5e092ff9dc064726816e57e8be3c4e4ae60b697e Mon Sep 17 00:00:00 2001 From: alexp Date: Fri, 21 May 2010 22:04:35 +0400 Subject: [PATCH] 6953396: javax.swing.plaf.basic.BasicViewportUI.uninstallDefaults() is not called when UI is uninstalled Reviewed-by: rupashka --- .../swing/plaf/basic/BasicViewportUI.java | 2 +- .../swing/JViewport/6953396/bug6953396.java | 64 +++++++++++++++++++ 2 files changed, 65 insertions(+), 1 deletion(-) create mode 100644 test/javax/swing/JViewport/6953396/bug6953396.java diff --git a/src/share/classes/javax/swing/plaf/basic/BasicViewportUI.java b/src/share/classes/javax/swing/plaf/basic/BasicViewportUI.java index 4e4cfab3d..90e2de4a0 100644 --- a/src/share/classes/javax/swing/plaf/basic/BasicViewportUI.java +++ b/src/share/classes/javax/swing/plaf/basic/BasicViewportUI.java @@ -56,8 +56,8 @@ public class BasicViewportUI extends ViewportUI { } public void uninstallUI(JComponent c) { + uninstallDefaults(c); super.uninstallUI(c); - } protected void installDefaults(JComponent c) { diff --git a/test/javax/swing/JViewport/6953396/bug6953396.java b/test/javax/swing/JViewport/6953396/bug6953396.java new file mode 100644 index 000000000..0662ccd74 --- /dev/null +++ b/test/javax/swing/JViewport/6953396/bug6953396.java @@ -0,0 +1,64 @@ +/* + * Copyright 2010 Sun Microsystems, Inc. All Rights Reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, + * CA 95054 USA or visit www.sun.com if you need additional information or + * have any questions. + */ + +/* @test + * @bug 6953396 + * @summary javax.swing.plaf.basic.BasicViewportUI.uninstallDefaults() is not called when UI is uninstalled + * @author Alexander Potochkin + */ + +import javax.swing.*; +import javax.swing.plaf.basic.BasicViewportUI; + +public class bug6953396 { + static volatile boolean flag; + + public static void main(String[] args) throws Exception { + SwingUtilities.invokeAndWait(new Runnable() { + @Override + public void run() { + BasicViewportUI ui = new BasicViewportUI() { + + @Override + protected void installDefaults(JComponent c) { + super.installDefaults(c); + flag = true; + } + + @Override + protected void uninstallDefaults(JComponent c) { + super.uninstallDefaults(c); + flag = false; + } + }; + + JViewport viewport = new JViewport(); + viewport.setUI(ui); + viewport.setUI(null); + } + }); + if (flag) { + throw new RuntimeException("uninstallDefaults() hasn't been called"); + } + } +} -- GitLab