diff --git a/make/netbeans/jconsole/build.properties b/make/netbeans/jconsole/build.properties
index ab2a0a1aef61ade7763efaf931802d760dcb3546..189b528ee30b4d1c21785eb8d03cc70a5948f450 100644
--- a/make/netbeans/jconsole/build.properties
+++ b/make/netbeans/jconsole/build.properties
@@ -44,3 +44,4 @@ build.jdk.version = 1.7.0
build.release = ${build.jdk.version}-opensource
build.number = b00
jconsole.version = ${build.release}-${user.name}-${build.number}
+jconsole.args = -debug
diff --git a/make/netbeans/jconsole/build.xml b/make/netbeans/jconsole/build.xml
index 0f51d1c3b5d2da1c0568cc30532387e95d32ba30..b546fb7de4c9c0c919937cbe008c42aa053f7f1a 100644
--- a/make/netbeans/jconsole/build.xml
+++ b/make/netbeans/jconsole/build.xml
@@ -30,9 +30,9 @@
-->
-
+
-
+
-
+
-
+
+
-
+
-
+
diff --git a/src/share/classes/sun/tools/jconsole/inspector/TableSorter.java b/src/share/classes/sun/tools/jconsole/inspector/TableSorter.java
index 52c6d15f58e2201bd047f57ece8927158f4779d7..79cec51e38f0ddcf74db39c5df4eb8ed8545e255 100644
--- a/src/share/classes/sun/tools/jconsole/inspector/TableSorter.java
+++ b/src/share/classes/sun/tools/jconsole/inspector/TableSorter.java
@@ -25,71 +25,78 @@
package sun.tools.jconsole.inspector;
-import java.util.*;
-import java.awt.event.*;
-import javax.swing.table.*;
-import javax.swing.event.*;
// Imports for picking up mouse events from the JTable.
-import java.awt.event.MouseAdapter;
import java.awt.event.MouseEvent;
-import java.awt.event.InputEvent;
+import java.awt.event.MouseListener;
+import java.util.Vector;
import javax.swing.JTable;
+import javax.swing.event.TableModelEvent;
+import javax.swing.event.TableModelListener;
+import javax.swing.table.DefaultTableModel;
import javax.swing.table.JTableHeader;
import javax.swing.table.TableColumnModel;
+import sun.tools.jconsole.JConsole;
@SuppressWarnings("serial")
public class TableSorter extends DefaultTableModel implements MouseListener {
private boolean ascending = true;
private TableColumnModel columnModel;
private JTable tableView;
- private Vector listenerList;
+ private Vector evtListenerList;
private int sortColumn = 0;
private int[] invertedIndex;
public TableSorter() {
super();
- listenerList = new Vector();
+ evtListenerList = new Vector();
}
public TableSorter(Object[] columnNames, int numRows) {
super(columnNames,numRows);
- listenerList = new Vector();
+ evtListenerList = new Vector();
}
+ @Override
public void newDataAvailable(TableModelEvent e) {
super.newDataAvailable(e);
invertedIndex = new int[getRowCount()];
- for (int i=0;i viewableAttributes;
private WeakHashMap> viewersCache =
new WeakHashMap>();
- private TableModelListener attributesListener;
+ private final TableModelListener attributesListener;
private MBeansTab mbeansTab;
- private XTable table;
private TableCellEditor valueCellEditor = new ValueCellEditor();
private int rowMinHeight = -1;
private AttributesMouseListener mouseListener = new AttributesMouseListener();
@@ -89,8 +108,8 @@ public class XMBeanAttributes extends XTable {
super();
this.mbeansTab = mbeansTab;
((DefaultTableModel)getModel()).setColumnIdentifiers(columnNames);
- getModel().addTableModelListener(attributesListener =
- new AttributesListener(this));
+ attributesListener = new AttributesListener(this);
+ getModel().addTableModelListener(attributesListener);
getColumnModel().getColumn(NAME_COLUMN).setPreferredWidth(40);
addMouseListener(mouseListener);
@@ -99,6 +118,7 @@ public class XMBeanAttributes extends XTable {
addKeyListener(new Utils.CopyKeyAdapter());
}
+ @Override
public synchronized Component prepareRenderer(TableCellRenderer renderer,
int row, int column) {
//In case we have a repaint thread that is in the process of
@@ -124,6 +144,7 @@ public class XMBeanAttributes extends XTable {
setRowHeight(row, rowMinHeight);
}
+ @Override
public synchronized TableCellRenderer getCellRenderer(int row,
int column) {
//In case we have a repaint thread that is in the process of
@@ -169,26 +190,40 @@ public class XMBeanAttributes extends XTable {
}
public void cancelCellEditing() {
- TableCellEditor editor = getCellEditor();
- if (editor != null) {
- editor.cancelCellEditing();
+ if (LOGGER.isLoggable(Level.FINER)) {
+ LOGGER.finer("Cancel Editing Row: "+getEditingRow());
+ }
+ final TableCellEditor tableCellEditor = getCellEditor();
+ if (tableCellEditor != null) {
+ tableCellEditor.cancelCellEditing();
}
}
public void stopCellEditing() {
- TableCellEditor editor = getCellEditor();
- if (editor != null) {
- editor.stopCellEditing();
+ if (LOGGER.isLoggable(Level.FINER)) {
+ LOGGER.finer("Stop Editing Row: "+getEditingRow());
+ }
+ final TableCellEditor tableCellEditor = getCellEditor();
+ if (tableCellEditor != null) {
+ tableCellEditor.stopCellEditing();
}
}
- public final boolean editCellAt(int row, int column, EventObject e) {
+ @Override
+ public final boolean editCellAt(final int row, final int column, EventObject e) {
+ if (LOGGER.isLoggable(Level.FINER)) {
+ LOGGER.finer("editCellAt(row="+row+", col="+column+
+ ", e="+e+")");
+ }
+ if (JConsole.isDebug()) {
+ System.err.println("edit: "+getValueName(row)+"="+getValue(row));
+ }
boolean retVal = super.editCellAt(row, column, e);
if (retVal) {
- TableCellEditor editor =
+ final TableCellEditor tableCellEditor =
getColumnModel().getColumn(column).getCellEditor();
- if (editor == valueCellEditor) {
- ((JComponent) editor).requestFocus();
+ if (tableCellEditor == valueCellEditor) {
+ ((JComponent) tableCellEditor).requestFocus();
}
}
return retVal;
@@ -213,6 +248,10 @@ public class XMBeanAttributes extends XTable {
public void setValueAt(Object value, int row, int column) {
if (!isCellError(row, column) && isColumnEditable(column) &&
isWritable(row) && Utils.isEditableType(getClassName(row))) {
+ if (JConsole.isDebug()) {
+ System.err.println("validating [row="+row+", column="+column+
+ "]: "+getValueName(row)+"="+value);
+ }
super.setValueAt(value, row, column);
}
}
@@ -256,12 +295,14 @@ public class XMBeanAttributes extends XTable {
}
}
-
public Object getValue(int row) {
- return ((DefaultTableModel) getModel()).getValueAt(row, VALUE_COLUMN);
+ final Object val = ((DefaultTableModel) getModel())
+ .getValueAt(row, VALUE_COLUMN);
+ return val;
}
//tool tip only for editable column
+ @Override
public String getToolTip(int row, int column) {
if (isCellError(row, column)) {
return (String) unavailableAttributes.get(getValueName(row));
@@ -302,6 +343,7 @@ public class XMBeanAttributes extends XTable {
* Override JTable method in order to make any call to this method
* atomic with TableModel elements.
*/
+ @Override
public synchronized int getRowCount() {
return super.getRowCount();
}
@@ -332,24 +374,67 @@ public class XMBeanAttributes extends XTable {
return isViewable;
}
- public void loadAttributes(final XMBean mbean, MBeanInfo mbeanInfo) {
+ // Call this in EDT
+ public void loadAttributes(final XMBean mbean, final MBeanInfo mbeanInfo) {
+
+ final SwingWorker load =
+ new SwingWorker() {
+ @Override
+ protected Runnable doInBackground() throws Exception {
+ return doLoadAttributes(mbean,mbeanInfo);
+ }
+
+ @Override
+ protected void done() {
+ try {
+ final Runnable updateUI = get();
+ if (updateUI != null) updateUI.run();
+ } catch (RuntimeException x) {
+ throw x;
+ } catch (ExecutionException x) {
+ if(JConsole.isDebug()) {
+ System.err.println(
+ "Exception raised while loading attributes: "
+ +x.getCause());
+ x.printStackTrace();
+ }
+ } catch (InterruptedException x) {
+ if(JConsole.isDebug()) {
+ System.err.println(
+ "Interrupted while loading attributes: "+x);
+ x.printStackTrace();
+ }
+ }
+ }
+
+ };
+ mbeansTab.workerAdd(load);
+ }
+
+ // Don't call this in EDT, but execute returned Runnable inside
+ // EDT - typically in the done() method of a SwingWorker
+ // This method can return null.
+ private Runnable doLoadAttributes(final XMBean mbean, MBeanInfo infoOrNull)
+ throws JMException, IOException {
// To avoid deadlock with events coming from the JMX side,
// we retrieve all JMX stuff in a non synchronized block.
- if(mbean == null) return;
-
- final MBeanAttributeInfo[] attributesInfo = mbeanInfo.getAttributes();
- final HashMap attributes =
- new HashMap(attributesInfo.length);
- final HashMap unavailableAttributes =
- new HashMap(attributesInfo.length);
- final HashMap viewableAttributes =
- new HashMap(attributesInfo.length);
+ if(mbean == null) return null;
+ final MBeanInfo curMBeanInfo =
+ (infoOrNull==null)?mbean.getMBeanInfo():infoOrNull;
+
+ final MBeanAttributeInfo[] attrsInfo = curMBeanInfo.getAttributes();
+ final HashMap attrs =
+ new HashMap(attrsInfo.length);
+ final HashMap unavailableAttrs =
+ new HashMap(attrsInfo.length);
+ final HashMap viewableAttrs =
+ new HashMap(attrsInfo.length);
AttributeList list = null;
try {
- list = mbean.getAttributes(attributesInfo);
- } catch (Exception e) {
+ list = mbean.getAttributes(attrsInfo);
+ }catch(Exception e) {
if (JConsole.isDebug()) {
System.err.println("Error calling getAttributes() on MBean \"" +
mbean.getObjectName() + "\". JConsole will " +
@@ -359,18 +444,18 @@ public class XMBeanAttributes extends XTable {
}
list = new AttributeList();
//Can't load all attributes, do it one after each other.
- for(int i = 0; i < attributesInfo.length; i++) {
+ for(int i = 0; i < attrsInfo.length; i++) {
String name = null;
try {
- name = attributesInfo[i].getName();
+ name = attrsInfo[i].getName();
Object value =
- mbean.getMBeanServerConnection().getAttribute(mbean.getObjectName(), name);
+ mbean.getMBeanServerConnection().
+ getAttribute(mbean.getObjectName(), name);
list.add(new Attribute(name, value));
}catch(Exception ex) {
- if(attributesInfo[i].isReadable()) {
- unavailableAttributes.put(name,
- Utils.getActualException(ex).
- toString());
+ if(attrsInfo[i].isReadable()) {
+ unavailableAttrs.put(name,
+ Utils.getActualException(ex).toString());
}
}
}
@@ -380,22 +465,22 @@ public class XMBeanAttributes extends XTable {
for (int i=0;i stopCellEditing -> setValueAt -> tableChanged
+ // -> refreshAttributes(false)
+ //
+ // Can be called in EDT - as long as the implementation of
+ // mbeansTab.getCachedMBeanServerConnection() and mbsc.flush() doesn't
+ // change
+ //
+ private void refreshAttributes(final boolean stopCellEditing) {
+ SwingWorker sw = new SwingWorker() {
+
+ @Override
+ protected Void doInBackground() throws Exception {
+ SnapshotMBeanServerConnection mbsc =
+ mbeansTab.getSnapshotMBeanServerConnection();
+ mbsc.flush();
+ return null;
+ }
+
+ @Override
+ protected void done() {
+ try {
+ get();
+ if (stopCellEditing) stopCellEditing();
+ loadAttributes(mbean, mbeanInfo);
+ } catch (Exception x) {
+ if (JConsole.isDebug()) {
+ x.printStackTrace();
+ }
+ }
+ }
+ };
+ mbeansTab.workerAdd(sw);
}
+ // We need to call stop editing here - otherwise edits are lost
+ // when resizing the table.
+ //
+ @Override
+ public void columnMarginChanged(ChangeEvent e) {
+ if (isEditing()) stopCellEditing();
+ super.columnMarginChanged(e);
+ }
+
+ // We need to call stop editing here - otherwise the edited value
+ // is transferred to the wrong row...
+ //
+ @Override
+ void sortRequested(int column) {
+ if (isEditing()) stopCellEditing();
+ super.sortRequested(column);
+ }
- public void emptyTable() {
- synchronized(this) {
- ((DefaultTableModel) getModel()).
- removeTableModelListener(attributesListener);
- super.emptyTable();
- }
+ @Override
+ public synchronized void emptyTable() {
+ emptyTable((DefaultTableModel)getModel());
}
+ // Call this in synchronized block.
+ private void emptyTable(DefaultTableModel model) {
+ model.removeTableModelListener(attributesListener);
+ super.emptyTable();
+ }
+
private boolean isViewable(Attribute attribute) {
Object data = attribute.getValue();
return XDataViewer.isViewableValue(data);
@@ -659,6 +795,7 @@ public class XMBeanAttributes extends XTable {
class AttributesMouseListener extends MouseAdapter {
+ @Override
public void mousePressed(MouseEvent e) {
if(e.getButton() == MouseEvent.BUTTON1) {
if(e.getClickCount() >= 2) {
@@ -674,8 +811,10 @@ public class XMBeanAttributes extends XTable {
}
}
+ @SuppressWarnings("serial")
class ValueCellEditor extends XTextFieldEditor {
// implements javax.swing.table.TableCellEditor
+ @Override
public Component getTableCellEditorComponent(JTable table,
Object value,
boolean isSelected,
@@ -727,6 +866,7 @@ public class XMBeanAttributes extends XTable {
}
}
+ @SuppressWarnings("serial")
class MaximizedCellRenderer extends DefaultTableCellRenderer {
Component comp;
MaximizedCellRenderer(Component comp) {
@@ -736,6 +876,7 @@ public class XMBeanAttributes extends XTable {
comp.setPreferredSize(new Dimension((int) d.getWidth(), 200));
}
}
+ @Override
public Component getTableCellRendererComponent(JTable table,
Object value,
boolean isSelected,
@@ -818,6 +959,7 @@ public class XMBeanAttributes extends XTable {
return minHeight;
}
+ @Override
public String toString() {
if(value == null) return null;
@@ -854,45 +996,82 @@ public class XMBeanAttributes extends XTable {
this.component = component;
}
+ // Call this in EDT
public void tableChanged(final TableModelEvent e) {
- final TableModel model = (TableModel)e.getSource();
// only post changes to the draggable column
if (isColumnEditable(e.getColumn())) {
- mbeansTab.workerAdd(new Runnable() {
- public void run() {
- try {
- Object tableValue =
- model.getValueAt(e.getFirstRow(),
- e.getColumn());
- // if it's a String, try construct new value
- // using the defined type.
- if (tableValue instanceof String) {
- tableValue =
- Utils.createObjectFromString(getClassName(e.getFirstRow()), // type
- (String)tableValue);// value
- }
- String attributeName =
- getValueName(e.getFirstRow());
- Attribute attribute =
- new Attribute(attributeName,tableValue);
- mbean.setAttribute(attribute);
- }
- catch (Throwable ex) {
- if (JConsole.isDebug()) {
- ex.printStackTrace();
- }
- ex = Utils.getActualException(ex);
-
- String message = (ex.getMessage() != null) ? ex.getMessage() : ex.toString();
- EventQueue.invokeLater(new ThreadDialog(component,
- message+"\n",
- Resources.getText("Problem setting attribute"),
- JOptionPane.ERROR_MESSAGE));
- }
- refreshAttributes();
- }
- });
+ final TableModel model = (TableModel)e.getSource();
+ Object tableValue = model.getValueAt(e.getFirstRow(),
+ e.getColumn());
+
+ if (LOGGER.isLoggable(Level.FINER)) {
+ LOGGER.finer("tableChanged: firstRow="+e.getFirstRow()+
+ ", lastRow="+e.getLastRow()+", column="+e.getColumn()+
+ ", value="+tableValue);
+ }
+ // if it's a String, try construct new value
+ // using the defined type.
+ if (tableValue instanceof String) {
+ try {
+ tableValue =
+ Utils.createObjectFromString(getClassName(e.getFirstRow()), // type
+ (String)tableValue);// value
+ } catch (Throwable ex) {
+ popupAndLog(ex,"tableChanged",
+ "Problem setting attribute");
+ }
+ }
+ final String attributeName = getValueName(e.getFirstRow());
+ final Attribute attribute =
+ new Attribute(attributeName,tableValue);
+ setAttribute(attribute, "tableChanged");
}
}
+
+ // Call this in EDT
+ private void setAttribute(final Attribute attribute, final String method) {
+ final SwingWorker setAttribute =
+ new SwingWorker() {
+ @Override
+ protected Void doInBackground() throws Exception {
+ try {
+ if (JConsole.isDebug()) {
+ System.err.println("setAttribute("+
+ attribute.getName()+
+ "="+attribute.getValue()+")");
+ }
+ mbean.setAttribute(attribute);
+ } catch (Throwable ex) {
+ popupAndLog(ex,method,"Problem setting attribute");
+ }
+ return null;
+ }
+ @Override
+ protected void done() {
+ try {
+ get();
+ } catch (Exception x) {
+ if (JConsole.isDebug())
+ x.printStackTrace();
+ }
+ refreshAttributes(false);
+ }
+
+ };
+ mbeansTab.workerAdd(setAttribute);
+ }
+
+ // Call this outside EDT
+ private void popupAndLog(Throwable ex, String method, String key) {
+ ex = Utils.getActualException(ex);
+ if (JConsole.isDebug()) ex.printStackTrace();
+
+ String message = (ex.getMessage() != null) ? ex.getMessage()
+ : ex.toString();
+ EventQueue.invokeLater(
+ new ThreadDialog(component, message+"\n",
+ Resources.getText(key),
+ JOptionPane.ERROR_MESSAGE));
+ }
}
}
diff --git a/src/share/classes/sun/tools/jconsole/inspector/XPlotter.java b/src/share/classes/sun/tools/jconsole/inspector/XPlotter.java
index a30dd08af46e49071fe594da88f3ecbdf2646eaa..24b4104b7c5f75dc29a91635507be157dbcf486e 100644
--- a/src/share/classes/sun/tools/jconsole/inspector/XPlotter.java
+++ b/src/share/classes/sun/tools/jconsole/inspector/XPlotter.java
@@ -37,6 +37,7 @@ public class XPlotter extends Plotter {
super(unit);
this.table = table;
}
+ @Override
public void addValues(long time, long... values) {
super.addValues(time, values);
table.repaint();
diff --git a/src/share/classes/sun/tools/jconsole/inspector/XSheet.java b/src/share/classes/sun/tools/jconsole/inspector/XSheet.java
index 1f2104a17d09df78c6ea3037c3fb3190687972bf..813ede1dabcfac78728b4eb327dc25ecedaafd28 100644
--- a/src/share/classes/sun/tools/jconsole/inspector/XSheet.java
+++ b/src/share/classes/sun/tools/jconsole/inspector/XSheet.java
@@ -25,18 +25,39 @@
package sun.tools.jconsole.inspector;
-import java.awt.*;
-import java.awt.event.*;
-import java.io.*;
-import javax.management.*;
-import javax.swing.*;
-import javax.swing.border.*;
-import javax.swing.tree.*;
+
+import java.awt.BorderLayout;
+import java.awt.Color;
+import java.awt.Component;
+import java.awt.Dimension;
+import java.awt.event.ActionEvent;
+import java.awt.event.ActionListener;
+import java.io.IOException;
+
+import javax.management.IntrospectionException;
+import javax.management.NotificationListener;
+import javax.management.MBeanInfo;
+import javax.management.InstanceNotFoundException;
+import javax.management.ReflectionException;
+import javax.management.MBeanAttributeInfo;
+import javax.management.MBeanOperationInfo;
+import javax.management.MBeanNotificationInfo;
+import javax.management.Notification;
+import javax.swing.BorderFactory;
+import javax.swing.JButton;
+import javax.swing.JOptionPane;
+import javax.swing.JPanel;
+import javax.swing.JScrollPane;
+import javax.swing.JTextArea;
+import javax.swing.SwingWorker;
+import javax.swing.border.LineBorder;
+import javax.swing.tree.DefaultMutableTreeNode;
+import javax.swing.tree.DefaultTreeModel;
+
import sun.tools.jconsole.*;
import sun.tools.jconsole.inspector.XNodeInfo.Type;
import static sun.tools.jconsole.Resources.*;
-import static sun.tools.jconsole.Utilities.*;
@SuppressWarnings("serial")
public class XSheet extends JPanel
@@ -344,34 +365,41 @@ public class XSheet extends JPanel
return;
}
mbean = (XMBean) uo.getData();
- SwingWorker sw = new SwingWorker() {
+ final XMBean xmb = mbean;
+ SwingWorker sw = new SwingWorker() {
@Override
- public Void doInBackground() throws InstanceNotFoundException,
+ public MBeanInfo doInBackground() throws InstanceNotFoundException,
IntrospectionException, ReflectionException, IOException {
- mbeanAttributes.loadAttributes(mbean, mbean.getMBeanInfo());
- return null;
+ MBeanInfo mbi = xmb.getMBeanInfo();
+ return mbi;
}
@Override
protected void done() {
try {
- get();
- if (!isSelectedNode(node, currentNode)) {
- return;
+ MBeanInfo mbi = get();
+ if (mbi != null && mbi.getAttributes() != null &&
+ mbi.getAttributes().length > 0) {
+
+ mbeanAttributes.loadAttributes(xmb, mbi);
+
+ if (!isSelectedNode(node, currentNode)) {
+ return;
+ }
+ invalidate();
+ mainPanel.removeAll();
+ JPanel borderPanel = new JPanel(new BorderLayout());
+ borderPanel.setBorder(BorderFactory.createTitledBorder(
+ Resources.getText("Attribute values")));
+ borderPanel.add(new JScrollPane(mbeanAttributes));
+ mainPanel.add(borderPanel, BorderLayout.CENTER);
+ // add the refresh button to the south panel
+ southPanel.removeAll();
+ southPanel.add(refreshButton, BorderLayout.SOUTH);
+ southPanel.setVisible(true);
+ refreshButton.setEnabled(true);
+ validate();
+ repaint();
}
- invalidate();
- mainPanel.removeAll();
- JPanel borderPanel = new JPanel(new BorderLayout());
- borderPanel.setBorder(BorderFactory.createTitledBorder(
- Resources.getText("Attribute values")));
- borderPanel.add(new JScrollPane(mbeanAttributes));
- mainPanel.add(borderPanel, BorderLayout.CENTER);
- // add the refresh button to the south panel
- southPanel.removeAll();
- southPanel.add(refreshButton, BorderLayout.SOUTH);
- southPanel.setVisible(true);
- refreshButton.setEnabled(true);
- validate();
- repaint();
} catch (Exception e) {
Throwable t = Utils.getActualException(e);
if (JConsole.isDebug()) {
@@ -704,13 +732,7 @@ public class XSheet extends JPanel
JButton button = (JButton) e.getSource();
// Refresh button
if (button == refreshButton) {
- new SwingWorker() {
- @Override
- public Void doInBackground() {
- refreshAttributes();
- return null;
- }
- }.execute();
+ refreshAttributes();
return;
}
// Clear button
diff --git a/src/share/classes/sun/tools/jconsole/inspector/XTable.java b/src/share/classes/sun/tools/jconsole/inspector/XTable.java
index 7a3cca2600fbca8809622c3d4776b3adf511e696..133112fb8bf78e79c3e88afe3e3e189c4b0c90ff 100644
--- a/src/share/classes/sun/tools/jconsole/inspector/XTable.java
+++ b/src/share/classes/sun/tools/jconsole/inspector/XTable.java
@@ -25,10 +25,13 @@
package sun.tools.jconsole.inspector;
-import javax.swing.*;
-import javax.swing.table.*;
-import java.awt.*;
-import java.io.*;
+import java.awt.Color;
+import java.awt.Component;
+import java.awt.Font;
+import javax.swing.JTable;
+import javax.swing.table.DefaultTableCellRenderer;
+import javax.swing.table.DefaultTableModel;
+import javax.swing.table.TableCellRenderer;
public abstract class XTable extends JTable {
static final int NAME_COLUMN = 0;
@@ -38,8 +41,9 @@ public abstract class XTable extends JTable {
public XTable () {
super();
- TableSorter sorter;
- setModel(sorter = new TableSorter());
+ @SuppressWarnings("serial")
+ final TableSorter sorter = new TableSorter();
+ setModel(sorter);
sorter.addMouseListenerToHeaderInTable(this);
setRowSelectionAllowed(false);
setColumnSelectionAllowed(false);
@@ -54,6 +58,14 @@ public abstract class XTable extends JTable {
return editableColor;
}
+ /**
+ * Called by TableSorter if a mouse event requests to sort the rows.
+ * @param column the column against which the rows are sorted
+ */
+ void sortRequested(int column) {
+ // This is a hook for subclasses
+ }
+
/**
* This returns the select index as the table was at initialization
*/
@@ -67,7 +79,7 @@ public abstract class XTable extends JTable {
public int convertRowToIndex(int row) {
if (row == -1) return row;
if (getModel() instanceof TableSorter) {
- return (((TableSorter) getModel()).getInvertedIndex()[row]);
+ return ((TableSorter) getModel()).getIndexOfRow(row);
} else {
return row;
}
@@ -97,6 +109,7 @@ public abstract class XTable extends JTable {
//JTable re-implementation
//attribute can be editable even if unavailable
+ @Override
public boolean isCellEditable(int row, int col) {
return ((isTableEditable() && isColumnEditable(col)
&& isWritable(row)
@@ -118,6 +131,7 @@ public abstract class XTable extends JTable {
* This method sets read write rows to be blue, and other rows to be their
* default rendered colour.
*/
+ @Override
public TableCellRenderer getCellRenderer(int row, int column) {
DefaultTableCellRenderer tcr =
(DefaultTableCellRenderer) super.getCellRenderer(row,column);
@@ -146,6 +160,7 @@ public abstract class XTable extends JTable {
return tcr;
}
+ @Override
public Component prepareRenderer(TableCellRenderer renderer,
int row, int column) {
Component comp = super.prepareRenderer(renderer, row, column);
diff --git a/src/share/classes/sun/tools/jconsole/inspector/XTextFieldEditor.java b/src/share/classes/sun/tools/jconsole/inspector/XTextFieldEditor.java
index 31743aaa429c1635184472f5200978428f232cd4..6adf00e3bc67038879bc301f8274c2d37be0e0ce 100644
--- a/src/share/classes/sun/tools/jconsole/inspector/XTextFieldEditor.java
+++ b/src/share/classes/sun/tools/jconsole/inspector/XTextFieldEditor.java
@@ -26,22 +26,30 @@
package sun.tools.jconsole.inspector;
import java.awt.Component;
+import java.awt.event.ActionEvent;
+import java.awt.event.FocusAdapter;
+import java.awt.event.FocusEvent;
+import java.awt.event.FocusListener;
import java.util.EventObject;
-import java.awt.event.*;
-import java.awt.dnd.DragSourceDropEvent;
-import javax.swing.*;
-import javax.swing.event.*;
-import javax.swing.table.*;
+import javax.swing.JMenuItem;
+import javax.swing.JTable;
+import javax.swing.JTextField;
+import javax.swing.event.CellEditorListener;
+import javax.swing.event.ChangeEvent;
+import javax.swing.event.EventListenerList;
+import javax.swing.table.TableCellEditor;
@SuppressWarnings("serial")
public class XTextFieldEditor extends XTextField implements TableCellEditor {
- protected EventListenerList listenerList = new EventListenerList();
+ protected EventListenerList evtListenerList = new EventListenerList();
protected ChangeEvent changeEvent = new ChangeEvent(this);
private FocusListener editorFocusListener = new FocusAdapter() {
+ @Override
public void focusLost(FocusEvent e) {
- fireEditingStopped();
+ // fireEditingStopped();
+ // must not call fireEditingStopped() here!
}
};
@@ -51,6 +59,7 @@ public class XTextFieldEditor extends XTextField implements TableCellEditor {
}
//edition stopped ou JMenuItem selection & JTextField selection
+ @Override
public void actionPerformed(ActionEvent e) {
super.actionPerformed(e);
if ((e.getSource() instanceof JMenuItem) ||
@@ -67,16 +76,16 @@ public class XTextFieldEditor extends XTextField implements TableCellEditor {
//TableCellEditor implementation
public void addCellEditorListener(CellEditorListener listener) {
- listenerList.add(CellEditorListener.class,listener);
+ evtListenerList.add(CellEditorListener.class,listener);
}
public void removeCellEditorListener(CellEditorListener listener) {
- listenerList.remove(CellEditorListener.class, listener);
+ evtListenerList.remove(CellEditorListener.class, listener);
}
protected void fireEditingStopped() {
CellEditorListener listener;
- Object[] listeners = listenerList.getListenerList();
+ Object[] listeners = evtListenerList.getListenerList();
for (int i=0;i< listeners.length;i++) {
if (listeners[i] == CellEditorListener.class) {
listener = (CellEditorListener) listeners[i+1];
@@ -87,7 +96,7 @@ public class XTextFieldEditor extends XTextField implements TableCellEditor {
protected void fireEditingCanceled() {
CellEditorListener listener;
- Object[] listeners = listenerList.getListenerList();
+ Object[] listeners = evtListenerList.getListenerList();
for (int i=0;i< listeners.length;i++) {
if (listeners[i] == CellEditorListener.class) {
listener = (CellEditorListener) listeners[i+1];