diff --git a/src/share/classes/java/io/PrintStream.java b/src/share/classes/java/io/PrintStream.java index 9ed3ff6f910d1fc64fca37b39cc0de2368b68920..f29b5407abf18a2773a48fe345165bd43d8b94da 100644 --- a/src/share/classes/java/io/PrintStream.java +++ b/src/share/classes/java/io/PrintStream.java @@ -70,11 +70,11 @@ public class PrintStream extends FilterOutputStream private OutputStreamWriter charOut; /** - * nonNull is explicitly declared here so as not to create an extra - * dependency on java.util.Objects.nonNull. PrintStream is loaded + * requireNonNull is explicitly declared here so as not to create an extra + * dependency on java.util.Objects.requireNonNull. PrintStream is loaded * early during system initialization. */ - private static T nonNull(T obj, String message) { + private static T requireNonNull(T obj, String message) { if (obj == null) throw new NullPointerException(message); return obj; @@ -88,7 +88,7 @@ public class PrintStream extends FilterOutputStream private static Charset toCharset(String csn) throws UnsupportedEncodingException { - nonNull(csn, "charsetName"); + requireNonNull(csn, "charsetName"); try { return Charset.forName(csn); } catch (IllegalCharsetNameException|UnsupportedCharsetException unused) { @@ -148,7 +148,7 @@ public class PrintStream extends FilterOutputStream * @see java.io.PrintWriter#PrintWriter(java.io.OutputStream, boolean) */ public PrintStream(OutputStream out, boolean autoFlush) { - this(autoFlush, nonNull(out, "Null output stream")); + this(autoFlush, requireNonNull(out, "Null output stream")); } /** @@ -173,7 +173,7 @@ public class PrintStream extends FilterOutputStream throws UnsupportedEncodingException { this(autoFlush, - nonNull(out, "Null output stream"), + requireNonNull(out, "Null output stream"), toCharset(encoding)); } diff --git a/src/share/classes/java/io/PrintWriter.java b/src/share/classes/java/io/PrintWriter.java index 16044567065b4433e3e245ce572e9dd169bfc10f..0e9ea8f5688bd1febcd636eb4e1323dfa43f5e85 100644 --- a/src/share/classes/java/io/PrintWriter.java +++ b/src/share/classes/java/io/PrintWriter.java @@ -82,7 +82,7 @@ public class PrintWriter extends Writer { private static Charset toCharset(String csn) throws UnsupportedEncodingException { - Objects.nonNull(csn, "charsetName"); + Objects.requireNonNull(csn, "charsetName"); try { return Charset.forName(csn); } catch (IllegalCharsetNameException|UnsupportedCharsetException unused) { diff --git a/src/share/classes/java/lang/StackTraceElement.java b/src/share/classes/java/lang/StackTraceElement.java index b95587d71850fff19924f59799e25a89ac8351a1..3bd8ed433c000454473534d16eb33c5e19705189 100644 --- a/src/share/classes/java/lang/StackTraceElement.java +++ b/src/share/classes/java/lang/StackTraceElement.java @@ -68,8 +68,8 @@ public final class StackTraceElement implements java.io.Serializable { */ public StackTraceElement(String declaringClass, String methodName, String fileName, int lineNumber) { - this.declaringClass = Objects.nonNull(declaringClass, "Declaring class is null"); - this.methodName = Objects.nonNull(methodName, "Method name is null"); + this.declaringClass = Objects.requireNonNull(declaringClass, "Declaring class is null"); + this.methodName = Objects.requireNonNull(methodName, "Method name is null"); this.fileName = fileName; this.lineNumber = lineNumber; } diff --git a/src/share/classes/java/nio/file/DirectoryIteratorException.java b/src/share/classes/java/nio/file/DirectoryIteratorException.java index 729c84a77cda1ad973c34bdff4495135055a66b6..a74369c5a221a36bc460eaea44ee75d0c649496d 100644 --- a/src/share/classes/java/nio/file/DirectoryIteratorException.java +++ b/src/share/classes/java/nio/file/DirectoryIteratorException.java @@ -56,7 +56,7 @@ public final class DirectoryIteratorException * if the cause is {@code null} */ public DirectoryIteratorException(IOException cause) { - super(Objects.nonNull(cause)); + super(Objects.requireNonNull(cause)); } /** diff --git a/src/share/classes/java/nio/file/FileTreeWalker.java b/src/share/classes/java/nio/file/FileTreeWalker.java index fb3995315ccb853ba1cb0e58fbedd748e5540c3e..4c0896f70c161b6ec5c85019597f2aa1f4d1d7a5 100644 --- a/src/share/classes/java/nio/file/FileTreeWalker.java +++ b/src/share/classes/java/nio/file/FileTreeWalker.java @@ -69,8 +69,7 @@ class FileTreeWalker { FileVisitResult result = walk(start, 0, new ArrayList()); - if (result == null) - throw new NullPointerException("FileVisitor returned null"); + Objects.requireNonNull(result, "FileVisitor returned null"); } /** diff --git a/src/share/classes/java/nio/file/Files.java b/src/share/classes/java/nio/file/Files.java index cb1fde29685aaa99bebbc33cbb7c82b4212af558..357529ac9cf065deaa7301b2d11a167702874537 100644 --- a/src/share/classes/java/nio/file/Files.java +++ b/src/share/classes/java/nio/file/Files.java @@ -2779,7 +2779,7 @@ public final class Files { throws IOException { // ensure not null before opening file - Objects.nonNull(in); + Objects.requireNonNull(in); // check for REPLACE_EXISTING boolean replaceExisting = false; @@ -2861,7 +2861,7 @@ public final class Files { */ public static long copy(Path source, OutputStream out) throws IOException { // ensure not null before opening file - Objects.nonNull(out); + Objects.requireNonNull(out); try (InputStream in = newInputStream(source)) { return copy(in, out); @@ -3035,7 +3035,7 @@ public final class Files { throws IOException { // ensure bytes is not null before opening file - Objects.nonNull(bytes); + Objects.requireNonNull(bytes); try (OutputStream out = Files.newOutputStream(path, options)) { int len = bytes.length; @@ -3094,7 +3094,7 @@ public final class Files { throws IOException { // ensure lines is not null before opening file - Objects.nonNull(lines); + Objects.requireNonNull(lines); CharsetEncoder encoder = cs.newEncoder(); OutputStream out = newOutputStream(path, options); try (BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(out, encoder))) { diff --git a/src/share/classes/java/nio/file/SimpleFileVisitor.java b/src/share/classes/java/nio/file/SimpleFileVisitor.java index 5b0a4602b4e992c6318c255630973552b36d73c2..8bedbd4c9b3146c8fecd3ec8b1b24b82c61bed5e 100644 --- a/src/share/classes/java/nio/file/SimpleFileVisitor.java +++ b/src/share/classes/java/nio/file/SimpleFileVisitor.java @@ -57,8 +57,8 @@ public class SimpleFileVisitor implements FileVisitor { public FileVisitResult preVisitDirectory(T dir, BasicFileAttributes attrs) throws IOException { - Objects.nonNull(dir); - Objects.nonNull(attrs); + Objects.requireNonNull(dir); + Objects.requireNonNull(attrs); return FileVisitResult.CONTINUE; } @@ -72,8 +72,8 @@ public class SimpleFileVisitor implements FileVisitor { public FileVisitResult visitFile(T file, BasicFileAttributes attrs) throws IOException { - Objects.nonNull(file); - Objects.nonNull(attrs); + Objects.requireNonNull(file); + Objects.requireNonNull(attrs); return FileVisitResult.CONTINUE; } @@ -87,7 +87,7 @@ public class SimpleFileVisitor implements FileVisitor { public FileVisitResult visitFileFailed(T file, IOException exc) throws IOException { - Objects.nonNull(file); + Objects.requireNonNull(file); throw exc; } @@ -104,7 +104,7 @@ public class SimpleFileVisitor implements FileVisitor { public FileVisitResult postVisitDirectory(T dir, IOException exc) throws IOException { - Objects.nonNull(dir); + Objects.requireNonNull(dir); if (exc != null) throw exc; return FileVisitResult.CONTINUE; diff --git a/src/share/classes/java/util/Formatter.java b/src/share/classes/java/util/Formatter.java index 6c9ead3b7f03ef29cfbf3a0bcb32a1bd5e8bd4da..797b9e2f8aaf3cea5e3d85b33ddad437a21bc131 100644 --- a/src/share/classes/java/util/Formatter.java +++ b/src/share/classes/java/util/Formatter.java @@ -47,9 +47,6 @@ import java.text.DateFormatSymbols; import java.text.DecimalFormat; import java.text.DecimalFormatSymbols; import java.text.NumberFormat; -import java.util.Calendar; -import java.util.Date; -import java.util.Locale; import java.util.regex.Matcher; import java.util.regex.Pattern; @@ -1859,7 +1856,7 @@ public final class Formatter implements Closeable, Flushable { private static Charset toCharset(String csn) throws UnsupportedEncodingException { - Objects.nonNull(csn, "charsetName"); + Objects.requireNonNull(csn, "charsetName"); try { return Charset.forName(csn); } catch (IllegalCharsetNameException|UnsupportedCharsetException unused) { @@ -2179,7 +2176,7 @@ public final class Formatter implements Closeable, Flushable { */ public Formatter(PrintStream ps) { this(Locale.getDefault(Locale.Category.FORMAT), - (Appendable)Objects.nonNull(ps)); + (Appendable)Objects.requireNonNull(ps)); } /** diff --git a/src/share/classes/java/util/Objects.java b/src/share/classes/java/util/Objects.java index e6212235f45a81748f6c732c0a4796fc1a948bfc..e3d5ad415f2207b5fa489daea4bbdec40a654167 100644 --- a/src/share/classes/java/util/Objects.java +++ b/src/share/classes/java/util/Objects.java @@ -187,7 +187,7 @@ public final class Objects { * and constructors, as demonstrated below: *
      * public Foo(Bar bar) {
-     *     this.bar = Objects.nonNull(bar);
+     *     this.bar = Objects.requireNonNull(bar);
      * }
      * 
* @@ -196,7 +196,7 @@ public final class Objects { * @return {@code obj} if not {@code null} * @throws NullPointerException if {@code obj} is {@code null} */ - public static T nonNull(T obj) { + public static T requireNonNull(T obj) { if (obj == null) throw new NullPointerException(); return obj; @@ -209,8 +209,8 @@ public final class Objects { * constructors with multiple parameters, as demonstrated below: *
      * public Foo(Bar bar, Baz baz) {
-     *     this.bar = Objects.nonNull(bar, "bar must not be null");
-     *     this.baz = Objects.nonNull(baz, "baz must not be null");
+     *     this.bar = Objects.requireNonNull(bar, "bar must not be null");
+     *     this.baz = Objects.requireNonNull(baz, "baz must not be null");
      * }
      * 
* @@ -221,7 +221,7 @@ public final class Objects { * @return {@code obj} if not {@code null} * @throws NullPointerException if {@code obj} is {@code null} */ - public static T nonNull(T obj, String message) { + public static T requireNonNull(T obj, String message) { if (obj == null) throw new NullPointerException(message); return obj; diff --git a/src/share/classes/java/util/Scanner.java b/src/share/classes/java/util/Scanner.java index 4aa5c9fb8c58c35d7498ec446be6bc805bbb9b2d..e80b27a393b99bad82649d2adc4896d7cde66a79 100644 --- a/src/share/classes/java/util/Scanner.java +++ b/src/share/classes/java/util/Scanner.java @@ -35,6 +35,7 @@ import java.nio.channels.*; import java.nio.charset.*; import java.text.*; import java.util.Locale; + import sun.misc.LRUCache; /** @@ -592,7 +593,7 @@ public final class Scanner implements Iterator, Closeable { * interface */ public Scanner(Readable source) { - this(Objects.nonNull(source, "source"), WHITESPACE_PATTERN); + this(Objects.requireNonNull(source, "source"), WHITESPACE_PATTERN); } /** @@ -619,7 +620,7 @@ public final class Scanner implements Iterator, Closeable { * does not exist */ public Scanner(InputStream source, String charsetName) { - this(makeReadable(Objects.nonNull(source, "source"), toCharset(charsetName)), + this(makeReadable(Objects.requireNonNull(source, "source"), toCharset(charsetName)), WHITESPACE_PATTERN); } @@ -629,7 +630,7 @@ public final class Scanner implements Iterator, Closeable { * @throws IllegalArgumentException if the charset is not supported */ private static Charset toCharset(String csn) { - Objects.nonNull(csn, "charsetName"); + Objects.requireNonNull(csn, "charsetName"); try { return Charset.forName(csn); } catch (IllegalCharsetNameException|UnsupportedCharsetException e) { @@ -670,7 +671,7 @@ public final class Scanner implements Iterator, Closeable { public Scanner(File source, String charsetName) throws FileNotFoundException { - this(Objects.nonNull(source), toDecoder(charsetName)); + this(Objects.requireNonNull(source), toDecoder(charsetName)); } private Scanner(File source, CharsetDecoder dec) @@ -680,7 +681,7 @@ public final class Scanner implements Iterator, Closeable { } private static CharsetDecoder toDecoder(String charsetName) { - Objects.nonNull(charsetName, "charsetName"); + Objects.requireNonNull(charsetName, "charsetName"); try { return Charset.forName(charsetName).newDecoder(); } catch (IllegalCharsetNameException|UnsupportedCharsetException unused) { @@ -729,7 +730,7 @@ public final class Scanner implements Iterator, Closeable { * @since 1.7 */ public Scanner(Path source, String charsetName) throws IOException { - this(Objects.nonNull(source), toCharset(charsetName)); + this(Objects.requireNonNull(source), toCharset(charsetName)); } private Scanner(Path source, Charset charset) throws IOException { @@ -755,7 +756,7 @@ public final class Scanner implements Iterator, Closeable { * @param source A channel to scan */ public Scanner(ReadableByteChannel source) { - this(makeReadable(Objects.nonNull(source, "source")), + this(makeReadable(Objects.requireNonNull(source, "source")), WHITESPACE_PATTERN); } @@ -775,7 +776,7 @@ public final class Scanner implements Iterator, Closeable { * does not exist */ public Scanner(ReadableByteChannel source, String charsetName) { - this(makeReadable(Objects.nonNull(source, "source"), toDecoder(charsetName)), + this(makeReadable(Objects.requireNonNull(source, "source"), toDecoder(charsetName)), WHITESPACE_PATTERN); } diff --git a/src/share/classes/sun/security/krb5/KrbAsRep.java b/src/share/classes/sun/security/krb5/KrbAsRep.java index c05d8bd08bfbde4cf9d2b3caaadbf3519fc8af9b..140d5981b5eb9edb9b9f82ea6f636d5de7a8c687 100644 --- a/src/share/classes/sun/security/krb5/KrbAsRep.java +++ b/src/share/classes/sun/security/krb5/KrbAsRep.java @@ -173,7 +173,7 @@ class KrbAsRep extends KrbKdcRep { } Credentials getCreds() { - return Objects.nonNull(creds, "Creds not available yet."); + return Objects.requireNonNull(creds, "Creds not available yet."); } sun.security.krb5.internal.ccache.Credentials getCCreds() { diff --git a/test/java/util/Objects/BasicObjectsTest.java b/test/java/util/Objects/BasicObjectsTest.java index 7584d2cffc267678bda7022043fdf845b226beda..bf025a8ad2c7f07a62820513fbd2f829774a5882 100644 --- a/test/java/util/Objects/BasicObjectsTest.java +++ b/test/java/util/Objects/BasicObjectsTest.java @@ -164,7 +164,7 @@ public class BasicObjectsTest { // Test 1-arg variant try { - s = Objects.nonNull("pants"); + s = Objects.requireNonNull("pants"); if (s != "pants") { System.err.printf("1-arg non-null failed to return its arg"); errors++; @@ -175,7 +175,7 @@ public class BasicObjectsTest { } try { - s = Objects.nonNull(null); + s = Objects.requireNonNull(null); System.err.printf("1-arg nonNull failed to throw NPE"); errors++; } catch (NullPointerException e) { @@ -184,7 +184,7 @@ public class BasicObjectsTest { // Test 2-arg variant try { - s = Objects.nonNull("pants", "trousers"); + s = Objects.requireNonNull("pants", "trousers"); if (s != "pants") { System.err.printf("2-arg nonNull failed to return its arg"); errors++; @@ -195,7 +195,7 @@ public class BasicObjectsTest { } try { - s = Objects.nonNull(null, "pantaloons"); + s = Objects.requireNonNull(null, "pantaloons"); System.err.printf("2-arg nonNull failed to throw NPE"); errors++; } catch (NullPointerException e) {