From 2dee66712e36a8b4ea791c28d7b1adaf40f0d78c Mon Sep 17 00:00:00 2001 From: mchung Date: Tue, 26 May 2009 17:47:57 -0700 Subject: [PATCH] 6829636: test/java/util/logging/LoggingDeadlock2.java is flaky Summary: remove @ignore Reviewed-by: swamyv --- src/share/classes/java/net/URLConnection.java | 7 ++++--- test/Makefile | 19 +++++++++++++++++++ test/java/util/logging/LoggingDeadlock2.java | 1 - 3 files changed, 23 insertions(+), 4 deletions(-) diff --git a/src/share/classes/java/net/URLConnection.java b/src/share/classes/java/net/URLConnection.java index f0fa3e31e..87eeb24f5 100644 --- a/src/share/classes/java/net/URLConnection.java +++ b/src/share/classes/java/net/URLConnection.java @@ -1237,7 +1237,6 @@ public abstract class URLConnection { } private static Hashtable handlers = new Hashtable(); - private static final ContentHandler UnknownContentHandlerP = new UnknownContentHandler(); /** * Gets the Content Handler appropriate for this connection. @@ -1264,7 +1263,7 @@ public abstract class URLConnection { handler = lookupContentHandlerClassFor(contentType); } catch(Exception e) { e.printStackTrace(); - handler = UnknownContentHandlerP; + handler = UnknownContentHandler.INSTANCE; } handlers.put(contentType, handler); } @@ -1335,7 +1334,7 @@ public abstract class URLConnection { } } - return UnknownContentHandlerP; + return UnknownContentHandler.INSTANCE; } /** @@ -1761,6 +1760,8 @@ public abstract class URLConnection { class UnknownContentHandler extends ContentHandler { + static final ContentHandler INSTANCE = new UnknownContentHandler(); + public Object getContent(URLConnection uc) throws IOException { return uc.getInputStream(); } diff --git a/test/Makefile b/test/Makefile index 775e7cbc9..046ca593f 100644 --- a/test/Makefile +++ b/test/Makefile @@ -228,6 +228,25 @@ PHONY_LIST += packtest packtest_stress ################################################################ +# perftest to collect statistics + +# Expect JPRT to set JPRT_PACKTEST_HOME. +PERFTEST_HOME = ${TEST_ROOT}/perf +ifdef JPRT_PERFTEST_HOME + PERFTEST_HOME = $(JPRT_PERFTEST_HOME) +endif + +perftest: ( $(PERFTEST_HOME)/perftest \ + -t $(shell $(GETMIXEDPATH) "$(PRODUCT_HOME)") \ + -w $(shell $(GETMIXEDPATH) "$(ABS_TEST_OUTPUT_DIR)") \ + -h $(PERFTEST_HOME) \ + ) ; $(BUNDLE_UP_AND_EXIT) + + +PHONY_LIST += perftest + +################################################################ + # vmsqe tests # Expect JPRT to set JPRT_VMSQE_HOME. diff --git a/test/java/util/logging/LoggingDeadlock2.java b/test/java/util/logging/LoggingDeadlock2.java index cf8d67f99..31bccfa5c 100644 --- a/test/java/util/logging/LoggingDeadlock2.java +++ b/test/java/util/logging/LoggingDeadlock2.java @@ -24,7 +24,6 @@ /* * @test * @bug 6467152 6716076 6829503 - * @ignore Until made more stable, see 6829636. * @summary deadlock occurs in LogManager initialization and JVM termination * @author Serguei Spitsyn / Hitachi / Martin Buchholz * -- GitLab