From 1dd5e2376cc0671b71f2540db7f57b8745d1b2e8 Mon Sep 17 00:00:00 2001 From: bagiras Date: Thu, 13 Feb 2014 22:00:42 +0400 Subject: [PATCH] 8031694: [macosx] TwentyThousandTest test intermittently hangs Reviewed-by: art, anthony --- src/share/classes/java/awt/EventQueue.java | 9 +- .../EDTShutdownTest/EDTShutdownTest.java | 100 ++++++++++++++++++ 2 files changed, 108 insertions(+), 1 deletion(-) create mode 100644 test/java/awt/EventDispatchThread/EDTShutdownTest/EDTShutdownTest.java diff --git a/src/share/classes/java/awt/EventQueue.java b/src/share/classes/java/awt/EventQueue.java index efe0421f7..9e2c55a55 100644 --- a/src/share/classes/java/awt/EventQueue.java +++ b/src/share/classes/java/awt/EventQueue.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1996, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1996, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -1093,6 +1093,13 @@ public class EventQueue { dispatchThread = null; } AWTAutoShutdown.getInstance().notifyThreadFree(edt); + /* + * Event was posted after EDT events pumping had stopped, so start + * another EDT to handle this event + */ + if (peekEvent() != null) { + initDispatchThread(); + } } finally { pushPopLock.unlock(); } diff --git a/test/java/awt/EventDispatchThread/EDTShutdownTest/EDTShutdownTest.java b/test/java/awt/EventDispatchThread/EDTShutdownTest/EDTShutdownTest.java new file mode 100644 index 000000000..7a671b7b6 --- /dev/null +++ b/test/java/awt/EventDispatchThread/EDTShutdownTest/EDTShutdownTest.java @@ -0,0 +1,100 @@ +/* + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + @test + @bug 8031694 + @summary [macosx] TwentyThousandTest test intermittently hangs + @author Oleg Pekhovskiy + @run main EDTShutdownTest + */ + +import java.awt.EventQueue; +import java.awt.Toolkit; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import sun.awt.AWTAccessor; + +public class EDTShutdownTest { + + private static boolean passed = false; + + public static void main(String[] args) { + // Force EDT start with InvocationEvent + EventQueue.invokeLater(() -> { + // EventQueue is empty now + EventQueue queue = Toolkit.getDefaultToolkit() + .getSystemEventQueue(); + Thread thread = AWTAccessor.getEventQueueAccessor() + .getDispatchThread(queue); + try { + /* + * Clear EventDispatchThread.doDispatch flag to break message + * loop in EventDispatchThread.pumpEventsForFilter() + */ + Method stopDispatching = thread.getClass() + .getDeclaredMethod("stopDispatching", null); + stopDispatching.setAccessible(true); + stopDispatching.invoke(thread, null); + + /* + * Post another InvocationEvent that must be handled by another + * instance of EDT + */ + EventQueue.invokeLater(() -> { + passed = true; + }); + } + catch (InvocationTargetException | NoSuchMethodException + | IllegalAccessException e) { + } + }); + + // Wait for EDT shutdown + EventQueue queue = Toolkit.getDefaultToolkit().getSystemEventQueue(); + Thread thread = AWTAccessor.getEventQueueAccessor() + .getDispatchThread(queue); + try { + thread.join(); + + /* + * Wait for another EDT instance to handle the InvocationEvent + * and shutdown + */ + thread = AWTAccessor.getEventQueueAccessor() + .getDispatchThread(queue); + if (thread != null) { + thread.join(); + } + } + catch (InterruptedException e) { + } + + if (passed) { + System.out.println("Test PASSED!"); + } + else { + throw new RuntimeException("Test FAILED!"); + } + } +} -- GitLab