diff --git a/src/share/classes/javax/swing/plaf/basic/BasicScrollPaneUI.java b/src/share/classes/javax/swing/plaf/basic/BasicScrollPaneUI.java index 410491b99137a4feb9d7ba55864f37fa72b5be2c..44a512d58362312ec78cef2fecc47328bb7a9e1b 100644 --- a/src/share/classes/javax/swing/plaf/basic/BasicScrollPaneUI.java +++ b/src/share/classes/javax/swing/plaf/basic/BasicScrollPaneUI.java @@ -362,6 +362,14 @@ public class BasicScrollPaneUI * @since 1.6 */ public int getBaseline(JComponent c, int width, int height) { + if (c == null) { + throw new NullPointerException("Component must be non-null"); + } + + if (width < 0 || height < 0) { + throw new IllegalArgumentException("Width and height must be >= 0"); + } + JViewport viewport = scrollpane.getViewport(); Insets spInsets = scrollpane.getInsets(); int y = spInsets.top; diff --git a/test/javax/swing/plaf/basic/BasicScrollPaneUI/Test6632810.java b/test/javax/swing/plaf/basic/BasicScrollPaneUI/Test6632810.java new file mode 100644 index 0000000000000000000000000000000000000000..086b34d3759e1abc11c313da254affc6fc487f1f --- /dev/null +++ b/test/javax/swing/plaf/basic/BasicScrollPaneUI/Test6632810.java @@ -0,0 +1,72 @@ +/* + * Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 6632810 + * @summary javax.swing.plaf.basic.BasicScrollPaneUI.getBaseline(JComponent, int, int) doesn't throw NPE and IAE + * @author Pavel Porvatov + */ + +import javax.swing.*; +import javax.swing.plaf.basic.BasicScrollPaneUI; + +public class Test6632810 { + public static void main(String[] args) { + SwingUtilities.invokeLater(new Runnable() { + public void run() { + BasicScrollPaneUI ui = new BasicScrollPaneUI(); + + ui.installUI(new JScrollPane()); + + try { + ui.getBaseline(null, 1, 1); + + throw new RuntimeException("getBaseline(null, 1, 1) does not throw NPE"); + } catch (NullPointerException e) { + // Ok + } + + int[][] illegelParams = new int[][]{ + {-1, 1,}, + {1, -1,}, + {-1, -1,}, + }; + + for (int[] illegelParam : illegelParams) { + try { + int width = illegelParam[0]; + int height = illegelParam[1]; + + ui.getBaseline(new JScrollPane(), width, height); + + throw new RuntimeException("getBaseline(new JScrollPane(), " + width + ", " + height + + ") does not throw IAE"); + } catch (IllegalArgumentException e) { + // Ok + } + } + } + }); + } +}