From c9133a5ea52d738e2b2737e3d7b40e77c12cd9b5 Mon Sep 17 00:00:00 2001
From: coleenp <unknown>
Date: Tue, 2 Mar 2010 12:09:40 -0800
Subject: [PATCH] 6914050: jvm assertion "guard pages must be in use" in -Xcomp
 mode Summary: Move creating stack guard pages in jni attach thread before
 potential java call rather than after. Also cleanup stack guard pages when
 jni attach fails Reviewed-by: never, dholmes

---
 src/share/vm/prims/jni.cpp      | 7 ++++---
 src/share/vm/runtime/thread.cpp | 3 +++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/share/vm/prims/jni.cpp b/src/share/vm/prims/jni.cpp
index fbf66099a..1cbfa61a1 100644
--- a/src/share/vm/prims/jni.cpp
+++ b/src/share/vm/prims/jni.cpp
@@ -3401,12 +3401,16 @@ static jint attach_current_thread(JavaVM *vm, void **penv, void *_args, bool dae
   thread->set_thread_state(_thread_in_vm);
   // Must do this before initialize_thread_local_storage
   thread->record_stack_base_and_size();
+
   thread->initialize_thread_local_storage();
 
   if (!os::create_attached_thread(thread)) {
     delete thread;
     return JNI_ERR;
   }
+  // Enable stack overflow checks
+  thread->create_stack_guard_pages();
+
   thread->initialize_tlab();
 
   // Crucial that we do not have a safepoint check for this thread, since it has
@@ -3452,9 +3456,6 @@ static jint attach_current_thread(JavaVM *vm, void **penv, void *_args, bool dae
   // to regrab the threads_lock
   thread->set_attached();
 
-  // Enable stack overflow checks
-  thread->create_stack_guard_pages();
-
   // Set java thread status.
   java_lang_Thread::set_thread_status(thread->threadObj(),
               java_lang_Thread::RUNNABLE);
diff --git a/src/share/vm/runtime/thread.cpp b/src/share/vm/runtime/thread.cpp
index 3bdf8dad0..e05be5e41 100644
--- a/src/share/vm/runtime/thread.cpp
+++ b/src/share/vm/runtime/thread.cpp
@@ -1637,6 +1637,9 @@ void JavaThread::cleanup_failed_attach_current_thread() {
     JNIHandleBlock::release_block(block);
   }
 
+  // These have to be removed while this is still a valid thread.
+  remove_stack_guard_pages();
+
   if (UseTLAB) {
     tlab().make_parsable(true);  // retire TLAB, if any
   }
-- 
GitLab