From b4977f9aab67d83a6edf5f526db683000ad46952 Mon Sep 17 00:00:00 2001 From: minqi Date: Mon, 8 Oct 2012 16:48:52 -0700 Subject: [PATCH] 8000332: SA ClassDump throws exception after permgen removal Summary: In ClassWrite.writeFields(), fields count was mistakenly set to fields length which overflow the array index. Also removed a file which is leftover from 6879063 changeset. Reviewed-by: coleenp, sspitsyn Contributed-by: yumin.qi@oracle.com --- .../classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java | 9 ++++----- agent/src/share/native/sadis.c | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java b/agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java index d7c9913da..954052703 100644 --- a/agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java +++ b/agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java @@ -354,15 +354,14 @@ public class ClassWriter implements /* imports */ ClassConstants } protected void writeFields() throws IOException { - U2Array fields = klass.getFields(); - final int length = (int) fields.length(); + final int javaFieldsCount = klass.getJavaFieldsCount(); // write number of fields - dos.writeShort((short) length); + dos.writeShort((short) javaFieldsCount); - if (DEBUG) debugMessage("number of fields = " + length); + if (DEBUG) debugMessage("number of fields = " + javaFieldsCount); - for (int index = 0; index < length; index++) { + for (int index = 0; index < javaFieldsCount; index++) { short accessFlags = klass.getFieldAccessFlags(index); dos.writeShort(accessFlags & (short) JVM_RECOGNIZED_FIELD_MODIFIERS); diff --git a/agent/src/share/native/sadis.c b/agent/src/share/native/sadis.c index 0a2ad68b8..06525deec 100644 --- a/agent/src/share/native/sadis.c +++ b/agent/src/share/native/sadis.c @@ -46,7 +46,7 @@ #else -#include +#include #include #include -- GitLab