diff --git a/src/cpu/x86/vm/sharedRuntime_x86_64.cpp b/src/cpu/x86/vm/sharedRuntime_x86_64.cpp index c2f69f7c3c0954b9e5ddc2ff62b3171cd52c6212..2ba2c1531e64deb3f9d143d7be1aa89275145c65 100644 --- a/src/cpu/x86/vm/sharedRuntime_x86_64.cpp +++ b/src/cpu/x86/vm/sharedRuntime_x86_64.cpp @@ -2098,7 +2098,7 @@ nmethod* SharedRuntime::generate_native_wrapper(MacroAssembler* masm, // critical natives they are offset down. GrowableArray arg_order(2 * total_in_args); VMRegPair tmp_vmreg; - tmp_vmreg.set1(rbx->as_VMReg()); + tmp_vmreg.set2(rbx->as_VMReg()); if (!is_critical_native) { for (int i = total_in_args - 1, c_arg = total_c_args - 1; i >= 0; i--, c_arg--) { diff --git a/test/compiler/criticalnatives/argumentcorruption/CheckLongArgs.java b/test/compiler/criticalnatives/argumentcorruption/CheckLongArgs.java new file mode 100644 index 0000000000000000000000000000000000000000..23ba96e7fc005f320f6492655e3ae248d5056e27 --- /dev/null +++ b/test/compiler/criticalnatives/argumentcorruption/CheckLongArgs.java @@ -0,0 +1,54 @@ +/* + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +public class CheckLongArgs { + static { + System.loadLibrary("CNCheckLongArgs"); + } + static native void m1(long a1, long a2, long a3, long a4, long a5, long a6, long a7, long a8, byte[] result); + static native void m2(long a1, int[] a2, long a3, int[] a4, long a5, int[] a6, long a7, int[] a8, long a9, byte[] result); + public static void main(String args[]) throws Exception { + test(); + } + private static void test() throws Exception { + int[] l1 = { 1111, 2222, 3333 }; + int[] l2 = { 4444, 5555, 6666 }; + int[] l3 = { 7777, 8888, 9999 }; + int[] l4 = { 1010, 2020, 3030 }; + byte[] result = { -1 }; + m1(1111111122222222L, 3333333344444444L, 5555555566666666L, 7777777788888888L, 9999999900000000L, 1212121234343434L, + 5656565678787878L, 9090909012121212L, result); + check(result[0]); + result[0] = -1; + m2(1111111122222222L, l1, 3333333344444444L, l2, 5555555566666666L, l3, 7777777788888888L, l4, 9999999900000000L, result); + check(result[0]); + } + private static void check(byte result) throws Exception { + if (result != 2) { + if (result == 1) { + throw new Exception("critical native arguments mismatch"); + } + throw new Exception("critical native lookup failed"); + } + } +} diff --git a/test/compiler/criticalnatives/argumentcorruption/Test8167409.sh b/test/compiler/criticalnatives/argumentcorruption/Test8167409.sh new file mode 100644 index 0000000000000000000000000000000000000000..81695e758246742c7ca270923573f16475c00623 --- /dev/null +++ b/test/compiler/criticalnatives/argumentcorruption/Test8167409.sh @@ -0,0 +1,83 @@ +#!/bin/sh + +# +# Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved. +# Copyright (c) 2019 Huawei Technologies Co. LTD. All Rights Reserved. +# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. +# +# This code is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License version 2 only, as +# published by the Free Software Foundation. +# +# This code is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License +# version 2 for more details (a copy is included in the LICENSE file that +# accompanied this code). +# +# You should have received a copy of the GNU General Public License version +# 2 along with this work; if not, write to the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. +# +# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA +# or visit www.oracle.com if you need additional information or have any +# questions. +# + +## @test Test8167409.sh +## @bug 8167409 +## @summary Invalid value passed to critical JNI function +## @run shell Test8167409.sh + +if [ "${TESTSRC}" = "" ] +then + TESTSRC=${PWD} + echo "TESTSRC not set. Using "${TESTSRC}" as default" +fi +echo "TESTSRC=${TESTSRC}" +## Adding common setup Variables for running shell tests. +. ${TESTSRC}/../../../test_env.sh + +# set platform-dependent variables +OS=`uname -s` +echo "Testing on " $OS +case "$OS" in + Linux) + cc_cmd=`which gcc` + if [ "x$cc_cmd" == "x" ]; then + echo "WARNING: gcc not found. Cannot execute test." 2>&1 + exit 0; + fi + ;; + Solaris) + cc_cmd=`which cc` + if [ "x$cc_cmd" == "x" ]; then + echo "WARNING: cc not found. Cannot execute test." 2>&1 + exit 0; + fi + ;; + *) + echo "Test passed; only valid for Linux and Solaris" + exit 0; + ;; +esac + +THIS_DIR=. + +cp ${TESTSRC}${FS}*.java ${THIS_DIR} +${TESTJAVA}${FS}bin${FS}javac *.java + +$cc_cmd -fPIC -shared -o libCNCheckLongArgs.so \ + -I${TESTJAVA}${FS}include -I${TESTJAVA}${FS}include${FS}linux \ + ${TESTSRC}${FS}libCNCheckLongArgs.c + +LD_LIBRARY_PATH=${THIS_DIR} +echo LD_LIBRARY_PATH = ${LD_LIBRARY_PATH} +export LD_LIBRARY_PATH + +echo +echo ${TESTJAVA}${FS}bin${FS}java -cp ${THIS_DIR} -Xcomp -XX:+CriticalJNINatives CheckLongArgs +${TESTJAVA}${FS}bin${FS}java -cp ${THIS_DIR} -Xcomp -XX:+CriticalJNINatives CheckLongArgs +JAVA_RETVAL=$? + +exit $JAVA_RETVAL diff --git a/test/compiler/criticalnatives/argumentcorruption/libCNCheckLongArgs.c b/test/compiler/criticalnatives/argumentcorruption/libCNCheckLongArgs.c new file mode 100644 index 0000000000000000000000000000000000000000..33ec5b4442b220e02e0ef5b05cc4c6d0235acf28 --- /dev/null +++ b/test/compiler/criticalnatives/argumentcorruption/libCNCheckLongArgs.c @@ -0,0 +1,30 @@ +#include "jni.h" +JNIEXPORT void JNICALL JavaCritical_CheckLongArgs_m1 + (jlong a1, jlong a2, jlong a3, jlong a4, jlong a5, jlong a6, jlong a7, jlong a8,jint result_length,jbyte* result) { + + if (a1 != 1111111122222222LL || a2 != 3333333344444444LL || a3 != 5555555566666666LL || a4 != 7777777788888888LL || + a5 != 9999999900000000LL || a6 != 1212121234343434LL || a7 != 5656565678787878LL || a8 != 9090909012121212LL || + result_length != 1 || result[0] != -1) { + result[0] = 1; + } else { + result[0] = 2; + } +} + +JNIEXPORT void JNICALL JavaCritical_CheckLongArgs_m2 + (jlong a1, jint a2_length, jint* a2, jlong a3, jint a4_length, jint* a4, jlong a5, jint a6_length, jint* a6, jlong a7, + jint a8_length, jint* a8, jlong a9, jint result_length, jbyte* result) { + if (a1 != 1111111122222222LL || a2_length != 3 || a2[0] != 1111 || a3 != 3333333344444444LL || a4_length != 3 || a4[0] != 4444 || + a5 != 5555555566666666LL || a6_length != 3 || a6[0] != 7777 || a7 != 7777777788888888LL || a8_length != 3 || a8[0] != 1010 || a9 != 9999999900000000LL || + result_length != 1 || result[0] != -1) { + result[0] = 1; + } else { + result[0] = 2; + } +} + +JNIEXPORT void JNICALL Java_CheckLongArgs_m1 + (JNIEnv * env, jclass jclazz, jlong a3, jlong a4, jlong a5, jlong a6, jlong a7, jlong a8, jlong a9, jlong a10, jbyteArray result) {} + +JNIEXPORT void JNICALL Java_CheckLongArgs_m2 + (JNIEnv * env, jclass jclazz, jlong a3, jintArray a4, jlong a5, jintArray a6, jlong a7, jintArray a8, jlong a9, jintArray a10, jlong a11, jbyteArray result) {}