diff --git a/src/share/vm/memory/metaspace.cpp b/src/share/vm/memory/metaspace.cpp index 97ac77e830e117249bd88f437151486d5a2c7d2b..99a0d0407c395efc65d320b2595ab70ec699f7ce 100644 --- a/src/share/vm/memory/metaspace.cpp +++ b/src/share/vm/memory/metaspace.cpp @@ -2541,41 +2541,14 @@ void SpaceManager::mangle_freed_chunks() { // MetaspaceAux -size_t MetaspaceAux::used_in_bytes_unsafe(Metaspace::MetadataType mdtype) { - size_t used = 0; - ClassLoaderDataGraphMetaspaceIterator iter; - while (iter.repeat()) { - Metaspace* msp = iter.get_next(); - // Sum allocation_total for each metaspace - if (msp != NULL) { - used += msp->used_words(mdtype); - } - } - return used * BytesPerWord; -} - size_t MetaspaceAux::used_in_bytes(Metaspace::MetadataType mdtype) { - assert(SafepointSynchronize::is_at_safepoint(), - "Consistency checks require being at a safepoint"); size_t used = 0; -#ifdef ASSERT - size_t free = 0; - size_t capacity = 0; -#endif ClassLoaderDataGraphMetaspaceIterator iter; while (iter.repeat()) { Metaspace* msp = iter.get_next(); // Sum allocation_total for each metaspace if (msp != NULL) { used += msp->used_words(mdtype); -#ifdef ASSERT - free += msp->free_words(mdtype); - capacity += msp->capacity_words(mdtype); - assert(used + free == capacity, - err_msg("Accounting is wrong used " SIZE_FORMAT - " free " SIZE_FORMAT " capacity " SIZE_FORMAT, - used, free, capacity)); -#endif } } return used * BytesPerWord; @@ -2661,15 +2634,15 @@ void MetaspaceAux::print_on(outputStream* out) { out->print_cr(" Metaspace total " SIZE_FORMAT "K, used " SIZE_FORMAT "K," " reserved " SIZE_FORMAT "K", - capacity_in_bytes()/K, used_in_bytes_unsafe()/K, reserved_in_bytes()/K); + capacity_in_bytes()/K, used_in_bytes()/K, reserved_in_bytes()/K); out->print_cr(" data space " SIZE_FORMAT "K, used " SIZE_FORMAT "K," " reserved " SIZE_FORMAT "K", - capacity_in_bytes(nct)/K, used_in_bytes_unsafe(nct)/K, reserved_in_bytes(nct)/K); + capacity_in_bytes(nct)/K, used_in_bytes(nct)/K, reserved_in_bytes(nct)/K); out->print_cr(" class space " SIZE_FORMAT "K, used " SIZE_FORMAT "K," " reserved " SIZE_FORMAT "K", - capacity_in_bytes(ct)/K, used_in_bytes_unsafe(ct)/K, reserved_in_bytes(ct)/K); + capacity_in_bytes(ct)/K, used_in_bytes(ct)/K, reserved_in_bytes(ct)/K); } // Print information for class space and data space separately. diff --git a/src/share/vm/memory/metaspace.hpp b/src/share/vm/memory/metaspace.hpp index 73580d10091a3814b1427c49d72cc6b71175e4b6..dd516e87f3fb1e78920054d72b92993e9238aca4 100644 --- a/src/share/vm/memory/metaspace.hpp +++ b/src/share/vm/memory/metaspace.hpp @@ -149,10 +149,6 @@ class MetaspaceAux : AllStatic { // Statistics for class space and data space in metaspace. static size_t used_in_bytes(Metaspace::MetadataType mdtype); - // Same as used_in_bytes() without the consistency checking. - // Use this version if not at a safepoint (so consistency is - // not necessarily expected). - static size_t used_in_bytes_unsafe(Metaspace::MetadataType mdtype); static size_t free_in_bytes(Metaspace::MetadataType mdtype); static size_t capacity_in_bytes(Metaspace::MetadataType mdtype); static size_t reserved_in_bytes(Metaspace::MetadataType mdtype); @@ -167,11 +163,6 @@ class MetaspaceAux : AllStatic { used_in_bytes(Metaspace::NonClassType); } - static size_t used_in_bytes_unsafe() { - return used_in_bytes_unsafe(Metaspace::ClassType) + - used_in_bytes_unsafe(Metaspace::NonClassType); - } - // Total of available space in all Metaspaces // Total of capacity allocated to all Metaspaces. This includes // space in Metachunks not yet allocated and in the Metachunk diff --git a/src/share/vm/memory/metaspaceCounters.cpp b/src/share/vm/memory/metaspaceCounters.cpp index d092d19a8e97a2726320b9e2de7c780cca4de98b..d8237f73418a816498f7db3980597d64169f69d9 100644 --- a/src/share/vm/memory/metaspaceCounters.cpp +++ b/src/share/vm/memory/metaspaceCounters.cpp @@ -35,7 +35,7 @@ MetaspaceCounters::MetaspaceCounters() { size_t min_capacity = MetaspaceAux::min_chunk_size(); size_t max_capacity = MetaspaceAux::reserved_in_bytes(); size_t curr_capacity = MetaspaceAux::capacity_in_bytes(); - size_t used = MetaspaceAux::used_in_bytes_unsafe(); + size_t used = MetaspaceAux::used_in_bytes(); initialize(min_capacity, max_capacity, curr_capacity, used); } @@ -131,7 +131,7 @@ void MetaspaceCounters::update_capacity() { void MetaspaceCounters::update_used() { assert(UsePerfData, "Should not be called unless being used"); - size_t used_in_bytes = MetaspaceAux::used_in_bytes_unsafe(); + size_t used_in_bytes = MetaspaceAux::used_in_bytes(); _used->set_value(used_in_bytes); }