提交 25971de6 编写于 作者: D drchase

8010124: JVM_GetClassContext: use GrowableArray instead of KlassLink

Summary: replace linked data structure with array (performance)
Reviewed-by: kvn
Contributed-by: christian.thalinger@oracle.com, david.r.chase@oracle.com
上级 3f11548d
...@@ -3230,24 +3230,10 @@ JVM_ENTRY(jobject, JVM_CurrentClassLoader(JNIEnv *env)) ...@@ -3230,24 +3230,10 @@ JVM_ENTRY(jobject, JVM_CurrentClassLoader(JNIEnv *env))
JVM_END JVM_END
// Utility object for collecting method holders walking down the stack
class KlassLink: public ResourceObj {
public:
KlassHandle klass;
KlassLink* next;
KlassLink(KlassHandle k) { klass = k; next = NULL; }
};
JVM_ENTRY(jobjectArray, JVM_GetClassContext(JNIEnv *env)) JVM_ENTRY(jobjectArray, JVM_GetClassContext(JNIEnv *env))
JVMWrapper("JVM_GetClassContext"); JVMWrapper("JVM_GetClassContext");
ResourceMark rm(THREAD); ResourceMark rm(THREAD);
JvmtiVMObjectAllocEventCollector oam; JvmtiVMObjectAllocEventCollector oam;
// Collect linked list of (handles to) method holders
KlassLink* first = NULL;
KlassLink* last = NULL;
int depth = 0;
vframeStream vfst(thread); vframeStream vfst(thread);
if (SystemDictionary::reflect_CallerSensitive_klass() != NULL) { if (SystemDictionary::reflect_CallerSensitive_klass() != NULL) {
...@@ -3261,32 +3247,23 @@ JVM_ENTRY(jobjectArray, JVM_GetClassContext(JNIEnv *env)) ...@@ -3261,32 +3247,23 @@ JVM_ENTRY(jobjectArray, JVM_GetClassContext(JNIEnv *env))
} }
// Collect method holders // Collect method holders
GrowableArray<KlassHandle>* klass_array = new GrowableArray<KlassHandle>();
for (; !vfst.at_end(); vfst.security_next()) { for (; !vfst.at_end(); vfst.security_next()) {
Method* m = vfst.method(); Method* m = vfst.method();
// Native frames are not returned // Native frames are not returned
if (!m->is_ignored_by_security_stack_walk() && !m->is_native()) { if (!m->is_ignored_by_security_stack_walk() && !m->is_native()) {
Klass* holder = m->method_holder(); Klass* holder = m->method_holder();
assert(holder->is_klass(), "just checking"); assert(holder->is_klass(), "just checking");
depth++; klass_array->append(holder);
KlassLink* l = new KlassLink(KlassHandle(thread, holder));
if (first == NULL) {
first = last = l;
} else {
last->next = l;
last = l;
}
} }
} }
// Create result array of type [Ljava/lang/Class; // Create result array of type [Ljava/lang/Class;
objArrayOop result = oopFactory::new_objArray(SystemDictionary::Class_klass(), depth, CHECK_NULL); objArrayOop result = oopFactory::new_objArray(SystemDictionary::Class_klass(), klass_array->length(), CHECK_NULL);
// Fill in mirrors corresponding to method holders // Fill in mirrors corresponding to method holders
int index = 0; for (int i = 0; i < klass_array->length(); i++) {
while (first != NULL) { result->obj_at_put(i, klass_array->at(i)->java_mirror());
result->obj_at_put(index++, first->klass()->java_mirror());
first = first->next;
} }
assert(index == depth, "just checking");
return (jobjectArray) JNIHandles::make_local(env, result); return (jobjectArray) JNIHandles::make_local(env, result);
JVM_END JVM_END
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册