提交 f955e141 编写于 作者: D Dan Carpenter 提交者: David S. Miller

vmxnet3: locking problems in xmit

There were several paths that didn't release their locks.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NBhavesh Davda <bhavesh@vmware.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 6561a3b1
...@@ -980,7 +980,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq, ...@@ -980,7 +980,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
} }
} else { } else {
tq->stats.drop_hdr_inspect_err++; tq->stats.drop_hdr_inspect_err++;
goto drop_pkt; goto unlock_drop_pkt;
} }
/* fill tx descs related to addr & len */ /* fill tx descs related to addr & len */
...@@ -1052,6 +1052,8 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq, ...@@ -1052,6 +1052,8 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
hdr_too_big: hdr_too_big:
tq->stats.drop_oversized_hdr++; tq->stats.drop_oversized_hdr++;
unlock_drop_pkt:
spin_unlock_irqrestore(&tq->tx_lock, flags);
drop_pkt: drop_pkt:
tq->stats.drop_total++; tq->stats.drop_total++;
dev_kfree_skb(skb); dev_kfree_skb(skb);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册