From f8801dbcf0914b6a16848d583761112c32cf4d49 Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Thu, 7 Nov 2019 09:17:36 -0700 Subject: [PATCH] io-wq: io_wqe_run_queue() doesn't need to use list_empty_careful() commit 91d666ea43adef57a6cd50c81b9603c545654981 upstream. We hold the wqe lock at this point (which is also annotated), so there's no need to use the careful variant of list_empty(). Signed-off-by: Jens Axboe Signed-off-by: Joseph Qi Reviewed-by: Xiaoguang Wang --- fs/io-wq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/io-wq.c b/fs/io-wq.c index 4228c7967b76..a0e18a633958 100644 --- a/fs/io-wq.c +++ b/fs/io-wq.c @@ -339,8 +339,7 @@ static void io_worker_handle_work(struct io_worker *worker) static inline bool io_wqe_run_queue(struct io_wqe *wqe) __must_hold(wqe->lock) { - if (!list_empty_careful(&wqe->work_list) && - !(wqe->flags & IO_WQE_FLAG_STALLED)) + if (!list_empty(&wqe->work_list) && !(wqe->flags & IO_WQE_FLAG_STALLED)) return true; return false; } -- GitLab