From d5c76f628d399f06785b0ee910c431770a01b807 Mon Sep 17 00:00:00 2001 From: Florian Fainelli Date: Thu, 20 Mar 2014 10:53:22 -0700 Subject: [PATCH] net: bcmgenet: remove bogus tx queue checks netdev_pick_tx already takes care of making sure that a given skb->queue_mapping value will remain within the number of advertised hardware queue number, there is no need to re-do this again in the driver. Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 0a9f6df819bb..cfcb046f4de5 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -1125,14 +1125,6 @@ static netdev_tx_t bcmgenet_xmit(struct sk_buff *skb, struct net_device *dev) else index -= 1; - if ((index != DESC_INDEX) && (index > priv->hw_params->tx_queues - 1)) { - netdev_err(dev, "%s: queue_mapping %d is invalid\n", - __func__, skb_get_queue_mapping(skb)); - dev->stats.tx_errors++; - dev->stats.tx_dropped++; - ret = NETDEV_TX_OK; - goto out; - } nr_frags = skb_shinfo(skb)->nr_frags; ring = &priv->tx_rings[index]; -- GitLab