diff --git a/include/net/sock.h b/include/net/sock.h index c64a1cff9eb35651da65e1fa8ad09237c625cce4..f18dbd6da9066bce13f8f29f3ffda58cc9f1c43c 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -1491,6 +1491,7 @@ static inline void lock_sock(struct sock *sk) lock_sock_nested(sk, 0); } +void __release_sock(struct sock *sk); void release_sock(struct sock *sk); /* BH context may only use the following locking interface. */ diff --git a/net/core/sock.c b/net/core/sock.c index 3730eb855095429b36018d006c82283d9a810577..748765e354234989da330240fbc5b9cc7b01f067 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -2317,7 +2317,7 @@ static void __lock_sock(struct sock *sk) finish_wait(&sk->sk_lock.wq, &wait); } -static void __release_sock(struct sock *sk) +void __release_sock(struct sock *sk) __releases(&sk->sk_lock.slock) __acquires(&sk->sk_lock.slock) { diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index bbd07736fb0fe39b223a7b40b3b2d1b7b222cda3..a32a0f4cc1389291fe2085d08ab6a23d394050d7 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -2403,16 +2403,10 @@ void tcp_close(struct sock *sk, long timeout) sock_hold(sk); sock_orphan(sk); - /* It is the last release_sock in its life. It will remove backlog. */ - release_sock(sk); - - - /* Now socket is owned by kernel and we acquire BH lock - * to finish close. No need to check for user refs. - */ local_bh_disable(); bh_lock_sock(sk); - WARN_ON(sock_owned_by_user(sk)); + /* remove backlog if any, without releasing ownership. */ + __release_sock(sk); percpu_counter_inc(sk->sk_prot->orphan_count); @@ -2481,6 +2475,7 @@ void tcp_close(struct sock *sk, long timeout) out: bh_unlock_sock(sk); local_bh_enable(); + release_sock(sk); sock_put(sk); } EXPORT_SYMBOL(tcp_close);