提交 c42b110c 编写于 作者: P Pawel Osciak 提交者: Linus Torvalds

s3c-fb: fix off-by-one bug in loop indexes

Fixed off-by-one bug in loop indexes - some elements beyond windows' array
were accessed, which might result in memory access violations when
removing/suspending the device.
Signed-off-by: NPawel Osciak <p.osciak@samsung.com>
Reviewed-by: NKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: NMarek Szyprowski <m.szyprowski@samsung.com>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
上级 3d768213
...@@ -964,7 +964,7 @@ static int __devexit s3c_fb_remove(struct platform_device *pdev) ...@@ -964,7 +964,7 @@ static int __devexit s3c_fb_remove(struct platform_device *pdev)
struct s3c_fb *sfb = platform_get_drvdata(pdev); struct s3c_fb *sfb = platform_get_drvdata(pdev);
int win; int win;
for (win = 0; win <= S3C_FB_MAX_WIN; win++) for (win = 0; win < S3C_FB_MAX_WIN; win++)
if (sfb->windows[win]) if (sfb->windows[win])
s3c_fb_release_win(sfb, sfb->windows[win]); s3c_fb_release_win(sfb, sfb->windows[win]);
...@@ -988,7 +988,7 @@ static int s3c_fb_suspend(struct platform_device *pdev, pm_message_t state) ...@@ -988,7 +988,7 @@ static int s3c_fb_suspend(struct platform_device *pdev, pm_message_t state)
struct s3c_fb_win *win; struct s3c_fb_win *win;
int win_no; int win_no;
for (win_no = S3C_FB_MAX_WIN; win_no >= 0; win_no--) { for (win_no = S3C_FB_MAX_WIN - 1; win_no >= 0; win_no--) {
win = sfb->windows[win_no]; win = sfb->windows[win_no];
if (!win) if (!win)
continue; continue;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册