提交 95101947 编写于 作者: H Hugues Fruchet 提交者: Greg Kroah-Hartman

media: stm32-dcmi: fix check of pm_runtime_get_sync return value

commit ab41b99e7e55c85f29ff7b54718ccbbe051905e7 upstream.

Start streaming was sometimes failing because of pm_runtime_get_sync()
non-0 return value. In fact return value was not an error but a
positive value (1), indicating that PM was already enabled.
Fix this by going to error path only with negative return value.
Signed-off-by: NHugues Fruchet <hugues.fruchet@st.com>
Signed-off-by: NHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: NMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
上级 e7455065
...@@ -584,9 +584,9 @@ static int dcmi_start_streaming(struct vb2_queue *vq, unsigned int count) ...@@ -584,9 +584,9 @@ static int dcmi_start_streaming(struct vb2_queue *vq, unsigned int count)
int ret; int ret;
ret = pm_runtime_get_sync(dcmi->dev); ret = pm_runtime_get_sync(dcmi->dev);
if (ret) { if (ret < 0) {
dev_err(dcmi->dev, "%s: Failed to start streaming, cannot get sync\n", dev_err(dcmi->dev, "%s: Failed to start streaming, cannot get sync (%d)\n",
__func__); __func__, ret);
goto err_release_buffers; goto err_release_buffers;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册