提交 7429b384 编写于 作者: W Wolfram Sang 提交者: Benjamin Herrenschmidt

powerpc/pmac: Fix dangling pointers

Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.
Signed-off-by: NWolfram Sang <w.sang@pengutronix.de>
Cc: Colin Leroy <colin@colino.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: NBenjamin Herrenschmidt <benh@kernel.crashing.org>
上级 21dbeb91
...@@ -182,6 +182,7 @@ remove_thermostat(struct i2c_client *client) ...@@ -182,6 +182,7 @@ remove_thermostat(struct i2c_client *client)
thermostat = NULL; thermostat = NULL;
i2c_set_clientdata(client, NULL);
kfree(th); kfree(th);
return 0; return 0;
...@@ -399,6 +400,7 @@ static int probe_thermostat(struct i2c_client *client, ...@@ -399,6 +400,7 @@ static int probe_thermostat(struct i2c_client *client,
rc = read_reg(th, CONFIG_REG); rc = read_reg(th, CONFIG_REG);
if (rc < 0) { if (rc < 0) {
dev_err(&client->dev, "Thermostat failed to read config!\n"); dev_err(&client->dev, "Thermostat failed to read config!\n");
i2c_set_clientdata(client, NULL);
kfree(th); kfree(th);
return -ENODEV; return -ENODEV;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册