提交 60fa7426 编写于 作者: L Luis R. Rodriguez 提交者: Greg Kroah-Hartman

rename: _request_firmware_load() fw_load_sysfs_fallback()

This reflects much clearer what is being done.
While at it, kdoc'ify it.
Signed-off-by: NLuis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
上级 b3cf21fa
...@@ -112,7 +112,7 @@ Since a device is created for the sysfs interface to help load firmware as a ...@@ -112,7 +112,7 @@ Since a device is created for the sysfs interface to help load firmware as a
fallback mechanism userspace can be informed of the addition of the device by fallback mechanism userspace can be informed of the addition of the device by
relying on kobject uevents. The addition of the device into the device relying on kobject uevents. The addition of the device into the device
hierarchy means the fallback mechanism for firmware loading has been initiated. hierarchy means the fallback mechanism for firmware loading has been initiated.
For details of implementation refer to _request_firmware_load(), in particular For details of implementation refer to fw_load_sysfs_fallback(), in particular
on the use of dev_set_uevent_suppress() and kobject_uevent(). on the use of dev_set_uevent_suppress() and kobject_uevent().
The kernel's kobject uevent mechanism is implemented in lib/kobject_uevent.c, The kernel's kobject uevent mechanism is implemented in lib/kobject_uevent.c,
......
...@@ -535,8 +535,15 @@ fw_create_instance(struct firmware *firmware, const char *fw_name, ...@@ -535,8 +535,15 @@ fw_create_instance(struct firmware *firmware, const char *fw_name,
return fw_sysfs; return fw_sysfs;
} }
/* load a firmware via user helper */ /**
static int _request_firmware_load(struct fw_sysfs *fw_sysfs, * fw_load_sysfs_fallback - load a firmware via the syfs fallback mechanism
* @fw_sysfs: firmware syfs information for the firmware to load
* @opt_flags: flags of options, FW_OPT_*
* @timeout: timeout to wait for the load
*
* In charge of constructing a sysfs fallback interface for firmware loading.
**/
static int fw_load_sysfs_fallback(struct fw_sysfs *fw_sysfs,
unsigned int opt_flags, long timeout) unsigned int opt_flags, long timeout)
{ {
int retval = 0; int retval = 0;
...@@ -621,7 +628,7 @@ static int fw_load_from_user_helper(struct firmware *firmware, ...@@ -621,7 +628,7 @@ static int fw_load_from_user_helper(struct firmware *firmware,
} }
fw_sysfs->fw_priv = firmware->priv; fw_sysfs->fw_priv = firmware->priv;
ret = _request_firmware_load(fw_sysfs, opt_flags, timeout); ret = fw_load_sysfs_fallback(fw_sysfs, opt_flags, timeout);
if (!ret) if (!ret)
ret = assign_fw(firmware, device, opt_flags); ret = assign_fw(firmware, device, opt_flags);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册