提交 5d512fcd 编写于 作者: A Archit Taneja 提交者: Tomi Valkeinen

OMAPDSS: DPI: Replace dssdev->manager with dssdev->output->manager references

With addition of output entities, a device connects to an output, and an output
connects to overlay manager. Replace the dssdev->manager references with
dssdev->output->manager to access the manager correctly.

When enabling the DPI output, check whether the output entity connected to
display is not NULL.
Signed-off-by: NArchit Taneja <archit@ti.com>
上级 32248276
...@@ -128,6 +128,7 @@ static int dpi_set_dispc_clk(struct omap_dss_device *dssdev, ...@@ -128,6 +128,7 @@ static int dpi_set_dispc_clk(struct omap_dss_device *dssdev,
static int dpi_set_mode(struct omap_dss_device *dssdev) static int dpi_set_mode(struct omap_dss_device *dssdev)
{ {
struct omap_video_timings *t = &dpi.timings; struct omap_video_timings *t = &dpi.timings;
struct omap_overlay_manager *mgr = dssdev->output->manager;
int lck_div = 0, pck_div = 0; int lck_div = 0, pck_div = 0;
unsigned long fck = 0; unsigned long fck = 0;
unsigned long pck; unsigned long pck;
...@@ -152,13 +153,15 @@ static int dpi_set_mode(struct omap_dss_device *dssdev) ...@@ -152,13 +153,15 @@ static int dpi_set_mode(struct omap_dss_device *dssdev)
t->pixel_clock = pck; t->pixel_clock = pck;
} }
dss_mgr_set_timings(dssdev->manager, t); dss_mgr_set_timings(mgr, t);
return 0; return 0;
} }
static void dpi_config_lcd_manager(struct omap_dss_device *dssdev) static void dpi_config_lcd_manager(struct omap_dss_device *dssdev)
{ {
struct omap_overlay_manager *mgr = dssdev->output->manager;
dpi.mgr_config.io_pad_mode = DSS_IO_PAD_MODE_BYPASS; dpi.mgr_config.io_pad_mode = DSS_IO_PAD_MODE_BYPASS;
dpi.mgr_config.stallmode = false; dpi.mgr_config.stallmode = false;
...@@ -168,11 +171,12 @@ static void dpi_config_lcd_manager(struct omap_dss_device *dssdev) ...@@ -168,11 +171,12 @@ static void dpi_config_lcd_manager(struct omap_dss_device *dssdev)
dpi.mgr_config.lcden_sig_polarity = 0; dpi.mgr_config.lcden_sig_polarity = 0;
dss_mgr_set_lcd_config(dssdev->manager, &dpi.mgr_config); dss_mgr_set_lcd_config(mgr, &dpi.mgr_config);
} }
int omapdss_dpi_display_enable(struct omap_dss_device *dssdev) int omapdss_dpi_display_enable(struct omap_dss_device *dssdev)
{ {
struct omap_dss_output *out = dssdev->output;
int r; int r;
mutex_lock(&dpi.lock); mutex_lock(&dpi.lock);
...@@ -183,10 +187,10 @@ int omapdss_dpi_display_enable(struct omap_dss_device *dssdev) ...@@ -183,10 +187,10 @@ int omapdss_dpi_display_enable(struct omap_dss_device *dssdev)
goto err_no_reg; goto err_no_reg;
} }
if (dssdev->manager == NULL) { if (out == NULL || out->manager == NULL) {
DSSERR("failed to enable display: no manager\n"); DSSERR("failed to enable display: no output/manager\n");
r = -ENODEV; r = -ENODEV;
goto err_no_mgr; goto err_no_out_mgr;
} }
r = omap_dss_start_device(dssdev); r = omap_dss_start_device(dssdev);
...@@ -227,7 +231,7 @@ int omapdss_dpi_display_enable(struct omap_dss_device *dssdev) ...@@ -227,7 +231,7 @@ int omapdss_dpi_display_enable(struct omap_dss_device *dssdev)
mdelay(2); mdelay(2);
r = dss_mgr_enable(dssdev->manager); r = dss_mgr_enable(out->manager);
if (r) if (r)
goto err_mgr_enable; goto err_mgr_enable;
...@@ -251,7 +255,7 @@ int omapdss_dpi_display_enable(struct omap_dss_device *dssdev) ...@@ -251,7 +255,7 @@ int omapdss_dpi_display_enable(struct omap_dss_device *dssdev)
err_reg_enable: err_reg_enable:
omap_dss_stop_device(dssdev); omap_dss_stop_device(dssdev);
err_start_dev: err_start_dev:
err_no_mgr: err_no_out_mgr:
err_no_reg: err_no_reg:
mutex_unlock(&dpi.lock); mutex_unlock(&dpi.lock);
return r; return r;
...@@ -260,9 +264,11 @@ EXPORT_SYMBOL(omapdss_dpi_display_enable); ...@@ -260,9 +264,11 @@ EXPORT_SYMBOL(omapdss_dpi_display_enable);
void omapdss_dpi_display_disable(struct omap_dss_device *dssdev) void omapdss_dpi_display_disable(struct omap_dss_device *dssdev)
{ {
struct omap_overlay_manager *mgr = dssdev->output->manager;
mutex_lock(&dpi.lock); mutex_lock(&dpi.lock);
dss_mgr_disable(dssdev->manager); dss_mgr_disable(mgr);
if (dpi_use_dsi_pll(dssdev)) { if (dpi_use_dsi_pll(dssdev)) {
dss_select_dispc_clk_source(OMAP_DSS_CLK_SRC_FCK); dss_select_dispc_clk_source(OMAP_DSS_CLK_SRC_FCK);
...@@ -298,12 +304,13 @@ int dpi_check_timings(struct omap_dss_device *dssdev, ...@@ -298,12 +304,13 @@ int dpi_check_timings(struct omap_dss_device *dssdev,
struct omap_video_timings *timings) struct omap_video_timings *timings)
{ {
int r; int r;
struct omap_overlay_manager *mgr = dssdev->output->manager;
int lck_div, pck_div; int lck_div, pck_div;
unsigned long fck; unsigned long fck;
unsigned long pck; unsigned long pck;
struct dispc_clock_info dispc_cinfo; struct dispc_clock_info dispc_cinfo;
if (dss_mgr_check_timings(dssdev->manager, timings)) if (dss_mgr_check_timings(mgr, timings))
return -EINVAL; return -EINVAL;
if (timings->pixel_clock == 0) if (timings->pixel_clock == 0)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册