提交 5809fde0 编写于 作者: T Thomas Jarosch 提交者: Arnaldo Carvalho de Melo

perf header: Fix double fclose() on do_write(fd, xxx) failure

cppcheck reported:
[util/header.c:983]: (error) Used file that is not opened.

Thanks to Arnaldo Carvalho de Melo for pointing out that
fclose(NULL) is undefined behavior -> protect against it.
Signed-off-by: NThomas Jarosch <thomas.jarosch@intra2net.com>
Link: http://lkml.kernel.org/r/1751778.SZQB4fNdIh@stormSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
上级 fdae6373
......@@ -955,6 +955,7 @@ static int write_topo_node(int fd, int node)
}
fclose(fp);
fp = NULL;
ret = do_write(fd, &mem_total, sizeof(u64));
if (ret)
......@@ -981,6 +982,7 @@ static int write_topo_node(int fd, int node)
ret = do_write_string(fd, buf);
done:
free(buf);
if (fp)
fclose(fp);
return ret;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册