提交 51e911e2 编写于 作者: J Julia Lawall 提交者: Linus Torvalds

drivers/spi: move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Acked-by: NDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
上级 ee9c1fbf
...@@ -1561,11 +1561,12 @@ static int __init pxa2xx_spi_probe(struct platform_device *pdev) ...@@ -1561,11 +1561,12 @@ static int __init pxa2xx_spi_probe(struct platform_device *pdev)
static int pxa2xx_spi_remove(struct platform_device *pdev) static int pxa2xx_spi_remove(struct platform_device *pdev)
{ {
struct driver_data *drv_data = platform_get_drvdata(pdev); struct driver_data *drv_data = platform_get_drvdata(pdev);
struct ssp_device *ssp = drv_data->ssp; struct ssp_device *ssp;
int status = 0; int status = 0;
if (!drv_data) if (!drv_data)
return 0; return 0;
ssp = drv_data->ssp;
/* Remove the queue */ /* Remove the queue */
status = destroy_queue(drv_data); status = destroy_queue(drv_data);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册