From 4694153c252a6ae19704b5bb66466050256395a4 Mon Sep 17 00:00:00 2001 From: Arnaldo Carvalho de Melo Date: Tue, 10 Aug 2010 15:50:07 -0300 Subject: [PATCH] perf ui hist browser: Fixup key bindings To match what is shown when '?' or 'H' is pressed, i.e. the keybind help window. Cc: Frederic Weisbecker Cc: Mike Galbraith Cc: Peter Zijlstra Cc: Stephane Eranian LKML-Reference: Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/ui/browsers/hists.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tools/perf/util/ui/browsers/hists.c b/tools/perf/util/ui/browsers/hists.c index dd512b73b015..dafdf6775d77 100644 --- a/tools/perf/util/ui/browsers/hists.c +++ b/tools/perf/util/ui/browsers/hists.c @@ -215,12 +215,12 @@ static int hist_browser__run(struct hist_browser *self, const char *title, "Press '?' for help on key bindings") < 0) return -1; - newtFormAddHotKey(self->b.form, 'A'); newtFormAddHotKey(self->b.form, 'a'); newtFormAddHotKey(self->b.form, '?'); newtFormAddHotKey(self->b.form, 'h'); - newtFormAddHotKey(self->b.form, 'H'); newtFormAddHotKey(self->b.form, 'd'); + newtFormAddHotKey(self->b.form, 'D'); + newtFormAddHotKey(self->b.form, 't'); newtFormAddHotKey(self->b.form, NEWT_KEY_LEFT); newtFormAddHotKey(self->b.form, NEWT_KEY_RIGHT); @@ -232,7 +232,7 @@ static int hist_browser__run(struct hist_browser *self, const char *title, if (es->reason != NEWT_EXIT_HOTKEY) break; switch (es->u.key) { - case 'd': { /* Debug */ + case 'D': { /* Debug */ static int seq; struct hist_entry *h = rb_entry(self->b.top, struct hist_entry, rb_node); @@ -771,18 +771,17 @@ int hists__browse(struct hists *self, const char *helpline, const char *ev_name) default:; } - key = toupper(key); switch (key) { - case 'A': + case 'a': if (browser->selection->map == NULL && browser->selection->map->dso->annotate_warned) continue; goto do_annotate; - case 'D': + case 'd': goto zoom_dso; - case 'T': + case 't': goto zoom_thread; - case 'H': + case 'h': case '?': do_help: ui__help_window("-> Zoom into DSO/Threads & Annotate current symbol\n" -- GitLab