From 4524c1aba5449d3519d1545f8106811eb73fc72c Mon Sep 17 00:00:00 2001 From: Michael Krufky <mkrufky@linuxtv.org> Date: Mon, 22 Oct 2007 18:15:39 -0300 Subject: [PATCH] V4L/DVB (6445): tuner-core: improve comments inside function fe_release() Explain who is responsible for freeing analog_demod_priv Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> --- drivers/media/video/tuner-core.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c index 1e9c9755dec2..88db8b33c864 100644 --- a/drivers/media/video/tuner-core.c +++ b/drivers/media/video/tuner-core.c @@ -103,7 +103,15 @@ static void fe_release(struct dvb_frontend *fe) fe->ops.tuner_ops.release(fe); fe->ops.analog_demod_ops = NULL; - /* DO NOT kfree(t->fe.analog_demod_priv) */ + + /* DO NOT kfree(fe->analog_demod_priv) + * + * If we are in this function, analog_demod_priv contains a pointer + * to struct tuner *t. This will be kfree'd in tuner_detach(). + * + * Otherwise, fe->ops.analog_demod_ops->release will + * handle the cleanup for analog demodulator modules. + */ fe->analog_demod_priv = NULL; } -- GitLab