提交 3e2cd91a 编写于 作者: Z Zefan Li 提交者: Tejun Heo

cgroup: fix missing unlock in cgroup_release_agent()

The patch 971ff493: "cgroup: use a per-cgroup work for release
agent" from Sep 18, 2014, leads to the following static checker
warning:

	kernel/cgroup.c:5310 cgroup_release_agent()
	warn: 'mutex:&cgroup_mutex' is sometimes locked here and sometimes unlocked.
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NZefan Li <lizefan@huawei.com>
Signed-off-by: NTejun Heo <tj@kernel.org>
上级 a25eb52e
...@@ -5291,7 +5291,10 @@ static void cgroup_release_agent(struct work_struct *work) ...@@ -5291,7 +5291,10 @@ static void cgroup_release_agent(struct work_struct *work)
mutex_unlock(&cgroup_mutex); mutex_unlock(&cgroup_mutex);
call_usermodehelper(argv[0], argv, envp, UMH_WAIT_EXEC); call_usermodehelper(argv[0], argv, envp, UMH_WAIT_EXEC);
goto out_free;
out: out:
mutex_unlock(&cgroup_mutex);
out_free:
kfree(agentbuf); kfree(agentbuf);
kfree(pathbuf); kfree(pathbuf);
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册