From 30ecb936cbcd83e3735625ac63e1b4466546f5fe Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Tue, 28 Aug 2012 18:38:58 -0300 Subject: [PATCH] [media] uvcvideo: Return -EACCES when trying to access a read/write-only control The proper return code according to the V4L2 specification is -EACCES, not -EINVAL. Signed-off-by: Laurent Pinchart Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/uvc/uvc_ctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index 7879d306f1fc..3e0b66efc9ba 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -927,7 +927,7 @@ static int __uvc_ctrl_get(struct uvc_video_chain *chain, int ret; if ((ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR) == 0) - return -EINVAL; + return -EACCES; if (!ctrl->loaded) { ret = uvc_query_ctrl(chain->dev, UVC_GET_CUR, ctrl->entity->id, @@ -1435,7 +1435,7 @@ int uvc_ctrl_set(struct uvc_video_chain *chain, if (ctrl == NULL) return -ENOENT; if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR)) - return -EINVAL; + return -EACCES; /* Clamp out of range values. */ switch (mapping->v4l2_type) { -- GitLab