From 159b095628851966b5fbf2637b0c40709911ca88 Mon Sep 17 00:00:00 2001 From: Al Viro Date: Sat, 15 Apr 2017 15:58:56 -0400 Subject: [PATCH] make sure that fchdir() won't accept referral points, etc. Signed-off-by: Al Viro --- fs/open.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/open.c b/fs/open.c index 949cef29c3bb..9f4bbd7cc51a 100644 --- a/fs/open.c +++ b/fs/open.c @@ -459,20 +459,17 @@ SYSCALL_DEFINE1(chdir, const char __user *, filename) SYSCALL_DEFINE1(fchdir, unsigned int, fd) { struct fd f = fdget_raw(fd); - struct inode *inode; - int error = -EBADF; + int error; error = -EBADF; if (!f.file) goto out; - inode = file_inode(f.file); - error = -ENOTDIR; - if (!S_ISDIR(inode->i_mode)) + if (!d_can_lookup(f.file->f_path.dentry)) goto out_putf; - error = inode_permission(inode, MAY_EXEC | MAY_CHDIR); + error = inode_permission(file_inode(f.file), MAY_EXEC | MAY_CHDIR); if (!error) set_fs_pwd(current->fs, &f.file->f_path); out_putf: -- GitLab