提交 14420bd0 编写于 作者: V Ville Syrjälä 提交者: Daniel Vetter

drm/i915: Assert dpll running in intel_crtc_load_lut() on pre-PCH platforms

Adding more context from Ville's reply to Rodrigo's question why we
need this:

"The spec says that on some hardware you need to PLL running before you
can poke at the palette registers. I didn't actually try to anger the
hardware so I'm not really sure what would happen otherwise, but IIRC
Jesse said something about a hard system hang..."

And generally documenting such ordering constraints with asserts is
Just Good.
Signed-off-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: NRodrigo Vivi <rodrigo.vivi@gmail.com>
[danvet: Spruce up the commit message a lot.]
Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
上级 20674eef
...@@ -6311,6 +6311,9 @@ void intel_crtc_load_lut(struct drm_crtc *crtc) ...@@ -6311,6 +6311,9 @@ void intel_crtc_load_lut(struct drm_crtc *crtc)
if (!crtc->enabled || !intel_crtc->active) if (!crtc->enabled || !intel_crtc->active)
return; return;
if (!HAS_PCH_SPLIT(dev_priv->dev))
assert_pll_enabled(dev_priv, pipe);
/* use legacy palette for Ironlake */ /* use legacy palette for Ironlake */
if (HAS_PCH_SPLIT(dev)) if (HAS_PCH_SPLIT(dev))
palreg = LGC_PALETTE(pipe); palreg = LGC_PALETTE(pipe);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册