From 0001344105054ed6c09184db96c1b04eb882fdd0 Mon Sep 17 00:00:00 2001 From: Grissiom Date: Thu, 17 Jan 2013 16:00:19 +0800 Subject: [PATCH] more deterministic on timer If two timer will timeout at the same tick, the one started later will be called later. I've tested the patch on simulator and it _seems_ OK. Reported-by: xdzy on the forum and delin17 --- src/timer.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/timer.c b/src/timer.c index a1699dad6..2a27d9d9a 100644 --- a/src/timer.c +++ b/src/timer.c @@ -273,12 +273,18 @@ rt_err_t rt_timer_start(rt_timer_t timer) for (n = timer_list->next; n != timer_list; n = n->next) { t = rt_list_entry(n, struct rt_timer, list); - + /* * It supposes that the new tick shall less than the half duration of - * tick max. + * tick max. And if we have two timers that timeout at the same time, + * it's prefered that the timer inserted early get called early. */ - if ((t->timeout_tick - timer->timeout_tick) < RT_TICK_MAX / 2) + if ((t->timeout_tick - timer->timeout_tick) == 0) + { + rt_list_insert_after(n, &(timer->list)); + break; + } + else if ((t->timeout_tick - timer->timeout_tick) < RT_TICK_MAX / 2) { rt_list_insert_before(n, &(timer->list)); break; -- GitLab