提交 264ac41c 编写于 作者: A Anthony Liguori

Merge remote-tracking branch 'bonzini/nbd-next' into staging

* bonzini/nbd-next:
  nbd-server-add: Fix the default for 'writable'
  nbd: fix use of two uninitialized bytes when connecting to a named export
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>
...@@ -99,7 +99,7 @@ void qmp_nbd_server_add(const char *device, bool has_writable, bool writable, ...@@ -99,7 +99,7 @@ void qmp_nbd_server_add(const char *device, bool has_writable, bool writable,
} }
if (!has_writable) { if (!has_writable) {
writable = true; writable = false;
} }
if (bdrv_is_read_only(bs)) { if (bdrv_is_read_only(bs)) {
writable = false; writable = false;
......
...@@ -397,6 +397,7 @@ static int nbd_send_negotiate(NBDClient *client) ...@@ -397,6 +397,7 @@ static int nbd_send_negotiate(NBDClient *client)
rc = -EINVAL; rc = -EINVAL;
TRACE("Beginning negotiation."); TRACE("Beginning negotiation.");
memset(buf, 0, sizeof(buf));
memcpy(buf, "NBDMAGIC", 8); memcpy(buf, "NBDMAGIC", 8);
if (client->exp) { if (client->exp) {
assert ((client->exp->nbdflags & ~65535) == 0); assert ((client->exp->nbdflags & ~65535) == 0);
...@@ -406,7 +407,6 @@ static int nbd_send_negotiate(NBDClient *client) ...@@ -406,7 +407,6 @@ static int nbd_send_negotiate(NBDClient *client)
} else { } else {
cpu_to_be64w((uint64_t*)(buf + 8), NBD_OPTS_MAGIC); cpu_to_be64w((uint64_t*)(buf + 8), NBD_OPTS_MAGIC);
} }
memset(buf + 28, 0, 124);
if (client->exp) { if (client->exp) {
if (write_sync(csock, buf, sizeof(buf)) != sizeof(buf)) { if (write_sync(csock, buf, sizeof(buf)) != sizeof(buf)) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册