From efdc77bce6eb7ab3d0ad801a2b7bdb1037807d7a Mon Sep 17 00:00:00 2001 From: yah01 Date: Wed, 8 Mar 2023 18:53:51 +0800 Subject: [PATCH] Fix not fill timestamp when use collection created ts (#22629) Signed-off-by: yah01 --- internal/datacoord/handler.go | 6 +++++- internal/datacoord/meta.go | 1 + internal/datacoord/server.go | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/internal/datacoord/handler.go b/internal/datacoord/handler.go index ce1208e86..13dc79bfd 100644 --- a/internal/datacoord/handler.go +++ b/internal/datacoord/handler.go @@ -280,7 +280,11 @@ func (h *ServerHandler) GetChannelSeekPosition(channel *channel, partitionID Uni } func getCollectionStartPosition(channel string, collectionInfo *collectionInfo) *msgpb.MsgPosition { - return toMsgPosition(channel, collectionInfo.StartPositions) + position := toMsgPosition(channel, collectionInfo.StartPositions) + if position != nil { + position.Timestamp = collectionInfo.CreatedAt + } + return position } func toMsgPosition(channel string, startPositions []*commonpb.KeyDataPair) *msgpb.MsgPosition { diff --git a/internal/datacoord/meta.go b/internal/datacoord/meta.go index 81aa15a18..2bd49ad82 100644 --- a/internal/datacoord/meta.go +++ b/internal/datacoord/meta.go @@ -76,6 +76,7 @@ type collectionInfo struct { Partitions []int64 StartPositions []*commonpb.KeyDataPair Properties map[string]string + CreatedAt Timestamp } // NewMeta creates meta from provided `kv.TxnKV` diff --git a/internal/datacoord/server.go b/internal/datacoord/server.go index 23180f27c..78b59ba56 100644 --- a/internal/datacoord/server.go +++ b/internal/datacoord/server.go @@ -1007,6 +1007,7 @@ func (s *Server) loadCollectionFromRootCoord(ctx context.Context, collectionID i Partitions: presp.PartitionIDs, StartPositions: resp.GetStartPositions(), Properties: properties, + CreatedAt: resp.GetCreatedTimestamp(), } s.meta.AddCollection(collInfo) return nil -- GitLab