From 92eff1565cb774b744fbc177d38939eed5c81038 Mon Sep 17 00:00:00 2001 From: Bingyi Sun Date: Mon, 6 Dec 2021 17:25:35 +0800 Subject: [PATCH] Fix unlocked mutex in rootcoord (#12772) issue: #12297 Signed-off-by: sunby Co-authored-by: sunby --- internal/rootcoord/dml_channels.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/internal/rootcoord/dml_channels.go b/internal/rootcoord/dml_channels.go index fabbf9298..e94aa5712 100644 --- a/internal/rootcoord/dml_channels.go +++ b/internal/rootcoord/dml_channels.go @@ -102,6 +102,7 @@ func (d *dmlChannels) broadcast(chanNames []string, pack *msgstream.MsgPack) err if dms.refcnt > 0 { if err := dms.ms.Broadcast(pack); err != nil { log.Error("Broadcast failed", zap.String("chanName", chanName)) + dms.mutex.RUnlock() return err } } @@ -125,6 +126,7 @@ func (d *dmlChannels) broadcastMark(chanNames []string, pack *msgstream.MsgPack) ids, err := dms.ms.BroadcastMark(pack) if err != nil { log.Error("BroadcastMark failed", zap.String("chanName", chanName)) + dms.mutex.RUnlock() return result, err } for cn, idList := range ids { -- GitLab