From 6e521dd4b307aac21de9e886ac8d1bc604c376bf Mon Sep 17 00:00:00 2001 From: Jiquan Long Date: Wed, 4 Jan 2023 20:33:35 +0800 Subject: [PATCH] Optimize GetLoadingProgress to save RPC (#21493) Signed-off-by: longjiquan --- internal/proxy/impl.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/internal/proxy/impl.go b/internal/proxy/impl.go index 8d98f1acb..29699bfee 100644 --- a/internal/proxy/impl.go +++ b/internal/proxy/impl.go @@ -1460,12 +1460,6 @@ func (node *Proxy) GetLoadingProgress(ctx context.Context, request *milvuspb.Get return getErrResponse(err), nil } - if statesResp, err := node.queryCoord.GetComponentStates(ctx); err != nil { - return getErrResponse(err), nil - } else if statesResp.State == nil || statesResp.State.StateCode != commonpb.StateCode_Healthy { - return getErrResponse(fmt.Errorf("the querycoord server isn't healthy, state: %v", statesResp.State)), nil - } - msgBase := commonpbutil.NewMsgBase( commonpbutil.WithMsgType(commonpb.MsgType_SystemInfo), commonpbutil.WithMsgID(0), @@ -1537,6 +1531,8 @@ func (node *Proxy) GetLoadState(ctx context.Context, request *milvuspb.GetLoadSt return getErrResponse(err), nil } + // TODO(longjiquan): https://github.com/milvus-io/milvus/issues/21485, Remove `GetComponentStates` after error code + // is ready to distinguish case whether the querycoord is not healthy or the collection is not even loaded. if statesResp, err := node.queryCoord.GetComponentStates(ctx); err != nil { return getErrResponse(err), nil } else if statesResp.State == nil || statesResp.State.StateCode != commonpb.StateCode_Healthy { -- GitLab