From 4f71fff388fb0896525675baf15aa011b55ba4df Mon Sep 17 00:00:00 2001 From: Jiquan Long Date: Tue, 4 Jan 2022 10:19:18 +0800 Subject: [PATCH] Fix panic when close IndexCoord (#14611) Signed-off-by: dragondriver --- internal/indexcoord/index_coord.go | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/internal/indexcoord/index_coord.go b/internal/indexcoord/index_coord.go index 953935434..a8f062363 100644 --- a/internal/indexcoord/index_coord.go +++ b/internal/indexcoord/index_coord.go @@ -291,9 +291,18 @@ func (i *IndexCoord) Stop() error { // https://github.com/milvus-io/milvus/issues/12282 i.UpdateStateCode(internalpb.StateCode_Abnormal) - i.loopCancel() - i.sched.Close() + if i.loopCancel != nil { + i.loopCancel() + log.Info("cancel the loop of IndexCoord") + } + + if i.sched != nil { + i.sched.Close() + log.Info("close the task scheduler of IndexCoord") + } + i.loopWg.Wait() + for _, cb := range i.closeCallbacks { cb() } -- GitLab