diff --git a/cmd/components/data_coord.go b/cmd/components/data_coord.go index f9c0a56239eea0fc50a438c3ae35d6a21c6e7e21..2e556242c3a111153ef2192030e8003df5ebac1c 100644 --- a/cmd/components/data_coord.go +++ b/cmd/components/data_coord.go @@ -25,6 +25,7 @@ import ( "github.com/milvus-io/milvus/internal/util/dependency" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/util/typeutil" + "go.uber.org/zap" ) // DataCoord implements grpc server of DataCoord server @@ -46,6 +47,7 @@ func NewDataCoord(ctx context.Context, factory dependency.Factory) (*DataCoord, // Run starts service func (s *DataCoord) Run() error { if err := s.svr.Run(); err != nil { + log.Error("DataCoord starts error", zap.Error(err)) return err } log.Debug("DataCoord successfully started") diff --git a/cmd/components/data_node.go b/cmd/components/data_node.go index 2802d4a0150200d90df0e1ba742b83e2e0ea5bdd..734d1e1686a54e1cc51266028195aac89d54f849 100644 --- a/cmd/components/data_node.go +++ b/cmd/components/data_node.go @@ -25,6 +25,7 @@ import ( "github.com/milvus-io/milvus/internal/util/dependency" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/util/typeutil" + "go.uber.org/zap" ) // DataNode implements DataNode grpc server @@ -49,7 +50,8 @@ func NewDataNode(ctx context.Context, factory dependency.Factory) (*DataNode, er // Run starts service func (d *DataNode) Run() error { if err := d.svr.Run(); err != nil { - panic(err) + log.Error("DataNode starts error", zap.Error(err)) + return err } log.Debug("Datanode successfully started") return nil diff --git a/cmd/components/index_node.go b/cmd/components/index_node.go index 6b0ba5deff58cdf46a2c02c7fcca6fd60b4e30c3..9c874a8801bacedf4ac1ffae1b94924071c64ed5 100644 --- a/cmd/components/index_node.go +++ b/cmd/components/index_node.go @@ -25,6 +25,7 @@ import ( "github.com/milvus-io/milvus/internal/util/dependency" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/util/typeutil" + "go.uber.org/zap" ) // IndexNode implements IndexNode grpc server @@ -48,6 +49,7 @@ func NewIndexNode(ctx context.Context, factory dependency.Factory) (*IndexNode, // Run starts service func (n *IndexNode) Run() error { if err := n.svr.Run(); err != nil { + log.Error("IndexNode starts error", zap.Error(err)) return err } log.Debug("IndexNode successfully started") diff --git a/cmd/components/proxy.go b/cmd/components/proxy.go index 8eb944c254aba8f0e1fce51e334c5e6919e30438..37bb9ef13873b5ac95236a92881faade395d75d6 100644 --- a/cmd/components/proxy.go +++ b/cmd/components/proxy.go @@ -19,14 +19,13 @@ package components import ( "context" - "go.uber.org/zap" - "github.com/milvus-io/milvus-proto/go-api/v2/commonpb" "github.com/milvus-io/milvus-proto/go-api/v2/milvuspb" grpcproxy "github.com/milvus-io/milvus/internal/distributed/proxy" "github.com/milvus-io/milvus/internal/util/dependency" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/util/typeutil" + "go.uber.org/zap" ) // Proxy implements Proxy grpc server @@ -50,7 +49,7 @@ func NewProxy(ctx context.Context, factory dependency.Factory) (*Proxy, error) { // Run starts service func (n *Proxy) Run() error { if err := n.svr.Run(); err != nil { - log.Warn("failed to start Proxy", zap.Error(err)) + log.Error("Proxy starts error", zap.Error(err)) return err } log.Info("Proxy successfully started") diff --git a/cmd/components/query_coord.go b/cmd/components/query_coord.go index 4e81ce6bfbd618ee4f5f5c03b7c477906b45d07a..3c893ad6976314f155aa1ee356c97ae9af73fa59 100644 --- a/cmd/components/query_coord.go +++ b/cmd/components/query_coord.go @@ -19,14 +19,14 @@ package components import ( "context" + "go.uber.org/zap" + "github.com/milvus-io/milvus-proto/go-api/v2/commonpb" "github.com/milvus-io/milvus-proto/go-api/v2/milvuspb" + grpcquerycoord "github.com/milvus-io/milvus/internal/distributed/querycoord" "github.com/milvus-io/milvus/internal/util/dependency" - "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/util/typeutil" - - grpcquerycoord "github.com/milvus-io/milvus/internal/distributed/querycoord" ) // QueryCoord implements QueryCoord grpc server @@ -39,7 +39,7 @@ type QueryCoord struct { func NewQueryCoord(ctx context.Context, factory dependency.Factory) (*QueryCoord, error) { svr, err := grpcquerycoord.NewServer(ctx, factory) if err != nil { - panic(err) + return nil, err } return &QueryCoord{ @@ -51,7 +51,8 @@ func NewQueryCoord(ctx context.Context, factory dependency.Factory) (*QueryCoord // Run starts service func (qs *QueryCoord) Run() error { if err := qs.svr.Run(); err != nil { - panic(err) + log.Error("QueryCoord starts error", zap.Error(err)) + return err } log.Debug("QueryCoord successfully started") return nil diff --git a/cmd/components/query_node.go b/cmd/components/query_node.go index d686eaa7d61da45953f45324a6a4f0af9c37803b..f44cffa8ce1e0b919c19b7ac078e6c9704e35224 100644 --- a/cmd/components/query_node.go +++ b/cmd/components/query_node.go @@ -19,14 +19,14 @@ package components import ( "context" + "go.uber.org/zap" + "github.com/milvus-io/milvus-proto/go-api/v2/commonpb" "github.com/milvus-io/milvus-proto/go-api/v2/milvuspb" + grpcquerynode "github.com/milvus-io/milvus/internal/distributed/querynode" "github.com/milvus-io/milvus/internal/util/dependency" - "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/util/typeutil" - - grpcquerynode "github.com/milvus-io/milvus/internal/distributed/querynode" ) // QueryNode implements QueryNode grpc server @@ -52,7 +52,8 @@ func NewQueryNode(ctx context.Context, factory dependency.Factory) (*QueryNode, // Run starts service func (q *QueryNode) Run() error { if err := q.svr.Run(); err != nil { - panic(err) + log.Error("QueryNode starts error", zap.Error(err)) + return err } log.Debug("QueryNode successfully started") return nil diff --git a/cmd/components/root_coord.go b/cmd/components/root_coord.go index c65bdf10be4c4d2492fceaab2c0d7ac978ab51a0..0201558d097a3a4f4181d5a29aea4b6bf649cce0 100644 --- a/cmd/components/root_coord.go +++ b/cmd/components/root_coord.go @@ -25,7 +25,6 @@ import ( "github.com/milvus-io/milvus/internal/util/dependency" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/util/typeutil" - "go.uber.org/zap" )