From 019f18ddf974c258bb02e00aa0f9f78e0699459f Mon Sep 17 00:00:00 2001
From: dragondriver <jiquan.long@zilliz.com>
Date: Sun, 26 Sep 2021 17:50:07 +0800
Subject: [PATCH] Expose created time and updated time to datacoord metrics
 (#8172)

Signed-off-by: dragondriver <jiquan.long@zilliz.com>
---
 internal/datacoord/metrics_info.go | 5 +++--
 internal/datacoord/param_table.go  | 4 ++++
 internal/datacoord/server.go       | 5 +++++
 3 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/internal/datacoord/metrics_info.go b/internal/datacoord/metrics_info.go
index 8330efad6..48390af92 100644
--- a/internal/datacoord/metrics_info.go
+++ b/internal/datacoord/metrics_info.go
@@ -99,8 +99,9 @@ func (s *Server) getDataCoordMetrics() metricsinfo.DataCoordInfos {
 				SystemVersion: os.Getenv(metricsinfo.GitCommitEnvKey),
 				DeployMode:    os.Getenv(metricsinfo.DeployModeEnvKey),
 			},
-			// TODO(dragondriver): CreatedTime & UpdatedTime, easy but time-costing
-			Type: typeutil.DataCoordRole,
+			CreatedTime: Params.CreatedTime.String(),
+			UpdatedTime: Params.UpdatedTime.String(),
+			Type:        typeutil.DataCoordRole,
 		},
 		SystemConfigurations: metricsinfo.DataCoordConfiguration{
 			SegmentMaxSize: Params.SegmentMaxSize,
diff --git a/internal/datacoord/param_table.go b/internal/datacoord/param_table.go
index 3fb803904..15463b575 100644
--- a/internal/datacoord/param_table.go
+++ b/internal/datacoord/param_table.go
@@ -16,6 +16,7 @@ import (
 	"strconv"
 	"strings"
 	"sync"
+	"time"
 
 	"github.com/milvus-io/milvus/internal/log"
 
@@ -59,6 +60,9 @@ type ParamTable struct {
 	SegmentInfoChannelName    string
 	DataCoordSubscriptionName string
 
+	CreatedTime time.Time
+	UpdatedTime time.Time
+
 	Log log.Config
 }
 
diff --git a/internal/datacoord/server.go b/internal/datacoord/server.go
index 2c54a4f5e..704b4c89d 100644
--- a/internal/datacoord/server.go
+++ b/internal/datacoord/server.go
@@ -236,8 +236,13 @@ func (s *Server) Start() error {
 	if err := helper.Execute(); err != nil {
 		return err
 	}
+
+	Params.CreatedTime = time.Now()
+	Params.UpdatedTime = time.Now()
+
 	atomic.StoreInt64(&s.isServing, ServerStateHealthy)
 	log.Debug("dataCoordinator startup success")
+
 	return nil
 }
 
-- 
GitLab