diff --git a/internal/datacoord/metrics_info.go b/internal/datacoord/metrics_info.go index 8330efad6f839bae3e26b83896c62a0d84c1d978..48390af929e90152f0dcb91fd14da07ab0f06ed0 100644 --- a/internal/datacoord/metrics_info.go +++ b/internal/datacoord/metrics_info.go @@ -99,8 +99,9 @@ func (s *Server) getDataCoordMetrics() metricsinfo.DataCoordInfos { SystemVersion: os.Getenv(metricsinfo.GitCommitEnvKey), DeployMode: os.Getenv(metricsinfo.DeployModeEnvKey), }, - // TODO(dragondriver): CreatedTime & UpdatedTime, easy but time-costing - Type: typeutil.DataCoordRole, + CreatedTime: Params.CreatedTime.String(), + UpdatedTime: Params.UpdatedTime.String(), + Type: typeutil.DataCoordRole, }, SystemConfigurations: metricsinfo.DataCoordConfiguration{ SegmentMaxSize: Params.SegmentMaxSize, diff --git a/internal/datacoord/param_table.go b/internal/datacoord/param_table.go index 3fb8039045ecb36a5e79a9d8908d33ec932bdc7d..15463b575b067b1f9ea230e28de961224405b489 100644 --- a/internal/datacoord/param_table.go +++ b/internal/datacoord/param_table.go @@ -16,6 +16,7 @@ import ( "strconv" "strings" "sync" + "time" "github.com/milvus-io/milvus/internal/log" @@ -59,6 +60,9 @@ type ParamTable struct { SegmentInfoChannelName string DataCoordSubscriptionName string + CreatedTime time.Time + UpdatedTime time.Time + Log log.Config } diff --git a/internal/datacoord/server.go b/internal/datacoord/server.go index 2c54a4f5eb2f973ba19fe960ed9f5455a76b7300..704b4c89da5d29dcd975cc67bc0f08ff6b454636 100644 --- a/internal/datacoord/server.go +++ b/internal/datacoord/server.go @@ -236,8 +236,13 @@ func (s *Server) Start() error { if err := helper.Execute(); err != nil { return err } + + Params.CreatedTime = time.Now() + Params.UpdatedTime = time.Now() + atomic.StoreInt64(&s.isServing, ServerStateHealthy) log.Debug("dataCoordinator startup success") + return nil }