From 9f9c4591ab4d1315126ab67423004d073c57743b Mon Sep 17 00:00:00 2001 From: "yong.you" Date: Tue, 22 Oct 2013 15:09:24 +0800 Subject: [PATCH] delete unused code --- .../cat/consumer/RealtimeConsumer.java | 1 - .../cat/report/task/spi/ReportFacade.java | 26 +++++++------------ 2 files changed, 9 insertions(+), 18 deletions(-) diff --git a/cat-consumer/src/main/java/com/dianping/cat/consumer/RealtimeConsumer.java b/cat-consumer/src/main/java/com/dianping/cat/consumer/RealtimeConsumer.java index c468c691b..1e2e89b79 100644 --- a/cat-consumer/src/main/java/com/dianping/cat/consumer/RealtimeConsumer.java +++ b/cat-consumer/src/main/java/com/dianping/cat/consumer/RealtimeConsumer.java @@ -345,7 +345,6 @@ public class RealtimeConsumer extends ContainerHolder implements MessageConsumer } else if (value > 0) { startPeriod(value); } else { - endPeriod(-value); // last period is over,make it asynchronous Threads.forGroup("Cat").start(new EndTaskThread(-value)); } diff --git a/cat-home/src/main/java/com/dianping/cat/report/task/spi/ReportFacade.java b/cat-home/src/main/java/com/dianping/cat/report/task/spi/ReportFacade.java index 0dc447d32..ff53635b3 100644 --- a/cat-home/src/main/java/com/dianping/cat/report/task/spi/ReportFacade.java +++ b/cat-home/src/main/java/com/dianping/cat/report/task/spi/ReportFacade.java @@ -42,14 +42,6 @@ import com.dianping.cat.report.task.utilization.UtilizationReportBuilder; public class ReportFacade implements LogEnabled, Initializable { - public static final int TYPE_HOUR = ReportType.HOUR; - - public static final int TYPE_DAILY = ReportType.DAILY; - - public static final int TYPE_WEEK = ReportType.WEEK; - - public static final int TYPE_MONTH = ReportType.MONTH; - @Inject private EventReportBuilder m_eventBuilder; @@ -84,10 +76,10 @@ public class ReportFacade implements LogEnabled, Initializable { private DependencyReportBuilder m_dependendcyReportBuilder; @Inject - private MetricBaselineReportBuilder m_metricBaselineReportBuilder; - - @Inject - private ABTestReportBuilder m_abtestReportBuilder; + private MetricBaselineReportBuilder m_metricBaselineReportBuilder; + + @Inject + private ABTestReportBuilder m_abtestReportBuilder; @Inject private HeavyReportBuilder m_heavyReportBuilder; @@ -120,13 +112,13 @@ public class ReportFacade implements LogEnabled, Initializable { } else { boolean result = false; - if (type == TYPE_HOUR) { + if (type == ReportType.HOUR) { result = reportBuilder.buildHourlyTask(reportName, reportDomain, reportPeriod); - } else if (type == TYPE_DAILY) { + } else if (type == ReportType.DAILY) { result = reportBuilder.buildDailyTask(reportName, reportDomain, reportPeriod); - } else if (type == TYPE_WEEK) { + } else if (type == ReportType.WEEK) { result = reportBuilder.buildWeeklyTask(reportName, reportDomain, reportPeriod); - } else if (type == TYPE_MONTH) { + } else if (type == ReportType.MONTH) { result = reportBuilder.buildMonthlyTask(reportName, reportDomain, reportPeriod); } if (result) { @@ -164,7 +156,7 @@ public class ReportFacade implements LogEnabled, Initializable { m_reportBuilders.put(StateAnalyzer.ID, m_stateReportBuilder); m_reportBuilders.put(DependencyAnalyzer.ID, m_dependendcyReportBuilder); m_reportBuilders.put(MetricAnalyzer.ID, m_metricBaselineReportBuilder); - + m_reportBuilders.put(Constants.REPORT_BUG, m_bugReportBuilder); m_reportBuilders.put(Constants.REPORT_SERVICE, m_serviceReportBuilder); m_reportBuilders.put(Constants.REPORT_HEAVY, m_heavyReportBuilder); -- GitLab