From 3d6fe33e2daf3879900a7700d4e9b6da1487b611 Mon Sep 17 00:00:00 2001 From: Megvii Engine Team Date: Thu, 2 Dec 2021 16:30:40 +0800 Subject: [PATCH] Revert "fix(imperative): check async error when getting value" This reverts commit 3945a9bfa2b27e8f47f6ee00184f69f3d992bb22 GitOrigin-RevId: ec6d3574b2286f35778933e29b03c3742dbd2117 --- imperative/python/megengine/functional/vision.py | 1 - imperative/python/src/tensor.cpp | 4 ---- imperative/src/impl/interpreter/interpreter_impl.cpp | 6 ------ 3 files changed, 11 deletions(-) diff --git a/imperative/python/megengine/functional/vision.py b/imperative/python/megengine/functional/vision.py index 0fd905ee4..7ab6bf244 100644 --- a/imperative/python/megengine/functional/vision.py +++ b/imperative/python/megengine/functional/vision.py @@ -420,7 +420,6 @@ def warp_affine( Here all available options for params are listed, however it does not mean that you can use all the combinations. On different platforms, different combinations are supported. - ``warp_affine`` only support forward inference, Please refer to ``warp_perspective`` if backward is needed. """ conv_format = _config._get_actual_op_param(format, _config.__conv_format) diff --git a/imperative/python/src/tensor.cpp b/imperative/python/src/tensor.cpp index f415f572d..87f2459d5 100644 --- a/imperative/python/src/tensor.cpp +++ b/imperative/python/src/tensor.cpp @@ -1074,10 +1074,6 @@ void init_tensor(py::module m) { []() { interpreter_for_py->sync(); CompNode::sync_all(); - CompNode::foreach ([](CompNode cn) { - auto err = cn.check_async_error(); - mgb_assert(!err, "%s", err->what()); - }); sync_py_task_q(); }, py::call_guard()); diff --git a/imperative/src/impl/interpreter/interpreter_impl.cpp b/imperative/src/impl/interpreter/interpreter_impl.cpp index e8b6fb43f..bf122982c 100644 --- a/imperative/src/impl/interpreter/interpreter_impl.cpp +++ b/imperative/src/impl/interpreter/interpreter_impl.cpp @@ -156,8 +156,6 @@ TensorInfo* ChannelImpl::put_impl(const HostTensorND& value, bool no_cache) { if (m_async_level == 0) { sync_impl(); info->desc.comp_node.sync(); - auto err = info->desc.comp_node.check_async_error(); - mgb_assert(!err, "%s", err->what()); } return info; } @@ -338,8 +336,6 @@ void ChannelImpl::dispatch_kernel( for (auto&& oup : *outputs) { auto info = reinterpret_cast(oup); info->ptr->comp_node().sync(); - auto err = info->ptr->comp_node().check_async_error(); - mgb_assert(!err, "%s", err->what()); } } } @@ -948,8 +944,6 @@ TensorPtr ChannelImpl::wait_tensor(TensorInfo* info, TensorProp prop) { }); MGB_RECORD_EVENT(TensorWaitPropFinishEvent, info->id, m_waitee_id, prop); m_waitee = nullptr; - auto err = info->ptr->comp_node().check_async_error(); - mgb_assert(!err, "%s", err->what()); return info->ptr; } -- GitLab