diff --git a/maxkey-authentications/maxkey-authentication-captcha/src/main/java/com/google/code/kaptcha/impl/Ripple.java b/maxkey-authentications/maxkey-authentication-captcha/src/main/java/com/google/code/kaptcha/impl/Ripple.java index b0a2c42970879b8d517617c04407c4365e3061d9..718b7df039d6033d337ff748f9f1f771129f8bec 100644 --- a/maxkey-authentications/maxkey-authentication-captcha/src/main/java/com/google/code/kaptcha/impl/Ripple.java +++ b/maxkey-authentications/maxkey-authentication-captcha/src/main/java/com/google/code/kaptcha/impl/Ripple.java @@ -8,7 +8,6 @@ import com.google.code.kaptcha.NoiseProducer; import com.google.code.kaptcha.util.Configurable; import com.jhlabs.image.RippleFilter; import com.jhlabs.image.TransformFilter; -import com.jhlabs.image.WaterFilter; /** * {@link WaterRipple} adds water ripple effect to an image. diff --git a/maxkey-authentications/maxkey-authentication-captcha/src/main/java/org/maxkey/autoconfigure/KaptchaAutoConfiguration.java b/maxkey-authentications/maxkey-authentication-captcha/src/main/java/org/maxkey/autoconfigure/KaptchaAutoConfiguration.java index 37ffaf074b4267db812409d9abe50b3e6e585e3c..6ce893f374bb6ec927872522c413b3e0dcd85ce2 100644 --- a/maxkey-authentications/maxkey-authentication-captcha/src/main/java/org/maxkey/autoconfigure/KaptchaAutoConfiguration.java +++ b/maxkey-authentications/maxkey-authentication-captcha/src/main/java/org/maxkey/autoconfigure/KaptchaAutoConfiguration.java @@ -56,7 +56,6 @@ public class KaptchaAutoConfiguration implements InitializingBean { @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } } diff --git a/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/authn/realm/activedirectory/ActiveDirectoryAuthenticationRealm.java b/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/authn/realm/activedirectory/ActiveDirectoryAuthenticationRealm.java index e391b50288cc7bf96bd56545131d557e6823e53f..915a57b96d11c52d2900f9c08cbd484d4b8c5873 100644 --- a/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/authn/realm/activedirectory/ActiveDirectoryAuthenticationRealm.java +++ b/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/authn/realm/activedirectory/ActiveDirectoryAuthenticationRealm.java @@ -25,11 +25,9 @@ import javax.validation.constraints.Size; import org.maxkey.authn.realm.AbstractAuthenticationRealm; import org.maxkey.authn.realm.IAuthenticationServer; import org.maxkey.entity.UserInfo; -import org.maxkey.web.WebContext; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.jdbc.core.JdbcTemplate; -import org.springframework.security.authentication.BadCredentialsException; public class ActiveDirectoryAuthenticationRealm extends AbstractAuthenticationRealm{ diff --git a/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/authn/realm/ldap/LdapAuthenticationRealm.java b/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/authn/realm/ldap/LdapAuthenticationRealm.java index a35cde81f148692166e19460bd7860ed78b422aa..fe9600d55abd53af73c0850b58bf629877978922 100644 --- a/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/authn/realm/ldap/LdapAuthenticationRealm.java +++ b/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/authn/realm/ldap/LdapAuthenticationRealm.java @@ -25,11 +25,9 @@ import javax.validation.constraints.Size; import org.maxkey.authn.realm.AbstractAuthenticationRealm; import org.maxkey.authn.realm.IAuthenticationServer; import org.maxkey.entity.UserInfo; -import org.maxkey.web.WebContext; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.jdbc.core.JdbcTemplate; -import org.springframework.security.authentication.BadCredentialsException; public class LdapAuthenticationRealm extends AbstractAuthenticationRealm{ private final static Logger _logger = LoggerFactory.getLogger(LdapAuthenticationRealm.class); diff --git a/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/autoconfigure/AuthenticationAutoConfiguration.java b/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/autoconfigure/AuthenticationAutoConfiguration.java index 2a4467be5dd1ade4e78ee21987869239924fe7ed..ce7b66bc2f30a830a6b3097d39e47a43001f975a 100644 --- a/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/autoconfigure/AuthenticationAutoConfiguration.java +++ b/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/autoconfigure/AuthenticationAutoConfiguration.java @@ -118,7 +118,6 @@ public class AuthenticationAutoConfiguration implements InitializingBean { @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } } diff --git a/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/autoconfigure/JwtAuthnAutoConfiguration.java b/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/autoconfigure/JwtAuthnAutoConfiguration.java index f748365a720fa412832753000cbda59495f82caf..346bfae1f73a71d6b8fd928727bbe3224bb86be9 100644 --- a/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/autoconfigure/JwtAuthnAutoConfiguration.java +++ b/maxkey-authentications/maxkey-authentication-core/src/main/java/org/maxkey/autoconfigure/JwtAuthnAutoConfiguration.java @@ -89,7 +89,6 @@ public class JwtAuthnAutoConfiguration implements InitializingBean { @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } } diff --git a/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/CapOtpAuthn.java b/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/CapOtpAuthn.java index fcb99f031647694bc9d50e53f378afeb537f7918..48701b0380cb054a35b408b9a806a1bcfdc50464 100644 --- a/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/CapOtpAuthn.java +++ b/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/CapOtpAuthn.java @@ -40,13 +40,11 @@ public class CapOtpAuthn extends AbstractOtpAuthn { @Override public boolean produce(UserInfo userInfo) { - // TODO Auto-generated method stub return false; } @Override public boolean validate(UserInfo userInfo, String token) { - // TODO Auto-generated method stub return false; } diff --git a/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/MobileOtpAuthn.java b/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/MobileOtpAuthn.java index 46fecdfa36976ebd9bd6978231bab077f52398ef..d95a6ffb3156a5327bb2b9589a7af3a112a301fb 100644 --- a/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/MobileOtpAuthn.java +++ b/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/MobileOtpAuthn.java @@ -30,13 +30,11 @@ public class MobileOtpAuthn extends AbstractOtpAuthn { @Override public boolean produce(UserInfo userInfo) { - // TODO Auto-generated method stub return false; } @Override public boolean validate(UserInfo userInfo, String token) { - // TODO Auto-generated method stub return false; } diff --git a/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/RsaOtpAuthn.java b/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/RsaOtpAuthn.java index 4d33edd3d51c76ae9e55c5aaeb1d4da8bca55bb0..bba7477398f602d878cf889f48a50334c285a2df 100644 --- a/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/RsaOtpAuthn.java +++ b/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/RsaOtpAuthn.java @@ -40,13 +40,11 @@ public class RsaOtpAuthn extends AbstractOtpAuthn { @Override public boolean produce(UserInfo userInfo) { - // TODO Auto-generated method stub return false; } @Override public boolean validate(UserInfo userInfo, String token) { - // TODO Auto-generated method stub return false; } diff --git a/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/SmsOtpAuthn.java b/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/SmsOtpAuthn.java index 241eeb463c15e660bbab48fad6d201de2f4f8d39..d8303d5d5ff64b17e73530b27cfd2e5bdd56311f 100644 --- a/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/SmsOtpAuthn.java +++ b/maxkey-authentications/maxkey-authentication-otp/src/main/java/org/maxkey/password/onetimepwd/impl/SmsOtpAuthn.java @@ -34,7 +34,7 @@ public class SmsOtpAuthn extends AbstractOtpAuthn { @Override public boolean produce(UserInfo userInfo) { String token = this.genToken(userInfo); - // TODO:You must add send sms code here + // You must add send sms code here logger.debug("send sms code" + token); return true; } diff --git a/maxkey-authentications/maxkey-authentication-otp/src/test/java/org/maxkey/otp/algorithm/HmacOTPTest.java b/maxkey-authentications/maxkey-authentication-otp/src/test/java/org/maxkey/otp/algorithm/HmacOTPTest.java index 88694bf048c90231e08242f93f4cd004e8e88d3c..9728d05124e9948e4bb5a32dc6dfe5c1bce5b07f 100644 --- a/maxkey-authentications/maxkey-authentication-otp/src/test/java/org/maxkey/otp/algorithm/HmacOTPTest.java +++ b/maxkey-authentications/maxkey-authentication-otp/src/test/java/org/maxkey/otp/algorithm/HmacOTPTest.java @@ -37,10 +37,8 @@ public class HmacOTPTest { try { System.out.println(HOTP.generateOTP(byteseed, 3, 6, false, -1)); } catch (InvalidKeyException e) { - // TODO Auto-generated catch block e.printStackTrace(); } catch (NoSuchAlgorithmException e) { - // TODO Auto-generated catch block e.printStackTrace(); } } diff --git a/maxkey-authentications/maxkey-authentication-otp/src/test/java/org/maxkey/otp/algorithm/TimeBasedOTPTest.java b/maxkey-authentications/maxkey-authentication-otp/src/test/java/org/maxkey/otp/algorithm/TimeBasedOTPTest.java index 0855ebc3287b7026abf23f29155a050cededae53..7682a9d5b9645e00e7ffc32e09998f2b00283d24 100644 --- a/maxkey-authentications/maxkey-authentication-otp/src/test/java/org/maxkey/otp/algorithm/TimeBasedOTPTest.java +++ b/maxkey-authentications/maxkey-authentication-otp/src/test/java/org/maxkey/otp/algorithm/TimeBasedOTPTest.java @@ -55,7 +55,6 @@ public class TimeBasedOTPTest { try { curr=df.parse(utcTime); } catch (ParseException e) { - // TODO Auto-generated catch block e.printStackTrace(); } long currentTimeSeconds = curr.getTime() / 1000; diff --git a/maxkey-authentications/maxkey-authentication-social/src/main/java/org/maxkey/autoconfigure/SocialSignOnAutoConfiguration.java b/maxkey-authentications/maxkey-authentication-social/src/main/java/org/maxkey/autoconfigure/SocialSignOnAutoConfiguration.java index 6b6f0f750314a70c19f99951c32e46c46d11b1dc..6d1f0073f53967e04d6ce8b5d58ec0a6684635b8 100644 --- a/maxkey-authentications/maxkey-authentication-social/src/main/java/org/maxkey/autoconfigure/SocialSignOnAutoConfiguration.java +++ b/maxkey-authentications/maxkey-authentication-social/src/main/java/org/maxkey/autoconfigure/SocialSignOnAutoConfiguration.java @@ -59,7 +59,6 @@ public class SocialSignOnAutoConfiguration implements InitializingBean { @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } } diff --git a/maxkey-common/src/main/java/org/maxkey/crypto/KeyPairUtil.java b/maxkey-common/src/main/java/org/maxkey/crypto/KeyPairUtil.java index c6ee0fd6dcba461a6ae5262005bfe0b9b637a984..bb5d02e67e321a06eb19920384a605ffb20db50c 100644 --- a/maxkey-common/src/main/java/org/maxkey/crypto/KeyPairUtil.java +++ b/maxkey-common/src/main/java/org/maxkey/crypto/KeyPairUtil.java @@ -206,7 +206,7 @@ public final class KeyPairUtil } else if (pubKey instanceof ECKey) { - // TODO: how to get key size from these? + // how to get key size from these? return UNKNOWN_KEY_SIZE; } @@ -236,7 +236,7 @@ public final class KeyPairUtil } else if (keyParams instanceof ECKeyParameters) { - // TODO: how to get key length from these? + // how to get key length from these? return UNKNOWN_KEY_SIZE; } diff --git a/maxkey-common/src/main/java/org/maxkey/crypto/ReciprocalUtils.java b/maxkey-common/src/main/java/org/maxkey/crypto/ReciprocalUtils.java index b85646b552ecfd02778008143f58ef482b9d1554..e08e4e01ab22fac01c11b5b76fa8aab608243ad3 100644 --- a/maxkey-common/src/main/java/org/maxkey/crypto/ReciprocalUtils.java +++ b/maxkey-common/src/main/java/org/maxkey/crypto/ReciprocalUtils.java @@ -162,7 +162,6 @@ public final class ReciprocalUtils { try { simple = new String(byteFinal, "UTF-8"); } catch (UnsupportedEncodingException e) { - // TODO Auto-generated catch block e.printStackTrace(); } return simple; diff --git a/maxkey-common/src/main/java/org/maxkey/crypto/cert/NetUtil.java b/maxkey-common/src/main/java/org/maxkey/crypto/cert/NetUtil.java index 092312c638a35d1a4323c2924ff331bd27bd0732..9960a0af4ab23750a0c7eb5e662e748792bfec57 100644 --- a/maxkey-common/src/main/java/org/maxkey/crypto/cert/NetUtil.java +++ b/maxkey-common/src/main/java/org/maxkey/crypto/cert/NetUtil.java @@ -45,10 +45,10 @@ public final class NetUtil /** Logger */ private static final Logger _logger = LoggerFactory.getLogger(NetUtil.class); - // TODO: make this configurable + // make this configurable private static final int CONNECT_TIMEOUT = 10000; - // TODO: make this configurable + // make this configurable private static final int READ_TIMEOUT = 20000; /** @@ -74,7 +74,7 @@ public final class NetUtil conn.setConnectTimeout(CONNECT_TIMEOUT); conn.setReadTimeout(READ_TIMEOUT); - // TODO: User-Agent? + // User-Agent? return conn.getInputStream(); } @@ -97,7 +97,7 @@ public final class NetUtil conn.setConnectTimeout(CONNECT_TIMEOUT); conn.setReadTimeout(READ_TIMEOUT); - // TODO: User-Agent? + // User-Agent? if (contentType != null) { diff --git a/maxkey-common/src/main/java/org/maxkey/crypto/jwt/encryption/service/JwtEncryptionAndDecryptionService.java b/maxkey-common/src/main/java/org/maxkey/crypto/jwt/encryption/service/JwtEncryptionAndDecryptionService.java index 0459701696375439652268a9eee1b7e061b0d8f3..61100f9d2c22a5457fd3ea48b1416c58e1893165 100644 --- a/maxkey-common/src/main/java/org/maxkey/crypto/jwt/encryption/service/JwtEncryptionAndDecryptionService.java +++ b/maxkey-common/src/main/java/org/maxkey/crypto/jwt/encryption/service/JwtEncryptionAndDecryptionService.java @@ -64,7 +64,7 @@ public interface JwtEncryptionAndDecryptionService { public Collection getAllEncryptionEncsSupported(); /** - * TODO add functionality for encrypting and decrypting using a specified key id. + * add functionality for encrypting and decrypting using a specified key id. * Example: public void encryptJwt(EncryptedJWT jwt, String kid); */ } diff --git a/maxkey-common/src/main/java/org/maxkey/crypto/jwt/encryption/service/impl/DefaultJwtEncryptionAndDecryptionService.java b/maxkey-common/src/main/java/org/maxkey/crypto/jwt/encryption/service/impl/DefaultJwtEncryptionAndDecryptionService.java index 18266f4a9d4e9317563c6a267550db9d69f3de45..0f707b9657e91004df0df2b1ec24d2a2f0dea0be 100644 --- a/maxkey-common/src/main/java/org/maxkey/crypto/jwt/encryption/service/impl/DefaultJwtEncryptionAndDecryptionService.java +++ b/maxkey-common/src/main/java/org/maxkey/crypto/jwt/encryption/service/impl/DefaultJwtEncryptionAndDecryptionService.java @@ -230,7 +230,7 @@ public class DefaultJwtEncryptionAndDecryptionService implements JwtEncryptionAn logger.warn("No private key for key #" + jwk.getKeyID()); } - // TODO: add support for EC keys + // add support for EC keys } else if (jwk instanceof OctetSequenceKey) { // build symmetric encrypters and decrypters diff --git a/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/JwtSigningAndValidationService.java b/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/JwtSigningAndValidationService.java index 32790ac4484cf22390b8ea42f3a7b953621ae616..452934858c8645505aa7cd7fb297c936af7549ee 100644 --- a/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/JwtSigningAndValidationService.java +++ b/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/JwtSigningAndValidationService.java @@ -77,6 +77,6 @@ public interface JwtSigningAndValidationService { public String getDefaultSignerKeyId(); /** - * TODO: method to sign a jwt using a specified algorithm and a key id + * method to sign a jwt using a specified algorithm and a key id */ } diff --git a/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/impl/DefaultJwtSigningAndValidationService.java b/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/impl/DefaultJwtSigningAndValidationService.java index 2c0b2d867eb2b2fbd528587743f32d29224451a2..f77b0b67a2f6a415b4e118d296e615e60885098e 100644 --- a/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/impl/DefaultJwtSigningAndValidationService.java +++ b/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/impl/DefaultJwtSigningAndValidationService.java @@ -99,7 +99,7 @@ public class DefaultJwtSigningAndValidationService implements JwtSigningAndValid for (JWK key : keyStore.getKeys()) { if (!Strings.isNullOrEmpty(key.getKeyID())) { // use the key ID that's built into the key itself - // TODO (#641): deal with JWK thumbprints + // (#641): deal with JWK thumbprints this.keys.put(key.getKeyID(), key); } else { // create a random key id @@ -173,7 +173,7 @@ public class DefaultJwtSigningAndValidationService implements JwtSigningAndValid } else if (jwk instanceof ECKey) { // build EC signers & verifiers - // TODO: add support for EC keys + // add support for EC keys logger.warn("EC Keys are not yet supported."); } else if (jwk instanceof OctetSequenceKey) { diff --git a/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/impl/SymmetricCacheService.java b/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/impl/SymmetricCacheService.java index 3f02ca65897ce6e0c76aab408df380e587cfc8a6..05d22a623ddc67046b31b554d113ff2057769f8f 100644 --- a/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/impl/SymmetricCacheService.java +++ b/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/impl/SymmetricCacheService.java @@ -93,7 +93,7 @@ public class SymmetricCacheService { try { String id = "SYMMETRIC-KEY"; - //TODO: + JWK jwk =null; //JWK jwk = new OctetSequenceKey(Base64URL.encode(key), KeyUse.SIGNATURE, null, null, id, null, null, null); Map keys = ImmutableMap.of(id, jwk); diff --git a/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/impl/SymmetricSigningAndValidationServiceBuilder.java b/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/impl/SymmetricSigningAndValidationServiceBuilder.java index db6e38d0cc95da429b51023ebacdc6bdc5ce657f..db47ebb0f20beedaa51d0ec99a598e854552205d 100644 --- a/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/impl/SymmetricSigningAndValidationServiceBuilder.java +++ b/maxkey-common/src/main/java/org/maxkey/crypto/jwt/signer/service/impl/SymmetricSigningAndValidationServiceBuilder.java @@ -56,7 +56,6 @@ public class SymmetricSigningAndValidationServiceBuilder { /** * Builder Symmetric Signing And Validation Service */ - //TODO: JWK jwk = null; //JWK jwk = new OctetSequenceKey(Base64URL.encode(sharedSecret), KeyUse.SIGNATURE, null, null, SYMMETRIC_KEY, null, null, null); Map keys = ImmutableMap.of(SYMMETRIC_KEY, jwk); diff --git a/maxkey-common/src/main/java/org/maxkey/crypto/keystore/KeyStoreUtil.java b/maxkey-common/src/main/java/org/maxkey/crypto/keystore/KeyStoreUtil.java index 178552fc96a69af4a1bfcff3e61bd8eb0b19b687..9b53b23a0833cb9f9578bde8fc0469516991ba6b 100644 --- a/maxkey-common/src/main/java/org/maxkey/crypto/keystore/KeyStoreUtil.java +++ b/maxkey-common/src/main/java/org/maxkey/crypto/keystore/KeyStoreUtil.java @@ -234,7 +234,7 @@ public final class KeyStoreUtil { * @return available keystore types */ public static KeyStoreType[] getAvailableTypes() { - // TODO: populate only once + // populate only once KeyStoreType[] known = KeyStoreType.values(); ArrayList available = new ArrayList(); for (KeyStoreType type : known) { diff --git a/maxkey-common/src/test/java/org/maxkey/Copyright4RZ.java b/maxkey-common/src/test/java/org/maxkey/Copyright4RZ.java index 79a19e0fb0da378a74fecceec7a1a8991a900691..3bd6378c35b636e4c69056ea592733c5faeffefa 100644 --- a/maxkey-common/src/test/java/org/maxkey/Copyright4RZ.java +++ b/maxkey-common/src/test/java/org/maxkey/Copyright4RZ.java @@ -51,10 +51,8 @@ public class Copyright4RZ { try { writer = new OutputStreamWriter(new FileOutputStream("D:/MaxKey/code.txt"), encode); } catch (UnsupportedEncodingException e) { - // TODO Auto-generated catch block e.printStackTrace(); } catch (FileNotFoundException e) { - // TODO Auto-generated catch block e.printStackTrace(); } } diff --git a/maxkey-common/src/test/java/org/maxkey/Integer2LongTest.java b/maxkey-common/src/test/java/org/maxkey/Integer2LongTest.java index 1b92db8cf5efdf667c73a2584a34be1db2c8b99d..980825f4d6c0e0cfa9812ac24764b087a16c7599 100644 --- a/maxkey-common/src/test/java/org/maxkey/Integer2LongTest.java +++ b/maxkey-common/src/test/java/org/maxkey/Integer2LongTest.java @@ -3,7 +3,6 @@ package org.maxkey; public class Integer2LongTest { public static void main(String[] args) { - // TODO Auto-generated method stub Integer intValue =20000; Long v=Integer.toUnsignedLong(intValue); System.out.println(v); diff --git a/maxkey-common/src/test/java/org/maxkey/crypto/Base64UtilsTest.java b/maxkey-common/src/test/java/org/maxkey/crypto/Base64UtilsTest.java index a339e0c29ee113989ea5876f878ca6d6d84c30a8..e2b329ad68e56421b16e2249b39231408feb91d4 100644 --- a/maxkey-common/src/test/java/org/maxkey/crypto/Base64UtilsTest.java +++ b/maxkey-common/src/test/java/org/maxkey/crypto/Base64UtilsTest.java @@ -26,7 +26,6 @@ public class Base64UtilsTest { */ @Test public void test() { - // TODO Auto-generated method stub String encode=Base64Utils.encoder("base64ToFile".getBytes()); System.out.println(encode); String decode=Base64Utils.decode(encode); diff --git a/maxkey-common/src/test/java/org/maxkey/crypto/Md5SumTest.java b/maxkey-common/src/test/java/org/maxkey/crypto/Md5SumTest.java index c4095849247a25f25a21f1ddf71a5a4c6c51c0b1..a00e7d000f515c48669b1d960f24dd685cbbf7e5 100644 --- a/maxkey-common/src/test/java/org/maxkey/crypto/Md5SumTest.java +++ b/maxkey-common/src/test/java/org/maxkey/crypto/Md5SumTest.java @@ -23,11 +23,9 @@ import java.io.FileNotFoundException; public class Md5SumTest { public Md5SumTest() { - // TODO Auto-generated constructor stub } public static void main(String[] args) throws FileNotFoundException { - // TODO Auto-generated method stub //String md5value=Md5Sum.produce(new File("E:/transwarp-4.3.4-Final-el6/transwarp-4.3.4-Final-26854-zh.el6.x86_64.tar.gz")); File f=new File("E:/Soft/Xmanager4_setup.1410342608.exe"); String md5value=Md5Sum.produce(f); diff --git a/maxkey-common/src/test/java/org/maxkey/crypto/PasswordGenTest.java b/maxkey-common/src/test/java/org/maxkey/crypto/PasswordGenTest.java index 4809a32bc0c0190134d222376483e7b57ad7ac94..883945275c9571a36a030c193147a86c77f032f1 100644 --- a/maxkey-common/src/test/java/org/maxkey/crypto/PasswordGenTest.java +++ b/maxkey-common/src/test/java/org/maxkey/crypto/PasswordGenTest.java @@ -22,11 +22,9 @@ import org.maxkey.crypto.password.PasswordGen; public class PasswordGenTest { public PasswordGenTest() { - // TODO Auto-generated constructor stub } public static void main(String[] args) { - // TODO Auto-generated method stub PasswordGen gen=new PasswordGen(); System.out.println(gen.gen(2,2,2,1)); for(int i=1;i<100;i++){ diff --git a/maxkey-common/src/test/java/org/maxkey/crypto/SCryptPasswordEncoderTest.java b/maxkey-common/src/test/java/org/maxkey/crypto/SCryptPasswordEncoderTest.java index 42f2bdd7511ec1c8a813b4f7ff3a7450899704ab..a099ea385f9abece7fa2285dad45b793c72311c0 100644 --- a/maxkey-common/src/test/java/org/maxkey/crypto/SCryptPasswordEncoderTest.java +++ b/maxkey-common/src/test/java/org/maxkey/crypto/SCryptPasswordEncoderTest.java @@ -22,11 +22,9 @@ import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder; public class SCryptPasswordEncoderTest { public SCryptPasswordEncoderTest() { - // TODO Auto-generated constructor stub } public static void main(String[] args) { - // TODO Auto-generated method stub BCryptPasswordEncoder pe=new BCryptPasswordEncoder(); //String c="$e0801$7Holo9EgzBeg5xf/WLZu3/5IQwOyEPDLJPgMXkF9jnekBrbQUMt4CF9O2trkz3zBCnCLpUMR437q/AjQ5TTToA==$oYB8KRSxAsxkKkt5r79W6r6P0wTUcKwGye1ivXRN0Ts=" //; diff --git a/maxkey-common/src/test/java/org/maxkey/crypto/password/PasswordReciprocalTest.java b/maxkey-common/src/test/java/org/maxkey/crypto/password/PasswordReciprocalTest.java index ce456de3112e483f7bf6bc4d81aecc65c6ef9bd0..3b935a331aec858fc3075627e470f5a723c36e58 100644 --- a/maxkey-common/src/test/java/org/maxkey/crypto/password/PasswordReciprocalTest.java +++ b/maxkey-common/src/test/java/org/maxkey/crypto/password/PasswordReciprocalTest.java @@ -22,11 +22,10 @@ import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder; public class PasswordReciprocalTest { public PasswordReciprocalTest() { - // TODO Auto-generated constructor stub + } public static void main(String[] args) { - // TODO Auto-generated method stub BCryptPasswordEncoder spe= new BCryptPasswordEncoder(); String pass=PasswordReciprocal.getInstance().rawPassword("admin", "admin"); String epass=spe.encode(pass); diff --git a/maxkey-common/src/test/java/org/maxkey/crypto/password/SM3PasswordEncoderTest.java b/maxkey-common/src/test/java/org/maxkey/crypto/password/SM3PasswordEncoderTest.java index 631f2720487fdfd11b6d0744dfbd9fbace9d4c87..5178e1bacfcf395637100f97568ae49e3e79124e 100644 --- a/maxkey-common/src/test/java/org/maxkey/crypto/password/SM3PasswordEncoderTest.java +++ b/maxkey-common/src/test/java/org/maxkey/crypto/password/SM3PasswordEncoderTest.java @@ -20,7 +20,6 @@ package org.maxkey.crypto.password; public class SM3PasswordEncoderTest { public static void main(String[] args) { - // TODO Auto-generated method stub SM3PasswordEncoder sm3 = new SM3PasswordEncoder(); System.out.println(sm3.encode("maxkeypassword")); diff --git a/maxkey-common/src/test/java/org/maxkey/util/IdSequenceTest.java b/maxkey-common/src/test/java/org/maxkey/util/IdSequenceTest.java index 6124136d6cbcaeb328520e184753b17ea10d36f8..a7d1ce1cafcca4be81e63423a67585a0d881851d 100644 --- a/maxkey-common/src/test/java/org/maxkey/util/IdSequenceTest.java +++ b/maxkey-common/src/test/java/org/maxkey/util/IdSequenceTest.java @@ -20,7 +20,6 @@ package org.maxkey.util; public class IdSequenceTest { public static void main(String[] args) { - // TODO Auto-generated method stub long s =System.currentTimeMillis(); int k; for(int i=1;i<=10010;i++){ diff --git a/maxkey-common/src/test/java/org/maxkey/util/MacAddressTest.java b/maxkey-common/src/test/java/org/maxkey/util/MacAddressTest.java index 21f7176f430d8e7def652cb5e5086d4a5f4e6660..0aed441c7a4b51c4be2cc4db3988e5420c35eeb7 100644 --- a/maxkey-common/src/test/java/org/maxkey/util/MacAddressTest.java +++ b/maxkey-common/src/test/java/org/maxkey/util/MacAddressTest.java @@ -20,7 +20,6 @@ package org.maxkey.util; public class MacAddressTest { public static void main(String[] args) { - // TODO Auto-generated method stub System.out.println(MacAddress.getAllHostMacAddress()); } diff --git a/maxkey-common/src/test/java/org/maxkey/util/ObjectTransformerTest.java b/maxkey-common/src/test/java/org/maxkey/util/ObjectTransformerTest.java index eb2168817255025fc1c3d333891759021eea4c9b..c6816aad644bd8296e59b6b20d2d856c48e541a4 100644 --- a/maxkey-common/src/test/java/org/maxkey/util/ObjectTransformerTest.java +++ b/maxkey-common/src/test/java/org/maxkey/util/ObjectTransformerTest.java @@ -25,7 +25,6 @@ public class ObjectTransformerTest { * @param args */ public static void main(String[] args) { - // TODO Auto-generated method stub HashMap ut=new HashMap(); ut.put("username","shimingxy"); diff --git a/maxkey-common/src/test/java/org/maxkey/word/CharacterCase.java b/maxkey-common/src/test/java/org/maxkey/word/CharacterCase.java index 89629da5f9d11bd307cc8db2dbfac8de2e0ab720..2462c938c32f2756d24bdc51526fc84ea0391bc1 100644 --- a/maxkey-common/src/test/java/org/maxkey/word/CharacterCase.java +++ b/maxkey-common/src/test/java/org/maxkey/word/CharacterCase.java @@ -23,7 +23,6 @@ public class CharacterCase { * @param args */ public static void main(String[] args) { - // TODO Auto-generated method stub String word="partner "; System.out.println(word.toUpperCase()); diff --git a/maxkey-common/src/test/java/org/maxkey/word/SubStr.java b/maxkey-common/src/test/java/org/maxkey/word/SubStr.java index 9b5427223cb6be07d9d62d004b3a3130f90e2f08..8cfb9e14fad55703ae1a5f875b9b6f7dada0e56c 100644 --- a/maxkey-common/src/test/java/org/maxkey/word/SubStr.java +++ b/maxkey-common/src/test/java/org/maxkey/word/SubStr.java @@ -23,7 +23,6 @@ public class SubStr { * @param args */ public static void main(String[] args) { - // TODO Auto-generated method stub String browser="Chrome/44.0.2369.0"; System.out.println(browser.indexOf('.')); } diff --git a/maxkey-core/src/main/java/org/maxkey/autoconfigure/ApplicationAutoConfiguration.java b/maxkey-core/src/main/java/org/maxkey/autoconfigure/ApplicationAutoConfiguration.java index c07bc6f17b9a4a85baa69615115b2fd83634f653..8a903c5e61135a0e23e3877e954532b6c5e4c070 100644 --- a/maxkey-core/src/main/java/org/maxkey/autoconfigure/ApplicationAutoConfiguration.java +++ b/maxkey-core/src/main/java/org/maxkey/autoconfigure/ApplicationAutoConfiguration.java @@ -163,7 +163,6 @@ public class ApplicationAutoConfiguration implements InitializingBean { @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } } diff --git a/maxkey-core/src/main/java/org/maxkey/autoconfigure/MvcAutoConfiguration.java b/maxkey-core/src/main/java/org/maxkey/autoconfigure/MvcAutoConfiguration.java index 1ba704b3c65ee1fb5cf08905d474ac2a79b5527e..2b5367b884dfead175be045532833f4a1030636d 100644 --- a/maxkey-core/src/main/java/org/maxkey/autoconfigure/MvcAutoConfiguration.java +++ b/maxkey-core/src/main/java/org/maxkey/autoconfigure/MvcAutoConfiguration.java @@ -291,7 +291,6 @@ public class MvcAutoConfiguration implements InitializingBean , WebMvcConfigurer @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } diff --git a/maxkey-core/src/main/java/org/maxkey/autoconfigure/RedisAutoConfiguration.java b/maxkey-core/src/main/java/org/maxkey/autoconfigure/RedisAutoConfiguration.java index e5748c1f58997f12a5fd078f18a2e02d48657de9..ad279120ab33e352923207ddf14ed46f667e2dd7 100644 --- a/maxkey-core/src/main/java/org/maxkey/autoconfigure/RedisAutoConfiguration.java +++ b/maxkey-core/src/main/java/org/maxkey/autoconfigure/RedisAutoConfiguration.java @@ -80,7 +80,6 @@ public class RedisAutoConfiguration implements InitializingBean { @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } } diff --git a/maxkey-core/src/main/java/org/maxkey/autoconfigure/SessionRedisAutoConfiguration.java b/maxkey-core/src/main/java/org/maxkey/autoconfigure/SessionRedisAutoConfiguration.java index 6327e0a11d08a1931f4d55c4ed6dd72c1f7d52ef..71ad6538e4912d941f7dfae007d1ba53f019247b 100644 --- a/maxkey-core/src/main/java/org/maxkey/autoconfigure/SessionRedisAutoConfiguration.java +++ b/maxkey-core/src/main/java/org/maxkey/autoconfigure/SessionRedisAutoConfiguration.java @@ -56,7 +56,6 @@ public class SessionRedisAutoConfiguration implements InitializingBean { @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } } diff --git a/maxkey-core/src/main/java/org/maxkey/configuration/LoginConfig.java b/maxkey-core/src/main/java/org/maxkey/configuration/LoginConfig.java index de1acba3d8d1f322de6adc7ccaa14c91e2500bce..3a6459380c4e1371779bf7217aee803a9f5a002e 100644 --- a/maxkey-core/src/main/java/org/maxkey/configuration/LoginConfig.java +++ b/maxkey-core/src/main/java/org/maxkey/configuration/LoginConfig.java @@ -51,7 +51,6 @@ public class LoginConfig { * . */ public LoginConfig() { - // TODO Auto-generated constructor stub } public boolean isCaptcha() { diff --git a/maxkey-core/src/main/java/org/maxkey/configuration/oidc/OIDCProviderMetadataDetails.java b/maxkey-core/src/main/java/org/maxkey/configuration/oidc/OIDCProviderMetadataDetails.java index 37d0f3ec37b49ed9342b88bd73b8a5d45ae554f6..1e39f323d002b8ac2dd96f7a4aea1bb22cc1ac80 100644 --- a/maxkey-core/src/main/java/org/maxkey/configuration/oidc/OIDCProviderMetadataDetails.java +++ b/maxkey-core/src/main/java/org/maxkey/configuration/oidc/OIDCProviderMetadataDetails.java @@ -145,7 +145,7 @@ public class OIDCProviderMetadataDetails implements OIDCProviderMetadata { return builder.toString(); } - // TODO: Complete remaining properties from + // Complete remaining properties from // http://openid.net/specs/openid-connect-discovery-1_0.html#ProviderMetadata } diff --git a/maxkey-core/src/main/java/org/maxkey/entity/AccountsStrategy.java b/maxkey-core/src/main/java/org/maxkey/entity/AccountsStrategy.java index 8b08acc0c3703ceaceea62e5a38333715ca7f41a..1379570c53bc91349340fa691e43bd07e52ea50c 100644 --- a/maxkey-core/src/main/java/org/maxkey/entity/AccountsStrategy.java +++ b/maxkey-core/src/main/java/org/maxkey/entity/AccountsStrategy.java @@ -67,7 +67,6 @@ public class AccountsStrategy extends JpaBaseEntity implements Serializable { public AccountsStrategy() { super(); - // TODO Auto-generated constructor stub } public String getId() { diff --git a/maxkey-core/src/main/java/org/maxkey/entity/HistoryLoginApps.java b/maxkey-core/src/main/java/org/maxkey/entity/HistoryLoginApps.java index 7320497eecf00e785f82cd42b724fa4340e8dc76..7871aa237c0b17a40fdb31bfc36069cd9f8b97c6 100644 --- a/maxkey-core/src/main/java/org/maxkey/entity/HistoryLoginApps.java +++ b/maxkey-core/src/main/java/org/maxkey/entity/HistoryLoginApps.java @@ -62,7 +62,6 @@ public class HistoryLoginApps extends JpaBaseEntity { */ public HistoryLoginApps() { super(); - // TODO Auto-generated constructor stub } diff --git a/maxkey-core/src/main/java/org/maxkey/entity/Resources.java b/maxkey-core/src/main/java/org/maxkey/entity/Resources.java index 1159a6b28bed4cd526aad952eaadd90d0d934f46..bb55e1c28a07c87a9fd16679d87e556c28c208e3 100644 --- a/maxkey-core/src/main/java/org/maxkey/entity/Resources.java +++ b/maxkey-core/src/main/java/org/maxkey/entity/Resources.java @@ -70,7 +70,6 @@ public class Resources extends JpaBaseEntity implements Serializable { public Resources() { super(); - // TODO Auto-generated constructor stub } public String getId() { diff --git a/maxkey-core/src/main/java/org/maxkey/entity/Roles.java b/maxkey-core/src/main/java/org/maxkey/entity/Roles.java index 5fb8befb5cbe3769336ab974744d2f54fa61a580..3361a029f38612ec6ab3ec3ab0bf80870d986e6a 100644 --- a/maxkey-core/src/main/java/org/maxkey/entity/Roles.java +++ b/maxkey-core/src/main/java/org/maxkey/entity/Roles.java @@ -60,7 +60,6 @@ public class Roles extends JpaBaseEntity implements Serializable { public Roles() { super(); - // TODO Auto-generated constructor stub } public String getId() { diff --git a/maxkey-core/src/main/java/org/maxkey/entity/UserInfoAdjoint.java b/maxkey-core/src/main/java/org/maxkey/entity/UserInfoAdjoint.java index 40ac589e042c6bea7ebcede62ad38a58f592dc25..3cf243d08ad4764dd76dce85051d6f3c0a1be068 100644 --- a/maxkey-core/src/main/java/org/maxkey/entity/UserInfoAdjoint.java +++ b/maxkey-core/src/main/java/org/maxkey/entity/UserInfoAdjoint.java @@ -92,7 +92,6 @@ public class UserInfoAdjoint extends JpaBaseEntity { protected String quitDate; public UserInfoAdjoint() { super(); - // TODO Auto-generated constructor stub } public String getId() { return id; diff --git a/maxkey-core/src/main/java/org/maxkey/entity/xml/UserInfoXML.java b/maxkey-core/src/main/java/org/maxkey/entity/xml/UserInfoXML.java index ce0a6469868b495dd5ce98b4165730647263af7f..2530b5ef0923e5c15c03e311644cf5287cee6c29 100644 --- a/maxkey-core/src/main/java/org/maxkey/entity/xml/UserInfoXML.java +++ b/maxkey-core/src/main/java/org/maxkey/entity/xml/UserInfoXML.java @@ -39,7 +39,6 @@ public class UserInfoXML extends JpaBaseEntity { */ public UserInfoXML() { super(); - // TODO Auto-generated constructor stub } diff --git a/maxkey-core/src/main/java/org/maxkey/web/WebContext.java b/maxkey-core/src/main/java/org/maxkey/web/WebContext.java index 4afac1ed10ddc6ff1748c162d5a49ecf4ab0dc42..c2d0a88ffc92011e9d8e7d59d14af8d5c7194275 100644 --- a/maxkey-core/src/main/java/org/maxkey/web/WebContext.java +++ b/maxkey-core/src/main/java/org/maxkey/web/WebContext.java @@ -481,7 +481,6 @@ public final class WebContext { return true; } - //TODO: /** * getI18nValue. * @param code String @@ -521,7 +520,6 @@ public final class WebContext { return message; } - //TODO: /** * getRequestLocale. * @return diff --git a/maxkey-core/src/test/java/org/maxkey/persistence/derby/DerbyTest.java b/maxkey-core/src/test/java/org/maxkey/persistence/derby/DerbyTest.java index 78d7115fd38bd297a9554633236d7b276d9352f6..3d154cc31a46ed4c9c5b05a00bf7f763d5adf700 100644 --- a/maxkey-core/src/test/java/org/maxkey/persistence/derby/DerbyTest.java +++ b/maxkey-core/src/test/java/org/maxkey/persistence/derby/DerbyTest.java @@ -44,7 +44,6 @@ public class DerbyTest { * @throws SQLException */ public static void main(String[] args) throws SQLException { - // TODO Auto-generated method stub String nsURL="jdbc:derby://localhost:1527/seconddb1"; java.util.Properties props = new java.util.Properties(); props.setProperty("user","tquist"); diff --git a/maxkey-core/src/test/java/org/maxkey/persistence/ldap/ActiveDirectoryUtilsTest.java b/maxkey-core/src/test/java/org/maxkey/persistence/ldap/ActiveDirectoryUtilsTest.java index d2eb91f6d307c5ca37d446c22fa6b4ee0ef26da2..a0a99ac70ebd724b4f66597b7dc57e60b60f8825 100644 --- a/maxkey-core/src/test/java/org/maxkey/persistence/ldap/ActiveDirectoryUtilsTest.java +++ b/maxkey-core/src/test/java/org/maxkey/persistence/ldap/ActiveDirectoryUtilsTest.java @@ -35,7 +35,6 @@ public class ActiveDirectoryUtilsTest { try { dirContext.close(); } catch (NamingException e) { - // TODO Auto-generated catch block e.printStackTrace(); } } diff --git a/maxkey-identitys/maxkey-identity-scim/src/test/java/org/maxkey/identity/scim/resources/ScimEnterpriseUserJsonTest.java b/maxkey-identitys/maxkey-identity-scim/src/test/java/org/maxkey/identity/scim/resources/ScimEnterpriseUserJsonTest.java index e7c1ca866976f7c510af7ec0222c4d02317111eb..d97a5f19b42c285785c2bdaa0c2cc8324dc71298 100644 --- a/maxkey-identitys/maxkey-identity-scim/src/test/java/org/maxkey/identity/scim/resources/ScimEnterpriseUserJsonTest.java +++ b/maxkey-identitys/maxkey-identity-scim/src/test/java/org/maxkey/identity/scim/resources/ScimEnterpriseUserJsonTest.java @@ -27,7 +27,6 @@ public class ScimEnterpriseUserJsonTest { public static void main(String[] args) { - // TODO Auto-generated method stub EnterpriseUser u = new EnterpriseUser(); u.setUserName("UserName"); u.setExternalId("UserName"); diff --git a/maxkey-identitys/maxkey-identity-scim/src/test/java/org/maxkey/identity/scim/resources/ScimUserJsonTest.java b/maxkey-identitys/maxkey-identity-scim/src/test/java/org/maxkey/identity/scim/resources/ScimUserJsonTest.java index e4487b5d09346f0df1ef71c947d2cf2f1a0bcfb0..ffdd72f19bc5c4a9c4d97ea249d7159bb268b687 100644 --- a/maxkey-identitys/maxkey-identity-scim/src/test/java/org/maxkey/identity/scim/resources/ScimUserJsonTest.java +++ b/maxkey-identitys/maxkey-identity-scim/src/test/java/org/maxkey/identity/scim/resources/ScimUserJsonTest.java @@ -26,7 +26,6 @@ import org.maxkey.util.JsonUtils; public class ScimUserJsonTest { public static void main(String[] args) { - // TODO Auto-generated method stub User u = new User(); u.setUserName("UserName"); u.setExternalId("UserName"); diff --git a/maxkey-identitys/maxkey-synchronizers-dingding/src/main/java/org/maxkey/synchronizer/dingding/DingdingAccessTokenService.java b/maxkey-identitys/maxkey-synchronizers-dingding/src/main/java/org/maxkey/synchronizer/dingding/DingdingAccessTokenService.java index 6508bd3532f504513424c9c241ecac21192ebaee..275661f7ed7b2a971fab1471e8b2624d4edbe3cf 100644 --- a/maxkey-identitys/maxkey-synchronizers-dingding/src/main/java/org/maxkey/synchronizer/dingding/DingdingAccessTokenService.java +++ b/maxkey-identitys/maxkey-synchronizers-dingding/src/main/java/org/maxkey/synchronizer/dingding/DingdingAccessTokenService.java @@ -80,7 +80,6 @@ public class DingdingAccessTokenService { public static void main(String[] args) { - // TODO Auto-generated method stub } diff --git a/maxkey-identitys/maxkey-synchronizers-dingding/src/main/java/org/maxkey/synchronizer/dingding/DingdingOrganizationService.java b/maxkey-identitys/maxkey-synchronizers-dingding/src/main/java/org/maxkey/synchronizer/dingding/DingdingOrganizationService.java index 2e4d8f975aaa99b4b53eaac69f68f11504597da4..6fef4bddf4ed172bd2c7a023fbbe319c0dfe7ef0 100644 --- a/maxkey-identitys/maxkey-synchronizers-dingding/src/main/java/org/maxkey/synchronizer/dingding/DingdingOrganizationService.java +++ b/maxkey-identitys/maxkey-synchronizers-dingding/src/main/java/org/maxkey/synchronizer/dingding/DingdingOrganizationService.java @@ -105,7 +105,6 @@ public class DingdingOrganizationService implements ISynchronizerService{ @Override public void setSynchronizer(Synchronizers Synchronizer) { - // TODO Auto-generated method stub } diff --git a/maxkey-identitys/maxkey-synchronizers-dingding/src/main/java/org/maxkey/synchronizer/dingding/DingdingUsersService.java b/maxkey-identitys/maxkey-synchronizers-dingding/src/main/java/org/maxkey/synchronizer/dingding/DingdingUsersService.java index bdba7ae8d2ba346e4b4407f4837674d3e9042980..2aa4882d2c23d9bfba558b8604322a13069b2de7 100644 --- a/maxkey-identitys/maxkey-synchronizers-dingding/src/main/java/org/maxkey/synchronizer/dingding/DingdingUsersService.java +++ b/maxkey-identitys/maxkey-synchronizers-dingding/src/main/java/org/maxkey/synchronizer/dingding/DingdingUsersService.java @@ -127,7 +127,6 @@ public class DingdingUsersService implements ISynchronizerService{ @Override public void setSynchronizer(Synchronizers Synchronizer) { - // TODO Auto-generated method stub } diff --git a/maxkey-identitys/maxkey-synchronizers-workweixin/src/main/java/org/maxkey/synchronizer/workweixin/WorkweixinAccessTokenService.java b/maxkey-identitys/maxkey-synchronizers-workweixin/src/main/java/org/maxkey/synchronizer/workweixin/WorkweixinAccessTokenService.java index 8a20e1a5d0009f0ee8a346f170be758c750e92cf..e411779072b77f4350d355323ca1be4ddbcecaf8 100644 --- a/maxkey-identitys/maxkey-synchronizers-workweixin/src/main/java/org/maxkey/synchronizer/workweixin/WorkweixinAccessTokenService.java +++ b/maxkey-identitys/maxkey-synchronizers-workweixin/src/main/java/org/maxkey/synchronizer/workweixin/WorkweixinAccessTokenService.java @@ -79,7 +79,6 @@ public class WorkweixinAccessTokenService { public static void main(String[] args) { - // TODO Auto-generated method stub } diff --git a/maxkey-identitys/maxkey-synchronizers-workweixin/src/main/java/org/maxkey/synchronizer/workweixin/WorkweixinUsersService.java b/maxkey-identitys/maxkey-synchronizers-workweixin/src/main/java/org/maxkey/synchronizer/workweixin/WorkweixinUsersService.java index a54a62631a7bc653b74074e381a554132aa44645..4a3e149f5b1fe22139bece818b8716985c047404 100644 --- a/maxkey-identitys/maxkey-synchronizers-workweixin/src/main/java/org/maxkey/synchronizer/workweixin/WorkweixinUsersService.java +++ b/maxkey-identitys/maxkey-synchronizers-workweixin/src/main/java/org/maxkey/synchronizer/workweixin/WorkweixinUsersService.java @@ -114,7 +114,6 @@ public class WorkweixinUsersService implements ISynchronizerService{ @Override public void setSynchronizer(Synchronizers Synchronizer) { - // TODO Auto-generated method stub } diff --git a/maxkey-identitys/maxkey-synchronizers/src/main/java/org/maxkey/synchronizer/autoconfigure/SynchronizerAutoConfiguration.java b/maxkey-identitys/maxkey-synchronizers/src/main/java/org/maxkey/synchronizer/autoconfigure/SynchronizerAutoConfiguration.java index f0266c868bbedccf4f28f04f06a48faf335d31e5..a4e2c0718b41bc23f44c248046cbe0aba6ad0638 100644 --- a/maxkey-identitys/maxkey-synchronizers/src/main/java/org/maxkey/synchronizer/autoconfigure/SynchronizerAutoConfiguration.java +++ b/maxkey-identitys/maxkey-synchronizers/src/main/java/org/maxkey/synchronizer/autoconfigure/SynchronizerAutoConfiguration.java @@ -126,7 +126,6 @@ public class SynchronizerAutoConfiguration implements InitializingBean { @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AccountsService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AccountsService.java index e8aa76ea69477aa06262c63c5f3bb888efea4aa0..8c84dbf66377caba5b3c13a1fd6b7f65752e3828 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AccountsService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AccountsService.java @@ -58,7 +58,6 @@ public class AccountsService extends JpaBaseService{ */ @Override public AccountsMapper getMapper() { - // TODO Auto-generated method stub return (AccountsMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AccountsStrategyService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AccountsStrategyService.java index 99948e232ea2f2e434e675f0732a0a0a82773d46..f59f6663555ee350846b7dc7d229237a009359fa 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AccountsStrategyService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AccountsStrategyService.java @@ -18,24 +18,16 @@ package org.maxkey.persistence.service; import java.io.Serializable; -import java.time.LocalDateTime; -import java.time.LocalTime; import java.util.List; import org.apache.mybatis.jpa.persistence.JpaBaseService; import org.maxkey.entity.AccountsStrategy; import org.maxkey.entity.Groups; import org.maxkey.persistence.mapper.AccountsStrategyMapper; -import org.maxkey.persistence.mapper.GroupsMapper; -import org.maxkey.util.StringUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import org.springframework.beans.factory.annotation.Autowired; -import org.springframework.beans.factory.annotation.Qualifier; import org.springframework.stereotype.Repository; -import com.fasterxml.jackson.annotation.JsonIgnore; - @Repository public class AccountsStrategyService extends JpaBaseService implements Serializable { /** @@ -59,7 +51,6 @@ public class AccountsStrategyService extends JpaBaseService i */ @Override public AccountsStrategyMapper getMapper() { - // TODO Auto-generated method stub return (AccountsStrategyMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsAdaptersService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsAdaptersService.java index 9adf5a9b8eb560464da7c0af3b014abae5f1c40d..50d176ca222377a3e6181b3455345a523c76e514 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsAdaptersService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsAdaptersService.java @@ -34,7 +34,6 @@ public class AppsAdaptersService extends JpaBaseService{ */ @Override public AppsAdaptersMapper getMapper() { - // TODO Auto-generated method stub return (AppsAdaptersMapper)super.getMapper(); } } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsCasDetailsService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsCasDetailsService.java index 975de1f3fceb3b5e87aefc0edbcb800e0277b391..0f2c200bb4f6529fb7f666d2807e7504e3ceafd7 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsCasDetailsService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsCasDetailsService.java @@ -34,7 +34,6 @@ public class AppsCasDetailsService extends JpaBaseService{ */ @Override public AppsCasDetailsMapper getMapper() { - // TODO Auto-generated method stub return (AppsCasDetailsMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsJwtDetailsService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsJwtDetailsService.java index 622ae9ca0dbbb4d7bffe51d8170a9514f7160014..96d172e879aacdbe9775864d9e8acfdd6c077936 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsJwtDetailsService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsJwtDetailsService.java @@ -34,7 +34,6 @@ public class AppsJwtDetailsService extends JpaBaseService{ */ @Override public AppsJwtDetailsMapper getMapper() { - // TODO Auto-generated method stub return (AppsJwtDetailsMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsSaml20DetailsService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsSaml20DetailsService.java index 1f2572d0c0c4c9898d4ac154ecc969df916946f8..d29bcb85a50d9c4fd58a17ab70c2100795c257ed 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsSaml20DetailsService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsSaml20DetailsService.java @@ -34,7 +34,6 @@ public class AppsSaml20DetailsService extends JpaBaseService */ @Override public AppsSaml20DetailsMapper getMapper() { - // TODO Auto-generated method stub return (AppsSaml20DetailsMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsTokenBasedDetailsService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsTokenBasedDetailsService.java index 02484669a1d0c72d2b0f11deb3aa2e3d03d36f35..78f5921d8ea5c63a021400058b8e369f0792e4c3 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsTokenBasedDetailsService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/AppsTokenBasedDetailsService.java @@ -34,7 +34,6 @@ public class AppsTokenBasedDetailsService extends JpaBaseService{ */ @Override public GroupMemberMapper getMapper() { - // TODO Auto-generated method stub return (GroupMemberMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/GroupPrivilegesService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/GroupPrivilegesService.java index 650783338bf0745ae0b8a403f147a9dc4a7fc93b..e02aae8f874a344585b4af6e78dfead622e822f2 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/GroupPrivilegesService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/GroupPrivilegesService.java @@ -36,7 +36,6 @@ public class GroupPrivilegesService extends JpaBaseService{ */ @Override public GroupPrivilegesMapper getMapper() { - // TODO Auto-generated method stub return (GroupPrivilegesMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/GroupsService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/GroupsService.java index 6a3ca10e47ee9635dea69f1914a6fa901610bd06..704b0fd1fcdd207c24ba87ba1b732be45ce240d5 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/GroupsService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/GroupsService.java @@ -57,7 +57,6 @@ public class GroupsService extends JpaBaseService implements Serializab */ @Override public GroupsMapper getMapper() { - // TODO Auto-generated method stub return (GroupsMapper)super.getMapper(); } @@ -73,7 +72,7 @@ public class GroupsService extends JpaBaseService implements Serializab } public void refreshDynamicGroups(Groups dynamicGroup){ - if(dynamicGroup.getDynamic().equals(ConstantsStatus.ACTIVE)) { + if(dynamicGroup.getDynamic().equals(ConstantsStatus.ACTIVE+"")) { boolean isDynamicTimeSupport = false; boolean isBetweenEffectiveTime = false; if(StringUtils.isNotBlank(dynamicGroup.getResumeTime()) diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistoryConnectorService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistoryConnectorService.java index 60b8e8e4ae2b98ca4b91757051daf9d8fc6f759b..ad0eafbbe7e2b27d5bc9676b3ff8328d75bcc89f 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistoryConnectorService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistoryConnectorService.java @@ -34,7 +34,6 @@ public class HistoryConnectorService extends JpaBaseService{ */ @Override public HistoryConnectorMapper getMapper() { - // TODO Auto-generated method stub return (HistoryConnectorMapper)super.getMapper(); } } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistoryLoginAppsService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistoryLoginAppsService.java index 501200e0f0852a28692ce659b3c365b8cacc40f3..05831306822941c275bd49e40ce1ad3eb50c8161 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistoryLoginAppsService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistoryLoginAppsService.java @@ -35,7 +35,6 @@ public class HistoryLoginAppsService extends JpaBaseService{ */ @Override public HistoryLoginAppsMapper getMapper() { - // TODO Auto-generated method stub return (HistoryLoginAppsMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistoryLoginService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistoryLoginService.java index 9dd5aa77e99a1ca5994bd16401f5c2464981eb31..47372d6ddf74bb1cc3f385700c273895d0053b81 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistoryLoginService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistoryLoginService.java @@ -35,7 +35,6 @@ public class HistoryLoginService extends JpaBaseService{ */ @Override public HistoryLoginMapper getMapper() { - // TODO Auto-generated method stub return (HistoryLoginMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistorySynchronizerService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistorySynchronizerService.java index 5c445dfb6344cdcd1c8e2673137ea605cdfacacd..90ec7b598fde2f16ea80f452dfe5c035c46fca9f 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistorySynchronizerService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/HistorySynchronizerService.java @@ -34,7 +34,6 @@ public class HistorySynchronizerService extends JpaBaseService{ */ @Override public HistorySystemLogsMapper getMapper() { - // TODO Auto-generated method stub return (HistorySystemLogsMapper)super.getMapper(); } } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/NoticesService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/NoticesService.java index ad0af8f7649c05af97878950c41be45412f29cd8..52e5153b38f1bb3c423ca7fba672c7741215a59d 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/NoticesService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/NoticesService.java @@ -34,7 +34,6 @@ public class NoticesService extends JpaBaseService{ */ @Override public NoticesMapper getMapper() { - // TODO Auto-generated method stub return (NoticesMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/OrganizationsCastService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/OrganizationsCastService.java index 8345da6830d9bd247f3a9d9eb0b17d8e366111e5..242108571d6c96925abb07c5a0652f8a75e6b346 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/OrganizationsCastService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/OrganizationsCastService.java @@ -40,7 +40,6 @@ public class OrganizationsCastService extends JpaBaseService */ @Override public OrganizationsCastMapper getMapper() { - // TODO Auto-generated method stub return (OrganizationsCastMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/OrganizationsService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/OrganizationsService.java index 16161dfccc5ba63b90161c0c9d10eae6f377adb0..cca167dc72758a47af9130ffd62ad3a9d98175d7 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/OrganizationsService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/OrganizationsService.java @@ -61,7 +61,6 @@ public class OrganizationsService extends JpaBaseService{ */ @Override public OrganizationsMapper getMapper() { - // TODO Auto-generated method stub return (OrganizationsMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/PasswordPolicyService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/PasswordPolicyService.java index 2468542e20f5c285c24780a251d68a4263042d66..1c852dd49903bec10a28781cb5e4a4bcadeae854 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/PasswordPolicyService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/PasswordPolicyService.java @@ -34,7 +34,6 @@ public class PasswordPolicyService extends JpaBaseService{ */ @Override public PasswordPolicyMapper getMapper() { - // TODO Auto-generated method stub return (PasswordPolicyMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/RegistrationService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/RegistrationService.java index e3667f65e094dffc4344f762ed6471d9ada16b7a..dfb823ffd5d6bd7896b721d0e62404740dbd3662 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/RegistrationService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/RegistrationService.java @@ -37,7 +37,6 @@ public class RegistrationService extends JpaBaseService{ */ @Override public RegistrationMapper getMapper() { - // TODO Auto-generated method stub return (RegistrationMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/ReportService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/ReportService.java index 86086d2eec22702a4f96e3ba688e9e7ea0dcda7c..6f181865822484888709b7568da5988f2bdfce64 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/ReportService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/ReportService.java @@ -73,7 +73,6 @@ public class ReportService extends JpaBaseService{ */ @Override public ReportMapper getMapper() { - // TODO Auto-generated method stub return (ReportMapper)super.getMapper(); } } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/ResourcesService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/ResourcesService.java index 657b163785c29f85805dc899f085ce2c350fedec..22d0d4c61d7df5e7b0c27de4ac02dc632fed805e 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/ResourcesService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/ResourcesService.java @@ -36,7 +36,6 @@ public class ResourcesService extends JpaBaseService{ */ @Override public ResourcesMapper getMapper() { - // TODO Auto-generated method stub return (ResourcesMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/RoleMemberService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/RoleMemberService.java index cfca5246bf56665150f8cea0ee2df3bb0c468de7..2181ae707b8945454d4e13a730144be22801bee9 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/RoleMemberService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/RoleMemberService.java @@ -35,7 +35,6 @@ public class RoleMemberService extends JpaBaseService{ */ @Override public RoleMemberMapper getMapper() { - // TODO Auto-generated method stub return (RoleMemberMapper)super.getMapper(); } diff --git a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/SynchronizersService.java b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/SynchronizersService.java index cbaec267864b3a027cd40f46aa2ea5f8eda2f9a8..abd8d48b1a9558df831115aed7fc0dcd1b096ead 100644 --- a/maxkey-persistence/src/main/java/org/maxkey/persistence/service/SynchronizersService.java +++ b/maxkey-persistence/src/main/java/org/maxkey/persistence/service/SynchronizersService.java @@ -37,7 +37,6 @@ public class SynchronizersService extends JpaBaseService{ */ @Override public SynchronizersMapper getMapper() { - // TODO Auto-generated method stub return (SynchronizersMapper)super.getMapper(); } diff --git a/maxkey-protocols/maxkey-protocol-authorize/src/main/java/org/maxkey/authz/endpoint/adapter/AbstractAuthorizeAdapter.java b/maxkey-protocols/maxkey-protocol-authorize/src/main/java/org/maxkey/authz/endpoint/adapter/AbstractAuthorizeAdapter.java index dcdd7b84b73697d539f9591986461bd602cac0f3..9bfade6af63891579e46e7a4f2d98f5c050d5859 100644 --- a/maxkey-protocols/maxkey-protocol-authorize/src/main/java/org/maxkey/authz/endpoint/adapter/AbstractAuthorizeAdapter.java +++ b/maxkey-protocols/maxkey-protocol-authorize/src/main/java/org/maxkey/authz/endpoint/adapter/AbstractAuthorizeAdapter.java @@ -55,7 +55,6 @@ public abstract class AbstractAuthorizeAdapter { } catch (UnsupportedEncodingException e) { e.printStackTrace(); } catch (Exception e) { - // TODO Auto-generated catch block e.printStackTrace(); } _logger.debug("Token : "+data); diff --git a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/Cas10AuthorizeEndpoint.java b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/Cas10AuthorizeEndpoint.java index a5eddbcf96114172389b55c06afbee7c6a497283..aa44a90afe2d9c900e72524f0fee29134c77e5b9 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/Cas10AuthorizeEndpoint.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/Cas10AuthorizeEndpoint.java @@ -101,8 +101,6 @@ renew [OPTIONAL] - if this parameter is set, ticket validation will only succeed try { storedTicket = ticketServices.consumeTicket(ticket); } catch (Exception e) { - // TODO Auto-generated catch block - e.printStackTrace(); _logger.error("consume Ticket error " , e); } diff --git a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/Cas20AuthorizeEndpoint.java b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/Cas20AuthorizeEndpoint.java index e87ea1ce5af12e214819b661a30807ac2ef0d4db..8b64c71c8d2a75fb6fb46f0ab518aa2eb71730a9 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/Cas20AuthorizeEndpoint.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/Cas20AuthorizeEndpoint.java @@ -195,7 +195,6 @@ For all error codes, it is RECOMMENDED that CAS provide a more detailed message try { storedTicket = ticketServices.consumeTicket(ticket); } catch (Exception e) { - // TODO Auto-generated catch block e.printStackTrace(); } } diff --git a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/Cas30AuthorizeEndpoint.java b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/Cas30AuthorizeEndpoint.java index acf87b06b9001c369eefd824cd4515b4d7b0eaa2..4793b47515fd283fde632e6eb85bc746103e2fab 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/Cas30AuthorizeEndpoint.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/Cas30AuthorizeEndpoint.java @@ -78,7 +78,6 @@ public class Cas30AuthorizeEndpoint extends CasBaseAuthorizeEndpoint{ try { storedTicket = ticketServices.consumeTicket(ticket); } catch (Exception e) { - // TODO Auto-generated catch block e.printStackTrace(); } } diff --git a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/CasRestV1Endpoint.java b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/CasRestV1Endpoint.java index 7d7c61bb4d82e7b747465a3856f35881276f9301..ad931ef926ecc4e67f40ac7b58086bc1e4290806 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/CasRestV1Endpoint.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/CasRestV1Endpoint.java @@ -128,7 +128,6 @@ public class CasRestV1Endpoint extends CasBaseAuthorizeEndpoint{ return new ResponseEntity<>(ticket, HttpStatus.OK); } catch (Exception e) { - // TODO Auto-generated catch block e.printStackTrace(); } return new ResponseEntity<>("", HttpStatus.BAD_REQUEST); @@ -147,7 +146,6 @@ public class CasRestV1Endpoint extends CasBaseAuthorizeEndpoint{ return new ResponseEntity<>("", HttpStatus.OK); } } catch (Exception e) { - // TODO Auto-generated catch block e.printStackTrace(); } return new ResponseEntity<>("", HttpStatus.NOT_FOUND); @@ -167,7 +165,6 @@ public class CasRestV1Endpoint extends CasBaseAuthorizeEndpoint{ return new ResponseEntity<>("", HttpStatus.OK); } } catch (Exception e) { - // TODO Auto-generated catch block e.printStackTrace(); } return new ResponseEntity<>("", HttpStatus.NOT_FOUND); diff --git a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/AbstractTicket.java b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/AbstractTicket.java index b42219d473971cf8ec80fbb20fb6b7bb7d26c925..1fe64c2a548b70830c7bf0cffd1a9b46386f2840 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/AbstractTicket.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/AbstractTicket.java @@ -149,13 +149,11 @@ public abstract class AbstractTicket implements Ticket { @Override public AppsCasDetails getCasDetails() { - // TODO Auto-generated method stub return this.casDetails; } @Override public Authentication getAuthentication() { - // TODO Auto-generated method stub return this.authentication; } diff --git a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/ServiceTicketImpl.java b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/ServiceTicketImpl.java index c80870b30a5f462b96f118298a12aac35c1acb21..7085ac90b23e593a76bbd17ad2aacfd2f7134e1e 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/ServiceTicketImpl.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/ServiceTicketImpl.java @@ -115,20 +115,17 @@ public class ServiceTicketImpl extends AbstractTicket implements ServiceTicket{ @Override public Service getService() { - // TODO Auto-generated method stub return null; } @Override public boolean isFromNewLogin() { - // TODO Auto-generated method stub return false; } @Override public ProxyGrantingTicket grantProxyGrantingTicket(String id, Authentication authentication, ExpirationPolicy expirationPolicy) throws Exception { - // TODO Auto-generated method stub return null; } diff --git a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/TicketGrantingTicketImpl.java b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/TicketGrantingTicketImpl.java index d54f4c42229f38ac456c08f80bd9ea1a9eeaab14..4e20ea508651a02857ef19478c5292929779b6d4 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/TicketGrantingTicketImpl.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/TicketGrantingTicketImpl.java @@ -166,37 +166,31 @@ public class TicketGrantingTicketImpl extends AbstractTicket implements TicketGr @Override public Map getServices() { - // TODO Auto-generated method stub return null; } @Override public Map getProxyGrantingTickets() { - // TODO Auto-generated method stub return null; } @Override public Service getProxiedBy() { - // TODO Auto-generated method stub return null; } @Override public boolean isRoot() { - // TODO Auto-generated method stub return false; } @Override public TicketGrantingTicket getRoot() { - // TODO Auto-generated method stub return null; } @Override public List getChainedAuthentications() { - // TODO Auto-generated method stub return null; } diff --git a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/pgt/InMemoryProxyGrantingTicketServices.java b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/pgt/InMemoryProxyGrantingTicketServices.java index ad486b01c9c6ae4e86e1cf69e4593474248c8b40..2c630183a73bb7a4990e592cac9dad970215c282 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/pgt/InMemoryProxyGrantingTicketServices.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/pgt/InMemoryProxyGrantingTicketServices.java @@ -48,7 +48,6 @@ public class InMemoryProxyGrantingTicketServices extends RandomServiceTicketServ @Override public Ticket get(String ticket) { - // TODO Auto-generated method stub return casTicketStore.getIfPresent(ticket); } diff --git a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/st/InMemoryTicketServices.java b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/st/InMemoryTicketServices.java index 026836cb4e9de1f763fc2687f2f7511e87601166..bcb2710e070ee4428d6cec4c65128ad948d8d427 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/st/InMemoryTicketServices.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/authz/cas/endpoint/ticket/st/InMemoryTicketServices.java @@ -48,8 +48,7 @@ public class InMemoryTicketServices extends RandomServiceTicketServices { @Override public Ticket get(String ticket) { - // TODO Auto-generated method stub - return null; + return casTicketStore.getIfPresent(ticket); } } diff --git a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/autoconfigure/CasAutoConfiguration.java b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/autoconfigure/CasAutoConfiguration.java index 4df86ea9cd40f9e360df81cca79f98290c889e56..186ef6167d72216d3532eb2af48bf0562cad1d54 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/autoconfigure/CasAutoConfiguration.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/main/java/org/maxkey/autoconfigure/CasAutoConfiguration.java @@ -83,7 +83,6 @@ public class CasAutoConfiguration implements InitializingBean { @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } } diff --git a/maxkey-protocols/maxkey-protocol-cas/src/test/java/org/maxkey/web/authorize/endpoint/cas/ticket/generator/DefaultUniqueTicketIdGeneratorTest.java b/maxkey-protocols/maxkey-protocol-cas/src/test/java/org/maxkey/web/authorize/endpoint/cas/ticket/generator/DefaultUniqueTicketIdGeneratorTest.java index 6a628e9f9b433261627cf333b63f8345ed4dae62..24e175fe3eb69a48ac07f22877bc45230d2fedaa 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/test/java/org/maxkey/web/authorize/endpoint/cas/ticket/generator/DefaultUniqueTicketIdGeneratorTest.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/test/java/org/maxkey/web/authorize/endpoint/cas/ticket/generator/DefaultUniqueTicketIdGeneratorTest.java @@ -21,7 +21,6 @@ import org.maxkey.authz.cas.endpoint.ticket.generator.DefaultUniqueTicketIdGener public class DefaultUniqueTicketIdGeneratorTest { public static void main(String[] args) { - // TODO Auto-generated method stub DefaultUniqueTicketIdGenerator t=new DefaultUniqueTicketIdGenerator(); System.out.println(t.getNewTicketId("ST")); } diff --git a/maxkey-protocols/maxkey-protocol-cas/src/test/java/org/maxkey/web/authorize/endpoint/cas/ticket/generator/InetAddressUtilsTest.java b/maxkey-protocols/maxkey-protocol-cas/src/test/java/org/maxkey/web/authorize/endpoint/cas/ticket/generator/InetAddressUtilsTest.java index 8547241b612939da8a500b4b0f5b8eab93d88160..19dcbb8aca61b5657b09154611047fdbd674601e 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/test/java/org/maxkey/web/authorize/endpoint/cas/ticket/generator/InetAddressUtilsTest.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/test/java/org/maxkey/web/authorize/endpoint/cas/ticket/generator/InetAddressUtilsTest.java @@ -22,11 +22,9 @@ import org.maxkey.authz.cas.endpoint.ticket.generator.InetAddressUtils; public class InetAddressUtilsTest { public InetAddressUtilsTest() { - // TODO Auto-generated constructor stub } public static void main(String[] args) { - // TODO Auto-generated method stub System.out.println(InetAddressUtils.getCasServerHostName()); } diff --git a/maxkey-protocols/maxkey-protocol-cas/src/test/java/org/maxkey/web/authorize/endpoint/response/ServiceResponseBuilderTest.java b/maxkey-protocols/maxkey-protocol-cas/src/test/java/org/maxkey/web/authorize/endpoint/response/ServiceResponseBuilderTest.java index 503c13b711b942537d67bb1663317ba251b12919..fc573e46753eb2af632c0c15368648c88c1f83ce 100644 --- a/maxkey-protocols/maxkey-protocol-cas/src/test/java/org/maxkey/web/authorize/endpoint/response/ServiceResponseBuilderTest.java +++ b/maxkey-protocols/maxkey-protocol-cas/src/test/java/org/maxkey/web/authorize/endpoint/response/ServiceResponseBuilderTest.java @@ -26,11 +26,9 @@ import org.maxkey.pretty.impl.XmlPretty; public class ServiceResponseBuilderTest { public ServiceResponseBuilderTest() { - // TODO Auto-generated constructor stub } public static void main(String[] args) throws Exception { - // TODO Auto-generated method stub ServiceResponseBuilder srbJson=new ServiceResponseBuilder(); srbJson.success() .setUser("shi") diff --git a/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedDefaultAdapter.java b/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedDefaultAdapter.java index 4262786c219090fd0f18cb8cd84f0d57a6f68aef..ad0d685af4e6c7571bd7bce801242331110ba9e2 100644 --- a/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedDefaultAdapter.java +++ b/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedDefaultAdapter.java @@ -36,7 +36,6 @@ public class FormBasedDefaultAdapter extends AbstractAuthorizeAdapter { @Override public String encrypt(String data, String algorithmKey, String algorithm) { - // TODO Auto-generated method stub return null; } diff --git a/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedNetease163EmailAdapter.java b/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedNetease163EmailAdapter.java index 5f0b9a7865a6962cea63a03ccb7eb6897004e042..f6660c1c1b8f29e42015af5b7fc8575ec96efded 100644 --- a/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedNetease163EmailAdapter.java +++ b/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedNetease163EmailAdapter.java @@ -33,7 +33,6 @@ public class FormBasedNetease163EmailAdapter extends AbstractAuthorizeAdapter { @Override public String encrypt(String data, String algorithmKey, String algorithm) { - // TODO Auto-generated method stub return null; } diff --git a/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedNeteaseNoteYoudaoAdapter.java b/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedNeteaseNoteYoudaoAdapter.java index 6212edd48292d5d37d6358b0a465e4f471b64fd1..0f05a8a312f5ebe4fd3c0ff3b8dd6a2dea010cb7 100644 --- a/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedNeteaseNoteYoudaoAdapter.java +++ b/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedNeteaseNoteYoudaoAdapter.java @@ -35,7 +35,6 @@ public class FormBasedNeteaseNoteYoudaoAdapter extends AbstractAuthorizeAdapter @Override public String encrypt(String data, String algorithmKey, String algorithm) { - // TODO Auto-generated method stub return null; } diff --git a/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedRedirectAdapter.java b/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedRedirectAdapter.java index 63d224914dcd7b273f05bc18bf0ec5a6059bcc21..7507172a15cbce7efad0e861422b46daec88ba23 100644 --- a/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedRedirectAdapter.java +++ b/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/maxkey/authz/formbased/endpoint/adapter/FormBasedRedirectAdapter.java @@ -37,7 +37,6 @@ public class FormBasedRedirectAdapter extends AbstractAuthorizeAdapter { @Override public String encrypt(String data, String algorithmKey, String algorithm) { - // TODO Auto-generated method stub return null; } diff --git a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/common/OAuth2AccessTokenJackson2Deserializer.java b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/common/OAuth2AccessTokenJackson2Deserializer.java index 6eea7a90ffed650c3dd7fd90b86a3d63c1d20f60..c64b77c91ac6d5fa648c4efa8940211ac90a6a81 100644 --- a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/common/OAuth2AccessTokenJackson2Deserializer.java +++ b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/common/OAuth2AccessTokenJackson2Deserializer.java @@ -60,7 +60,7 @@ public final class OAuth2AccessTokenJackson2Deserializer extends StdDeserializer Set scope = null; Map additionalInformation = new LinkedHashMap(); - // TODO What should occur if a parameter exists twice + // What should occur if a parameter exists twice while (jp.nextToken() != JsonToken.END_OBJECT) { String name = jp.getCurrentName(); jp.nextToken(); @@ -88,7 +88,7 @@ public final class OAuth2AccessTokenJackson2Deserializer extends StdDeserializer } } - // TODO What should occur if a required parameter (tokenValue or tokenType) is missing? + // What should occur if a required parameter (tokenValue or tokenType) is missing? DefaultOAuth2AccessToken accessToken = new DefaultOAuth2AccessToken(tokenValue); accessToken.setTokenType(tokenType); diff --git a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/jwt/JwtHelper.java b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/jwt/JwtHelper.java index 345cba9cbf954f4aade0139b2b8708b9c709a211..bcef27f8596fa34407683954065cc35d69f2fa34 100644 --- a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/jwt/JwtHelper.java +++ b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/jwt/JwtHelper.java @@ -50,7 +50,7 @@ public class JwtHelper { throw new IllegalArgumentException("JWT must have 3 tokens"); } CharBuffer buffer = CharBuffer.wrap(token, 0, firstPeriod); - // TODO: Use a Reader which supports CharBuffer + // Use a Reader which supports CharBuffer JwtHeader header = JwtHeaderHelper.create(buffer.toString()); buffer.limit(lastPeriod).position(firstPeriod + 1); diff --git a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/OAuth2RequestFactory.java b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/OAuth2RequestFactory.java index b5a97c403dc670ba62c89e48d2eedb40e95c5932..31de7635d7487699a37a03f9fa4f7406ac1b2a7f 100644 --- a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/OAuth2RequestFactory.java +++ b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/OAuth2RequestFactory.java @@ -54,7 +54,7 @@ public interface OAuth2RequestFactory { /** * Create a new {@link OAuth2Request} by extracting the needed information from the current {@link TokenRequest} * object. - * @param client TODO + * @param client * @param tokenRequest the request to be converted * * @return am immutable object for storage diff --git a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/client/JdbcClientDetailsService.java b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/client/JdbcClientDetailsService.java index 6e6158fc59d3283d27548129791ac1d8a64b09a4..6cdee80757ec17c1b311d2666ea41365b1f1fe11 100644 --- a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/client/JdbcClientDetailsService.java +++ b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/client/JdbcClientDetailsService.java @@ -126,7 +126,7 @@ public class JdbcClientDetailsService implements ClientDetailsService, ClientReg } public ClientDetails loadClientByClientId(String clientId) { - //TODO: cache in memory + // cache in memory ClientDetails details = clientDetailsCache.getIfPresent(clientId); if(details == null) { try { diff --git a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/endpoint/AuthorizationEndpoint.java b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/endpoint/AuthorizationEndpoint.java index 91bdd3f277eb46ca9e037f9522854f7202636007..d7e6ec4aed061b86e9702742ec37b0c5eed2d5f9 100644 --- a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/endpoint/AuthorizationEndpoint.java +++ b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/endpoint/AuthorizationEndpoint.java @@ -188,7 +188,7 @@ public class AuthorizationEndpoint extends AbstractEndpoint { // such logic here, and set the approved flag on the authorization request accordingly. authorizationRequest = userApprovalHandler.checkForPreApproval(authorizationRequest, (Authentication) principal); - // TODO: is this call necessary? + // is this call necessary? boolean approved = userApprovalHandler.isApproved(authorizationRequest, (Authentication) principal); authorizationRequest.setApproved(approved); @@ -331,7 +331,7 @@ public class AuthorizationEndpoint extends AbstractEndpoint { return accessToken; } - //TODO: Authorization Code Response + // Authorization Code Response private View getAuthorizationCodeResponse(AuthorizationRequest authorizationRequest, Authentication authUser) { try { return new RedirectView(getSuccessfulRedirect(authorizationRequest, @@ -419,7 +419,7 @@ public class AuthorizationEndpoint extends AbstractEndpoint { } } - //TODO: Successful Redirect + // Successful Redirect private String getSuccessfulRedirect(AuthorizationRequest authorizationRequest, String authorizationCode) { if (authorizationCode == null) { diff --git a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/userinfo/endpoint/OAuthDefaultUserInfoAdapter.java b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/userinfo/endpoint/OAuthDefaultUserInfoAdapter.java index 91d86dc01529b16ad72df87edf692828b2fcfe81..303e86a1726425538d22c26828b20d3119e70b69 100644 --- a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/userinfo/endpoint/OAuthDefaultUserInfoAdapter.java +++ b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oauth2/provider/userinfo/endpoint/OAuthDefaultUserInfoAdapter.java @@ -56,13 +56,12 @@ public class OAuthDefaultUserInfoAdapter extends AbstractAuthorizeAdapter { @Override public String encrypt(String data, String algorithmKey, String algorithm) { - // TODO Auto-generated method stub return null; } @Override public ModelAndView authorize(UserInfo userInfo, Object app, String data,ModelAndView modelAndView) { - // TODO Auto-generated method stub + return null; } diff --git a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oidc/idtoken/OIDCIdTokenEnhancer.java b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oidc/idtoken/OIDCIdTokenEnhancer.java index 2835149b69c21904ee407682e4f59b873915cb0d..cdb929ea3b410872660582525c89d6a45594390d 100644 --- a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oidc/idtoken/OIDCIdTokenEnhancer.java +++ b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/authz/oidc/idtoken/OIDCIdTokenEnhancer.java @@ -125,7 +125,7 @@ public class OIDCIdTokenEnhancer implements TokenEnhancer { // if the auth time claim was explicitly requested OR if the client always wants the auth time, put it in if (request.getExtensions().containsKey("max_age") - || (request.getExtensions().containsKey("idtoken")) // TODO: parse the ID Token claims (#473) -- for now assume it could be in there + || (request.getExtensions().containsKey("idtoken")) // parse the ID Token claims (#473) -- for now assume it could be in there ) { DateTime loginDate=DateTime.parse(WebContext.getUserInfo().getLastLoginTime(), DateTimeFormat.forPattern("yyyy-MM-dd HH:mm:ss")); builder.claim("auth_time", loginDate.getMillis()/ 1000); diff --git a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/autoconfigure/Oauth20AutoConfiguration.java b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/autoconfigure/Oauth20AutoConfiguration.java index 3c422839f76b9f54a198c625148560bce8449fc2..a0b50a8e21880243971f7a8ef0750f6560c29684 100644 --- a/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/autoconfigure/Oauth20AutoConfiguration.java +++ b/maxkey-protocols/maxkey-protocol-oauth-2.0/src/main/java/org/maxkey/autoconfigure/Oauth20AutoConfiguration.java @@ -339,7 +339,6 @@ public class Oauth20AutoConfiguration implements InitializingBean { @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } } diff --git a/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/authz/saml/common/SignatureSecurityPolicyRule.java b/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/authz/saml/common/SignatureSecurityPolicyRule.java index 89d123b0baf2f8368dd65f5335b9329b8bba8ce6..1c6a2c56bc094f622b6dd1da1a45be7fc38a8676 100644 --- a/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/authz/saml/common/SignatureSecurityPolicyRule.java +++ b/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/authz/saml/common/SignatureSecurityPolicyRule.java @@ -86,7 +86,7 @@ public class SignatureSecurityPolicyRule implements InitializingBean, SecurityP } SignableSAMLObject samlMessage = (SignableSAMLObject) messageContext.getInboundMessage(); - //TODO:POST NEED Signed,but some is not + //POST NEED Signed,but some is not if( !samlMessage.isSigned()) { logger.debug("evaluating signature POST NEED Signed,but some is not."); throw new SecurityPolicyException("InboundMessage was not signed."); diff --git a/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/authz/saml20/binding/impl/ExtractPostBindingAdapter.java b/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/authz/saml20/binding/impl/ExtractPostBindingAdapter.java index e182be5cf7c973351962c2e539618f531eb2ac10..cd421650fcfa0ad3ec6f07c1b929d2919ccaeaee 100644 --- a/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/authz/saml20/binding/impl/ExtractPostBindingAdapter.java +++ b/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/authz/saml20/binding/impl/ExtractPostBindingAdapter.java @@ -139,7 +139,6 @@ public class ExtractPostBindingAdapter implements ExtractBindingAdapter, Initial @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } diff --git a/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/authz/saml20/consumer/endpoint/ConsumerEndpoint.java b/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/authz/saml20/consumer/endpoint/ConsumerEndpoint.java index fef0ac2c2ecaf7bb2c95870eb3714f34f2cb1f40..3ea8fa07608a99dc95b793071c56fb2acd6459db 100644 --- a/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/authz/saml20/consumer/endpoint/ConsumerEndpoint.java +++ b/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/authz/saml20/consumer/endpoint/ConsumerEndpoint.java @@ -227,7 +227,6 @@ public class ConsumerEndpoint { // 1. 获取 sp keyStore AppsSAML20Details saml20Details = saml20DetailsService.get(spId); if (saml20Details == null) { - // TODO logger.error("spid[" + spId + "] not exists"); throw new Exception(); } diff --git a/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/autoconfigure/Saml20AutoConfiguration.java b/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/autoconfigure/Saml20AutoConfiguration.java index af12afc64c2d90a2b75986c3d2966808b9d205d7..986a0250f24f304db54ca6f24f35c3451ef42cca 100644 --- a/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/autoconfigure/Saml20AutoConfiguration.java +++ b/maxkey-protocols/maxkey-protocol-saml-2.0/src/main/java/org/maxkey/autoconfigure/Saml20AutoConfiguration.java @@ -334,7 +334,6 @@ public class Saml20AutoConfiguration implements InitializingBean { @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } } diff --git a/maxkey-webs/maxkey-web-maxkey/src/main/java/org/maxkey/MaxKeyConfig.java b/maxkey-webs/maxkey-web-maxkey/src/main/java/org/maxkey/MaxKeyConfig.java index 930f2a2cd0f3f89d396b92f5cf0aca58bcbfc981..bb61a3a386e3c85cac45f20b55caf12fec8e30b0 100644 --- a/maxkey-webs/maxkey-web-maxkey/src/main/java/org/maxkey/MaxKeyConfig.java +++ b/maxkey-webs/maxkey-web-maxkey/src/main/java/org/maxkey/MaxKeyConfig.java @@ -310,7 +310,6 @@ public class MaxKeyConfig implements InitializingBean { @Override public void afterPropertiesSet() throws Exception { - // TODO Auto-generated method stub } diff --git a/maxkey-webs/maxkey-web-maxkey/src/main/java/org/maxkey/web/contorller/RegistrationController.java b/maxkey-webs/maxkey-web-maxkey/src/main/java/org/maxkey/web/contorller/RegistrationController.java index d67142711b3b9289d0ee89e9ff854ad5213491af..d28628f91f02ecfbe32de715b0a480243c76fd5b 100644 --- a/maxkey-webs/maxkey-web-maxkey/src/main/java/org/maxkey/web/contorller/RegistrationController.java +++ b/maxkey-webs/maxkey-web-maxkey/src/main/java/org/maxkey/web/contorller/RegistrationController.java @@ -124,7 +124,6 @@ public class RegistrationController { // send the email email.send(); } catch (EmailException e) { - // TODO Auto-generated catch block e.printStackTrace(); } modelAndView.addObject("registered", 0); diff --git a/maxkey-webs/maxkey-web-maxkey/src/test/java/org/maxkey/web/authentication/kerberos/KerberosPrincipal.java b/maxkey-webs/maxkey-web-maxkey/src/test/java/org/maxkey/web/authentication/kerberos/KerberosPrincipal.java index bf4931a0f0afe1fa73cde7da1d38773ddaa6284b..3f21a9be38a77a47e82a3e4084ac21c3379f10f7 100644 --- a/maxkey-webs/maxkey-web-maxkey/src/test/java/org/maxkey/web/authentication/kerberos/KerberosPrincipal.java +++ b/maxkey-webs/maxkey-web-maxkey/src/test/java/org/maxkey/web/authentication/kerberos/KerberosPrincipal.java @@ -39,14 +39,12 @@ public class KerberosPrincipal { * */ public KerberosPrincipal() { - // TODO Auto-generated constructor stub } /** * @param args */ public static void main(String[] args) { - // TODO Auto-generated method stub String kerberosPrincipal="Administrator@CONNSEC.COM"; kerberosPrincipal=kerberosPrincipal.substring(0, kerberosPrincipal.indexOf("@")); System.out.println(kerberosPrincipal); diff --git a/maxkey-webs/maxkey-web-mgt/src/main/java/org/maxkey/MaxKeyMgtApplication.java b/maxkey-webs/maxkey-web-mgt/src/main/java/org/maxkey/MaxKeyMgtApplication.java index 85414969fd5006f81d70dbd632468e8de22751de..4bd2e296917ab72c02cc1f37c1baea74fd6fac14 100644 --- a/maxkey-webs/maxkey-web-mgt/src/main/java/org/maxkey/MaxKeyMgtApplication.java +++ b/maxkey-webs/maxkey-web-mgt/src/main/java/org/maxkey/MaxKeyMgtApplication.java @@ -36,11 +36,12 @@ import org.springframework.context.annotation.ComponentScan; @ComponentScan(basePackages = { "org.maxkey.MaxKeyMgtConfig", "org.maxkey.MaxKeyMgtMvcConfig", + "org.maxkey.MaxKeyMgtJobs", "org.maxkey.web.interceptor", "org.maxkey.configuration", - "org.maxkey.domain", - "org.maxkey.domain.apps", - "org.maxkey.domain.userinfo", + "org.maxkey.entity", + "org.maxkey.entity.apps", + "org.maxkey.entity.userinfo", "org.maxkey.web.endpoint", "org.maxkey.web.contorller", "org.maxkey.web.apps.contorller", @@ -70,8 +71,7 @@ public class MaxKeyMgtApplication extends SpringBootServletInitializer { try { initWebContext.init(null); } catch (ServletException e) { - e.printStackTrace(); - _logger.error("",e); + _logger.error("Exception ",e); } _logger.info("MaxKeyMgt at "+new DateTime()); _logger.info("MaxKeyMgt Server Port "+applicationContext.getBean(ApplicationConfig.class).getPort()); diff --git a/maxkey-webs/maxkey-web-mgt/src/main/java/org/maxkey/MaxKeyMgtConfig.java b/maxkey-webs/maxkey-web-mgt/src/main/java/org/maxkey/MaxKeyMgtConfig.java index 56f1e8b1d923dd72597eb54a1047c1ad120f40d2..d03e22937681a5c2fae2aab015ae18f576fa55c0 100644 --- a/maxkey-webs/maxkey-web-mgt/src/main/java/org/maxkey/MaxKeyMgtConfig.java +++ b/maxkey-webs/maxkey-web-mgt/src/main/java/org/maxkey/MaxKeyMgtConfig.java @@ -23,27 +23,13 @@ import org.maxkey.authz.oauth2.provider.token.DefaultTokenServices; import org.maxkey.authz.oauth2.provider.token.TokenStore; import org.maxkey.authz.oauth2.provider.token.store.InMemoryTokenStore; import org.maxkey.authz.oauth2.provider.token.store.RedisTokenStore; -import org.maxkey.jobs.DynamicGroupsJob; import org.maxkey.password.onetimepwd.AbstractOtpAuthn; import org.maxkey.password.onetimepwd.impl.TimeBasedOtpAuthn; import org.maxkey.persistence.db.LoginHistoryService; import org.maxkey.persistence.db.LoginService; import org.maxkey.persistence.db.PasswordPolicyValidator; import org.maxkey.persistence.redis.RedisConnectionFactory; -import org.maxkey.persistence.service.GroupsService; import org.maxkey.persistence.service.UserInfoService; -import org.opensaml.xml.ConfigurationException; -import org.quartz.CronScheduleBuilder; -import org.quartz.CronTrigger; -import org.quartz.Job; -import org.quartz.JobBuilder; -import org.quartz.JobDataMap; -import org.quartz.JobDetail; -import org.quartz.Scheduler; -import org.quartz.SchedulerException; -import org.quartz.TriggerBuilder; -import org.apache.mybatis.jpa.persistence.JpaBaseEntity; -import org.apache.mybatis.jpa.persistence.JpaBaseService; import org.maxkey.authn.realm.jdbc.JdbcAuthenticationRealm; import org.maxkey.authn.support.rememberme.AbstractRemeberMeService; import org.slf4j.Logger; @@ -53,7 +39,6 @@ import org.springframework.beans.factory.annotation.Value; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; import org.springframework.jdbc.core.JdbcTemplate; -import org.springframework.scheduling.quartz.SchedulerFactoryBean; import org.springframework.security.crypto.password.PasswordEncoder; @Configuration @@ -108,7 +93,7 @@ public class MaxKeyMgtConfig implements InitializingBean { } - //浠ヤ笅鍐呭鍙互娉ㄩ噴鎺夊悗鍐峹ml涓厤缃�,xml寮曞叆鍦∕axKeyMgtApplication涓� + //authenticationRealm for MaxKeyMgtApplication @Bean(name = "authenticationRealm") public JdbcAuthenticationRealm authenticationRealm( PasswordEncoder passwordEncoder, @@ -138,48 +123,7 @@ public class MaxKeyMgtConfig implements InitializingBean { _logger.debug("TimeBasedOtpAuthn inited."); return tfaOtpAuthn; } - - /** - * schedulerJobsInit. - * @return schedulerJobsInit - * @throws ConfigurationException - * @throws SchedulerException - */ - @Bean(name = "schedulerJobs") - public String schedulerJobs( - SchedulerFactoryBean schedulerFactoryBean, - GroupsService groupsService, - @Value("${maxkey.job.cron.dynamicgroups}") String cronSchedule - ) throws SchedulerException { - - Scheduler scheduler = schedulerFactoryBean.getScheduler(); - //dynamicGroupsJob("DynamicGroups",DynamicGroupsJob.class,scheduler,groupsService,cronSchedule); - - return "schedulerJobs"; - } - - - public void dynamicGroupsJob(String jobName, - Class cls, - Scheduler scheduler, - JpaBaseService service, - String cronSchedule) throws SchedulerException { - JobDetail jobDetail = - JobBuilder.newJob(cls) - .withIdentity(jobName + "Job", jobName) - .build(); - JobDataMap jobDataMap = new JobDataMap(); - jobDataMap.put("service", service); - CronScheduleBuilder scheduleBuilder = CronScheduleBuilder.cronSchedule(cronSchedule); - CronTrigger cronTrigger = - TriggerBuilder.newTrigger() - .withIdentity("trigger" + jobName, jobName) - .usingJobData(jobDataMap) - .withSchedule(scheduleBuilder) - .build(); - scheduler.scheduleJob(jobDetail,cronTrigger); - } - + @Override public void afterPropertiesSet() throws Exception { diff --git a/maxkey-webs/maxkey-web-mgt/src/main/java/org/maxkey/MaxKeyMgtJobs.java b/maxkey-webs/maxkey-web-mgt/src/main/java/org/maxkey/MaxKeyMgtJobs.java new file mode 100644 index 0000000000000000000000000000000000000000..49b7da6da70910364fc8fa1ed20e251f5948219d --- /dev/null +++ b/maxkey-webs/maxkey-web-mgt/src/main/java/org/maxkey/MaxKeyMgtJobs.java @@ -0,0 +1,142 @@ +/* + * Copyright [2020] [MaxKey of copyright http://www.maxkey.top] + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +package org.maxkey; + +import org.maxkey.jobs.AccountsStrategyJob; +import org.maxkey.jobs.DynamicGroupsJob; +import org.maxkey.persistence.service.AccountsService; +import org.maxkey.persistence.service.GroupsService; +import org.opensaml.xml.ConfigurationException; +import org.quartz.CronScheduleBuilder; +import org.quartz.CronTrigger; +import org.quartz.Job; +import org.quartz.JobBuilder; +import org.quartz.JobDataMap; +import org.quartz.JobDetail; +import org.quartz.Scheduler; +import org.quartz.SchedulerException; +import org.quartz.TriggerBuilder; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.InitializingBean; +import org.springframework.beans.factory.annotation.Value; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.scheduling.quartz.SchedulerFactoryBean; + +@Configuration +public class MaxKeyMgtJobs implements InitializingBean { + private static final Logger _logger = LoggerFactory.getLogger(MaxKeyMgtJobs.class); + + /** + * schedulerJobsInit. + * @return schedulerJobsInit + * @throws ConfigurationException + * @throws SchedulerException + */ + @Bean(name = "schedulerJobs") + public String schedulerJobs( + SchedulerFactoryBean schedulerFactoryBean, + GroupsService groupsService, + AccountsService accountsService, + @Value("${maxkey.job.cron.schedule}") String cronSchedule + ) throws SchedulerException { + _logger.debug("cron schedule : " + cronSchedule); + + Scheduler scheduler = schedulerFactoryBean.getScheduler(); + + addDynamicGroupsJob( + DynamicGroupsJob.class, + scheduler, + groupsService, + cronSchedule, + "DynamicGroups" + ); + + addAccountsStrategyJob( + AccountsStrategyJob.class, + scheduler, + accountsService, + cronSchedule, + "AccountsStrategy" + ); + + return "schedulerJobs"; + } + + + private void addDynamicGroupsJob( Class jobClass, + Scheduler scheduler , + GroupsService groupsService, + String cronSchedule, + String identity + ) throws SchedulerException { + + _logger.debug("add DynamicGroups Job"); + JobDetail jobDetail = + JobBuilder.newJob(jobClass) + .withIdentity(identity + "Job", identity + "Group") + .build(); + + JobDataMap jobDataMap = new JobDataMap(); + jobDataMap.put("groupsService", groupsService); + CronScheduleBuilder scheduleBuilder = CronScheduleBuilder.cronSchedule(cronSchedule); + + CronTrigger cronTrigger = + TriggerBuilder.newTrigger() + .withIdentity("trigger" + identity, identity + "TriggerGroup") + .usingJobData(jobDataMap) + .withSchedule(scheduleBuilder) + .build(); + + scheduler.scheduleJob(jobDetail,cronTrigger); + } + + private void addAccountsStrategyJob(Class jobClass, + Scheduler scheduler , + AccountsService accountsService, + String cronSchedule, + String identity + ) throws SchedulerException { + + _logger.debug("add Accounts Strategy Job"); + JobDetail jobDetail = + JobBuilder.newJob(jobClass) + .withIdentity(identity + "Job", identity + "Group") + .build(); + + JobDataMap jobDataMap = new JobDataMap(); + jobDataMap.put("accountsService", accountsService); + + CronScheduleBuilder scheduleBuilder = CronScheduleBuilder.cronSchedule(cronSchedule); + CronTrigger cronTrigger = + TriggerBuilder.newTrigger() + .withIdentity("trigger" + identity, identity + "TriggerGroup") + .usingJobData(jobDataMap) + .withSchedule(scheduleBuilder) + .build(); + + scheduler.scheduleJob(jobDetail,cronTrigger); + } + + @Override + public void afterPropertiesSet() throws Exception { + + } + +} diff --git a/maxkey-webs/maxkey-web-mgt/src/main/resources/application-http.properties b/maxkey-webs/maxkey-web-mgt/src/main/resources/application-http.properties index c86ca88439174fba819bd1f7a47f6c40a6967396..dff76be5504de382e5767d751caa6ba9e7190124 100644 --- a/maxkey-webs/maxkey-web-mgt/src/main/resources/application-http.properties +++ b/maxkey-webs/maxkey-web-mgt/src/main/resources/application-http.properties @@ -214,8 +214,8 @@ maxkey.oidc.metadata.userinfoEndpoint =${maxkey.server.authz.uri}/api/ ############################################################################# #Job Scheduler # ############################################################################# -#one hour for refresh dynamic groups -maxkey.job.cron.dynamicgroups =0 0 0/1 * * ? +#one hour for refresh Schedule +maxkey.job.cron.schedule =0 0 0/1 * * ? maxkey.job.cron.enable =true ############################################################################