提交 4bb0a0d6 编写于 作者: H helinwang 提交者: GitHub

Merge pull request #1239 from helinwang/issue_1238

remove `allow_inefficient_sparse_update` since it's only defined but …
...@@ -127,11 +127,6 @@ ...@@ -127,11 +127,6 @@
<td class="left"></td><td class="left"></td><td class="left"></td><td class="left"></td> <td class="left"></td><td class="left"></td><td class="left"></td><td class="left"></td>
</tr> </tr>
<tr>
<td class="left">allow_inefficient_sparse_update</td>
<td class="left"></td><td class="left"></td><td class="left"></td><td class="left"></td>
</tr>
<tr> <tr>
<td class="left">start_pass</td> <td class="left">start_pass</td>
<td class="left"></td><td class="left"></td><td class="left"></td><td class="left"></td> <td class="left"></td><td class="left"></td><td class="left"></td><td class="left"></td>
......
...@@ -127,11 +127,6 @@ It looks like there are a lot of arguments. However, most of them are for develo ...@@ -127,11 +127,6 @@ It looks like there are a lot of arguments. However, most of them are for develo
<td class="left"></td><td class="left"></td><td class="left"></td><td class="left"></td> <td class="left"></td><td class="left"></td><td class="left"></td><td class="left"></td>
</tr> </tr>
<tr>
<td class="left">allow_inefficient_sparse_update</td>
<td class="left"></td><td class="left"></td><td class="left"></td><td class="left"></td>
</tr>
<tr> <tr>
<td class="left">start_pass</td> <td class="left">start_pass</td>
<td class="left"></td><td class="left"></td><td class="left"></td><td class="left"></td> <td class="left"></td><td class="left"></td><td class="left"></td><td class="left"></td>
......
...@@ -306,10 +306,6 @@ ...@@ -306,10 +306,6 @@
- 指示是否显示参数服务器上的稀疏参数分布的日志细节. - 指示是否显示参数服务器上的稀疏参数分布的日志细节.
- 类型: bool (默认: 0). - 类型: bool (默认: 0).
* `--allow_inefficient_sparse_update`
- 指示是否允许低效率的稀疏更新.
- 类型: bool (默认: 0).
* `--check_sparse_distribution_batches` * `--check_sparse_distribution_batches`
- 每运行多少个批次执行一次稀疏参数分布的检查. - 每运行多少个批次执行一次稀疏参数分布的检查.
- 类型: int32 (默认: 100). - 类型: int32 (默认: 100).
......
...@@ -310,10 +310,6 @@ ...@@ -310,10 +310,6 @@
- show log details for sparse parameter distribution in pserver. - show log details for sparse parameter distribution in pserver.
- type: bool (default: 0). - type: bool (default: 0).
* `--allow_inefficient_sparse_update`
- Whether to allow inefficient sparse update.
- type: bool (default: 0).
* `--check_sparse_distribution_batches` * `--check_sparse_distribution_batches`
- Running sparse parameter distribution check every so many batches. - Running sparse parameter distribution check every so many batches.
- type: int32 (default: 100). - type: int32 (default: 100).
......
...@@ -24,10 +24,6 @@ limitations under the License. */ ...@@ -24,10 +24,6 @@ limitations under the License. */
#include "paddle/utils/Thread.h" #include "paddle/utils/Thread.h"
#include "paddle/utils/Util.h" #include "paddle/utils/Util.h"
DEFINE_bool(allow_inefficient_sparse_update,
false,
"Whether to allow inefficient sparse update");
namespace paddle { namespace paddle {
const unsigned int SparseRowCpuMatrix::kUnusedId_ = -1U; const unsigned int SparseRowCpuMatrix::kUnusedId_ = -1U;
......
...@@ -21,8 +21,6 @@ limitations under the License. */ ...@@ -21,8 +21,6 @@ limitations under the License. */
#include "RowBuffer.h" #include "RowBuffer.h"
#include "paddle/utils/Util.h" #include "paddle/utils/Util.h"
DECLARE_bool(allow_inefficient_sparse_update);
namespace paddle { namespace paddle {
/** /**
...@@ -183,11 +181,10 @@ protected: ...@@ -183,11 +181,10 @@ protected:
inline void checkStoreSize() { inline void checkStoreSize() {
if (buf_->isAutoGrowth()) { if (buf_->isAutoGrowth()) {
if (buf_->getRowCount() > 0.5 * height_) { if (buf_->getRowCount() > 0.5 * height_) {
LOG(WARNING) LOG(WARNING) << "There are more than 0.5*height ("
<< "There are more than 0.5*height (" << localIndices_->size() << localIndices_->size() << ") rows are used for sparse "
<< ") rows are used for sparse "
<< "update, which is not efficient. Considering not use " << "update, which is not efficient. Considering not use "
<< "sparse_update or set --allow_inefficient_sparse_update=true"; << "sparse_update.";
} }
} else { } else {
CHECK_LE(localIndices_->size(), buf_->getRowCount()); CHECK_LE(localIndices_->size(), buf_->getRowCount());
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册