From 6ff0bb47ea6f7d3b464910ea9b1cada0024dfc56 Mon Sep 17 00:00:00 2001 From: Shengliang Guan Date: Wed, 19 Aug 2020 09:58:05 +0800 Subject: [PATCH] TD-1090 --- cmake/platform.inc | 3 +-- deps/cJson/src/cJSON.c | 6 +++--- src/os/inc/osSocket.h | 1 + src/os/inc/osWindows.h | 1 + src/util/src/tsocket.c | 6 +++--- 5 files changed, 9 insertions(+), 8 deletions(-) diff --git a/cmake/platform.inc b/cmake/platform.inc index 11ab8f301d..71eee9d507 100755 --- a/cmake/platform.inc +++ b/cmake/platform.inc @@ -68,8 +68,7 @@ ELSEIF (${CMAKE_SYSTEM_NAME} MATCHES "Windows") MESSAGE(STATUS "The current platform is Windows 64-bit") ELSE () SET(TD_WINDOWS_32 TRUE) - MESSAGE(FATAL_ERROR "The current platform is Windows 32-bit, not supported yet") - EXIT () + MESSAGE(STATUS "The current platform is Windows 32-bit") ENDIF () ELSE() MESSAGE(FATAL_ERROR "The current platform is not Linux/Darwin/Windows, stop compile") diff --git a/deps/cJson/src/cJSON.c b/deps/cJson/src/cJSON.c index ecf0e05b42..f0ef9f6fe1 100644 --- a/deps/cJson/src/cJSON.c +++ b/deps/cJson/src/cJSON.c @@ -359,12 +359,12 @@ static unsigned char* ensure(printbuffer * const p, size_t needed) } /* calculate new buffer size */ - if (needed > (LLONG_MAX / 2)) + if (needed > (LONG_MAX / 2)) { /* overflow of int, use LLONG_MAX if possible */ - if (needed <= LLONG_MAX) + if (needed <= LONG_MAX) { - newsize = LLONG_MAX; + newsize = LONG_MAX; } else { diff --git a/src/os/inc/osSocket.h b/src/os/inc/osSocket.h index ecc69ec3d3..0ab3ff0fca 100644 --- a/src/os/inc/osSocket.h +++ b/src/os/inc/osSocket.h @@ -25,6 +25,7 @@ extern "C" { #define taosSendto(sockfd, buf, len, flags, dest_addr, addrlen) sendto(sockfd, buf, len, flags, dest_addr, addrlen) #define taosReadSocket(fd, buf, len) read(fd, buf, len) #define taosWriteSocket(fd, buf, len) write(fd, buf, len) + #define taosCloseSocketNoCheck(x) close(x) #define taosCloseSocket(x) \ { \ if (FD_VALID(x)) { \ diff --git a/src/os/inc/osWindows.h b/src/os/inc/osWindows.h index 994e3b991c..348f50891e 100644 --- a/src/os/inc/osWindows.h +++ b/src/os/inc/osWindows.h @@ -90,6 +90,7 @@ extern "C" { #define taosSendto(sockfd, buf, len, flags, dest_addr, addrlen) sendto((SOCKET)sockfd, buf, len, flags, dest_addr, addrlen) #define taosWriteSocket(fd, buf, len) send((SOCKET)fd, buf, len, 0) #define taosReadSocket(fd, buf, len) recv((SOCKET)fd, buf, len, 0) + #define taosCloseSocketNoCheck(fd) closesocket((SOCKET)fd) #define taosCloseSocket(fd) closesocket((SOCKET)fd) typedef SOCKET eventfd_t; #define eventfd(a, b) -1 diff --git a/src/util/src/tsocket.c b/src/util/src/tsocket.c index 2de3490459..f4778f50ce 100644 --- a/src/util/src/tsocket.c +++ b/src/util/src/tsocket.c @@ -233,7 +233,7 @@ SOCKET taosOpenUdpSocket(uint32_t ip, uint16_t port) { if ((sockFd = (int)socket(AF_INET, SOCK_DGRAM, 0)) <= 2) { uError("failed to open udp socket: %d (%s)", errno, strerror(errno)); - close(sockFd); + taosCloseSocketNoCheck(sockFd); return -1; } @@ -268,7 +268,7 @@ SOCKET taosOpenTcpClientSocket(uint32_t destIp, uint16_t destPort, uint32_t clie if (sockFd <= 2) { uError("failed to open the socket: %d (%s)", errno, strerror(errno)); - close(sockFd); + taosCloseSocketNoCheck(sockFd); return -1; } @@ -375,7 +375,7 @@ SOCKET taosOpenTcpServerSocket(uint32_t ip, uint16_t port) { if ((sockFd = (int)socket(AF_INET, SOCK_STREAM, IPPROTO_TCP)) <= 2) { uError("failed to open TCP socket: %d (%s)", errno, strerror(errno)); - close(sockFd); + taosCloseSocketNoCheck(sockFd); return -1; } -- GitLab