From fea33a0dead8bc4be12e8841f5e39e42498157a7 Mon Sep 17 00:00:00 2001 From: CyrusNajmabadi Date: Sat, 8 Oct 2016 16:14:57 -0700 Subject: [PATCH] Use the new base class to simplify code. --- ...harpInlineDeclarationDiagnosticAnalyzer.cs | 31 +++++-------------- 1 file changed, 8 insertions(+), 23 deletions(-) diff --git a/src/Features/CSharp/Portable/InlineDeclaration/CSharpInlineDeclarationDiagnosticAnalyzer.cs b/src/Features/CSharp/Portable/InlineDeclaration/CSharpInlineDeclarationDiagnosticAnalyzer.cs index 82a7b678315..3d6d2f5a6d1 100644 --- a/src/Features/CSharp/Portable/InlineDeclaration/CSharpInlineDeclarationDiagnosticAnalyzer.cs +++ b/src/Features/CSharp/Portable/InlineDeclaration/CSharpInlineDeclarationDiagnosticAnalyzer.cs @@ -22,35 +22,20 @@ namespace Microsoft.CodeAnalysis.CSharp.InlineDeclaration /// /// [DiagnosticAnalyzer(LanguageNames.CSharp)] - internal class CSharpInlineDeclarationDiagnosticAnalyzer : DiagnosticAnalyzer + internal class CSharpInlineDeclarationDiagnosticAnalyzer : AbstractCodeStyleDiagnosticAnalyzer { - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(FeaturesResources.Inline_variable_declaration), FeaturesResources.ResourceManager, typeof(FeaturesResources)); - private static readonly LocalizableString s_localizableMessage = new LocalizableResourceString(nameof(FeaturesResources.Inline_variable_declaration), FeaturesResources.ResourceManager, typeof(FeaturesResources)); - - private static DiagnosticDescriptor s_descriptor = - CreateDescriptor(DiagnosticSeverity.Hidden); - - private static DiagnosticDescriptor s_unnecessaryCodeDescriptor = - CreateDescriptor(DiagnosticSeverity.Hidden, customTags: DiagnosticCustomTags.Unnecessary); - - public override ImmutableArray SupportedDiagnostics - => ImmutableArray.Create(s_descriptor, s_unnecessaryCodeDescriptor); + public CSharpInlineDeclarationDiagnosticAnalyzer() + : base(IDEDiagnosticIds.InlineDeclarationDiagnosticId, + new LocalizableResourceString(nameof(FeaturesResources.Inline_variable_declaration), FeaturesResources.ResourceManager, typeof(FeaturesResources)), + new LocalizableResourceString(nameof(FeaturesResources.Inline_variable_declaration), FeaturesResources.ResourceManager, typeof(FeaturesResources))) + { + } public DiagnosticAnalyzerCategory GetAnalyzerCategory() => DiagnosticAnalyzerCategory.SemanticDocumentAnalysis; public bool OpenFileOnly(Workspace workspace) => false; - private static DiagnosticDescriptor CreateDescriptor(DiagnosticSeverity severity, params string[] customTags) - => new DiagnosticDescriptor( - IDEDiagnosticIds.InlineDeclarationDiagnosticId, - s_localizableTitle, - s_localizableMessage, - DiagnosticCategory.Style, - severity, - isEnabledByDefault: true, - customTags: customTags); - public override void Initialize(AnalysisContext context) { context.RegisterSyntaxNodeAction(AnalyzeSyntaxNode, SyntaxKind.Argument); @@ -212,7 +197,7 @@ private void AnalyzeSyntaxNode(SyntaxNodeAnalysisContext context) : localDeclarator; context.ReportDiagnostic(Diagnostic.Create( - CreateDescriptor(option.Notification.Value), + CreateDescriptor(this.Id, option.Notification.Value), reportNode.GetLocation(), additionalLocations: allLocations)); } -- GitLab