Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
fc628b5c
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
fc628b5c
编写于
12月 04, 2017
作者:
S
Sam Harwell
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Avoid a capturing local variables on the GetOptionsAsync fast path
上级
cb579f24
变更
1
显示空白变更内容
内联
并排
Showing
1 changed file
with
14 addition
and
8 deletion
+14
-8
src/Workspaces/Core/Portable/Workspace/Solution/Document.cs
src/Workspaces/Core/Portable/Workspace/Solution/Document.cs
+14
-8
未找到文件。
src/Workspaces/Core/Portable/Workspace/Solution/Document.cs
浏览文件 @
fc628b5c
...
...
@@ -467,6 +467,7 @@ public Task<DocumentOptionSet> GetOptionsAsync(CancellationToken cancellationTok
return
GetOptionsAsync
(
Project
.
Solution
.
Options
,
cancellationToken
);
}
[
PerformanceSensitive
(
"https://github.com/dotnet/roslyn/issues/23582"
,
AllowCaptures
=
false
)]
internal
Task
<
DocumentOptionSet
>
GetOptionsAsync
(
OptionSet
solutionOptions
,
CancellationToken
cancellationToken
)
{
// TODO: we have this workaround since Solution.Options is not actually snapshot but just return Workspace.Options which violate snapshot model.
...
...
@@ -474,6 +475,14 @@ internal Task<DocumentOptionSet> GetOptionsAsync(OptionSet solutionOptions, Canc
// also didn't check whether Workspace.Option is same as before or not. all wierd-ness come from the root cause of Solution.Options violating
// snapshot model. once that is fixed, we can remove this workaround - https://github.com/dotnet/roslyn/issues/19284
if
(
_cachedOptions
==
null
)
{
InitializeCachedOptions
(
solutionOptions
,
cancellationToken
);
}
return
_cachedOptions
.
GetValueAsync
(
cancellationToken
);
}
private
void
InitializeCachedOptions
(
OptionSet
solutionOptions
,
CancellationToken
cancellationToken
)
{
var
newAsyncLazy
=
new
AsyncLazy
<
DocumentOptionSet
>(
async
c
=>
{
...
...
@@ -484,8 +493,5 @@ internal Task<DocumentOptionSet> GetOptionsAsync(OptionSet solutionOptions, Canc
Interlocked
.
CompareExchange
(
ref
_cachedOptions
,
newAsyncLazy
,
comparand
:
null
);
}
return
_cachedOptions
.
GetValueAsync
(
cancellationToken
);
}
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录