From f8fca30e3d0bccc1fb8bcd1610214c60c2c0799f Mon Sep 17 00:00:00 2001 From: Sam Harwell Date: Fri, 31 Jul 2020 13:54:54 -0700 Subject: [PATCH] Document ignored cancellation token --- src/VisualStudio/Core/Impl/CodeModel/FileCodeModel.cs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/VisualStudio/Core/Impl/CodeModel/FileCodeModel.cs b/src/VisualStudio/Core/Impl/CodeModel/FileCodeModel.cs index af3058e37ec..11ae6d76496 100644 --- a/src/VisualStudio/Core/Impl/CodeModel/FileCodeModel.cs +++ b/src/VisualStudio/Core/Impl/CodeModel/FileCodeModel.cs @@ -123,7 +123,14 @@ internal override void Shutdown() // We don't want to block up file removal on the UI thread since we want that path to stay asynchronous. CodeModelService.DetachFormatTrackingToBuffer(_invisibleEditor.TextBuffer); - State.ProjectCodeModelFactory.ScheduleDeferredCleanupTask(cancellationToken => { _invisibleEditor.Dispose(); }); + State.ProjectCodeModelFactory.ScheduleDeferredCleanupTask( + cancellationToken => + { + // Ignore cancellationToken: we always need to call Dispose since it triggers the file save. + _ = cancellationToken; + + _invisibleEditor.Dispose(); + }); } base.Shutdown(); -- GitLab