Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
f714fcda
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f714fcda
编写于
9月 18, 2020
作者:
M
Manish Vasani
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Address feedback
上级
47a06b37
变更
4
展开全部
显示空白变更内容
内联
并排
Showing
4 changed file
with
68 addition
and
71 deletion
+68
-71
src/Features/Core/Portable/Diagnostics/DiagnosticAnalyzerService_BuildSynchronization.cs
...nostics/DiagnosticAnalyzerService_BuildSynchronization.cs
+2
-2
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_BuildSynchronization.cs
...eV2/DiagnosticIncrementalAnalyzer_BuildSynchronization.cs
+1
-1
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
...mentation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
+53
-56
src/VisualStudio/Core/Test/Diagnostics/ExternalDiagnosticUpdateSourceTests.vb
...e/Test/Diagnostics/ExternalDiagnosticUpdateSourceTests.vb
+12
-12
未找到文件。
src/Features/Core/Portable/Diagnostics/DiagnosticAnalyzerService_BuildSynchronization.cs
浏览文件 @
f714fcda
...
...
@@ -15,11 +15,11 @@ internal partial class DiagnosticAnalyzerService
///
/// no cancellationToken since this can't be cancelled
/// </summary>
public
Task
InitializeSynchronizeWithBuildAsync
(
Solution
solution
,
CancellationToken
cancellationToken
)
public
Task
InitializeSynchroniz
ationStat
eWithBuildAsync
(
Solution
solution
,
CancellationToken
cancellationToken
)
{
if
(
_map
.
TryGetValue
(
solution
.
Workspace
,
out
var
analyzer
))
{
return
analyzer
.
InitializeSynchronizeWithBuildAsync
(
solution
,
cancellationToken
);
return
analyzer
.
InitializeSynchroniz
ationStat
eWithBuildAsync
(
solution
,
cancellationToken
);
}
return
Task
.
CompletedTask
;
...
...
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_BuildSynchronization.cs
浏览文件 @
f714fcda
...
...
@@ -24,7 +24,7 @@ namespace Microsoft.CodeAnalysis.Diagnostics.EngineV2
{
internal
partial
class
DiagnosticIncrementalAnalyzer
{
public
async
Task
InitializeSynchronizeWithBuildAsync
(
Solution
solution
,
CancellationToken
cancellationToken
)
public
async
Task
InitializeSynchroniz
ationStat
eWithBuildAsync
(
Solution
solution
,
CancellationToken
cancellationToken
)
{
foreach
(
var
project
in
solution
.
Projects
)
{
...
...
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
浏览文件 @
f714fcda
此差异已折叠。
点击以展开。
src/VisualStudio/Core/Test/Diagnostics/ExternalDiagnosticUpdateSourceTests.vb
浏览文件 @
f714fcda
...
...
@@ -31,7 +31,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics
Using
workspace
=
TestWorkspace
.
CreateCSharp
(
String
.
Empty
)
Dim
waiter
=
New
AsynchronousOperationListener
()
Dim
service
=
New
TestDiagnosticAnalyzerService
()
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
,
CancellationToken
.
None
)
Assert
.
False
(
source
.
SupportGetDiagnostics
)
End
Using
...
...
@@ -42,7 +42,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics
Using
workspace
=
TestWorkspace
.
CreateCSharp
(
String
.
Empty
)
Dim
waiter
=
New
AsynchronousOperationListener
()
Dim
service
=
New
TestDiagnosticAnalyzerService
()
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
,
CancellationToken
.
None
)
Dim
project
=
workspace
.
CurrentSolution
.
Projects
.
First
()
Dim
diagnostic
=
GetDiagnosticData
(
project
.
Id
)
...
...
@@ -77,7 +77,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics
workspace
.
TryApplyChanges
(
workspace
.
CurrentSolution
.
WithAnalyzerReferences
({
analyzerReference
}))
Dim
service
=
New
TestDiagnosticAnalyzerService
()
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
,
CancellationToken
.
None
)
Dim
project
=
workspace
.
CurrentSolution
.
Projects
.
First
()
source
.
OnSolutionBuildStarted
()
...
...
@@ -92,7 +92,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics
Using
workspace
=
TestWorkspace
.
CreateCSharp
(
String
.
Empty
)
Dim
waiter
=
New
AsynchronousOperationListener
()
Dim
service
=
New
TestDiagnosticAnalyzerService
()
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
,
CancellationToken
.
None
)
Dim
project
=
workspace
.
CurrentSolution
.
Projects
.
First
()
source
.
OnSolutionBuildStarted
()
...
...
@@ -110,7 +110,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics
Dim
diagnostic
=
GetDiagnosticData
(
project
.
Id
)
Dim
service
=
New
TestDiagnosticAnalyzerService
(
ImmutableArray
.
Create
(
diagnostic
))
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
,
CancellationToken
.
None
)
Dim
map
=
New
Dictionary
(
Of
DocumentId
,
HashSet
(
Of
DiagnosticData
))()
map
.
Add
(
project
.
DocumentIds
.
First
(),
New
HashSet
(
Of
DiagnosticData
)(
...
...
@@ -137,7 +137,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics
Dim
diagnostic
=
GetDiagnosticData
(
project
.
Id
)
Dim
service
=
New
TestDiagnosticAnalyzerService
()
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
,
CancellationToken
.
None
)
AddHandler
source
.
BuildProgressChanged
,
Sub
(
o
,
progress
)
If
progress
=
ExternalErrorDiagnosticUpdateSource
.
BuildProgress
.
Done
Then
Assert
.
Equal
(
2
,
source
.
GetBuildErrors
().
Length
)
...
...
@@ -190,7 +190,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics
Dim
diagnostic
=
GetDiagnosticData
(
project
.
Id
)
Dim
service
=
New
TestDiagnosticAnalyzerService
()
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
,
CancellationToken
.
None
)
' we shouldn't crash here
source
.
AddNewErrors
(
project
.
Id
,
diagnostic
)
...
...
@@ -223,7 +223,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics
Dim
service
=
Assert
.
IsType
(
Of
DiagnosticAnalyzerService
)(
workspace
.
GetService
(
Of
IDiagnosticAnalyzerService
)())
Dim
registation
=
service
.
CreateIncrementalAnalyzer
(
workspace
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
,
CancellationToken
.
None
)
Dim
diagnostic
=
GetDiagnosticData
(
project
.
Id
,
isBuildDiagnostic
:
=
True
,
id
:
=
analyzer
.
SupportedDiagnostics
(
0
).
Id
)
source
.
AddNewErrors
(
project
.
Id
,
diagnostic
)
...
...
@@ -256,7 +256,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics
Dim
service
=
Assert
.
IsType
(
Of
DiagnosticAnalyzerService
)(
workspace
.
GetService
(
Of
IDiagnosticAnalyzerService
)())
Dim
registation
=
service
.
CreateIncrementalAnalyzer
(
workspace
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
,
CancellationToken
.
None
)
Dim
diagnostic
=
GetDiagnosticData
(
project
.
Id
,
isBuildDiagnostic
:
=
True
,
id
:
=
analyzer
.
SupportedDiagnostics
(
0
).
Id
)
source
.
AddNewErrors
(
project
.
Id
,
diagnostic
)
...
...
@@ -292,7 +292,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics
Dim
service
=
Assert
.
IsType
(
Of
DiagnosticAnalyzerService
)(
workspace
.
GetService
(
Of
IDiagnosticAnalyzerService
)())
Dim
registation
=
service
.
CreateIncrementalAnalyzer
(
workspace
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
,
CancellationToken
.
None
)
Dim
diagnostic
=
GetDiagnosticData
(
project
.
Id
,
isBuildDiagnostic
:
=
True
,
id
:
=
analyzer
.
SupportedDiagnostics
(
0
).
Id
)
source
.
AddNewErrors
(
project
.
Id
,
diagnostic
)
...
...
@@ -322,7 +322,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics
Dim
projectId2
=
workspace
.
CurrentSolution
.
ProjectIds
(
1
)
Dim
service
=
New
TestDiagnosticAnalyzerService
()
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
,
CancellationToken
.
None
)
source
.
AddNewErrors
(
projectId1
,
GetDiagnosticData
(
projectId1
))
Await
waiter
.
ExpeditedWaitAsync
()
...
...
@@ -360,7 +360,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics
Assert
.
IsType
(
Of
MockDiagnosticUpdateSourceRegistrationService
)(
workspace
.
GetService
(
Of
IDiagnosticUpdateSourceRegistrationService
)())
Dim
service
=
Assert
.
IsType
(
Of
DiagnosticAnalyzerService
)(
workspace
.
GetService
(
Of
IDiagnosticAnalyzerService
)())
Dim
registation
=
service
.
CreateIncrementalAnalyzer
(
workspace
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
)
Dim
source
=
New
ExternalErrorDiagnosticUpdateSource
(
workspace
,
service
,
waiter
,
CancellationToken
.
None
)
Dim
diagnostic
=
New
DiagnosticData
(
id
:
=
"CS1002"
,
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录