Merge pull request #32145 from jasonmalinowski/fix-projects-not-being-removed-from-workspace

Fix projects being removed from the Workspace

src/VisualStudio/CSharp/Test/ProjectSystemShim/LifetimeTests.cs

@@ -23,6 +23,8 @@ public void DisconnectingAProjectDoesNotLeak()
 
                 project.UseReference(p => p.Disconnect());
                 project.AssertReleased();
+
+                Assert.Empty(environment.Workspace.CurrentSolution.Projects);
             }
         }
     }

src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioWorkspaceImpl.cs

@@ -1355,7 +1355,7 @@ protected internal override void OnProjectRemoved(ProjectId projectId)
                             _projectSystemNameToProjectsMap.Remove(projectName);
                         }
 
-                        return;
+                        break;
                     }
                 }