From eca1ed52c0bacdbae659b4c19e849351ba39840d Mon Sep 17 00:00:00 2001 From: JieCarolHu Date: Tue, 13 Feb 2018 14:03:32 -0800 Subject: [PATCH] remove redundant check --- .../CSharpUseImplicitTypeDiagnosticAnalyzer.cs | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpUseImplicitTypeDiagnosticAnalyzer.cs b/src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpUseImplicitTypeDiagnosticAnalyzer.cs index a4619456c7a..b35cbac85a6 100644 --- a/src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpUseImplicitTypeDiagnosticAnalyzer.cs +++ b/src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpUseImplicitTypeDiagnosticAnalyzer.cs @@ -137,12 +137,8 @@ protected override bool TryAnalyzeVariableDeclaration(TypeSyntax typeName, Seman else if (typeName.Parent is ForEachStatementSyntax foreachStatement && IsExpressionSameAfterVarConversion(foreachStatement.Expression, semanticModel, cancellationToken)) { - var foreachStatementInfo = semanticModel.GetForEachStatementInfo(foreachStatement); - if (foreachStatementInfo.ElementConversion.IsIdentityOrImplicitReference()) - { - issueSpan = candidateIssueSpan; - return true; - } + issueSpan = candidateIssueSpan; + return true; } else if (typeName.Parent is DeclarationExpressionSyntax declarationExpression && TryAnalyzeDeclarationExpression(declarationExpression, semanticModel, optionSet, cancellationToken)) @@ -268,7 +264,7 @@ protected override bool TryAnalyzeVariableDeclaration(TypeSyntax typeName, Seman // and if we're replacing the declaration with 'var' we'd be changing the semantics by inferring type of // initializer expression and thereby losing the conversion. var conversion = semanticModel.GetConversion(expression, cancellationToken); - return conversion.Exists && conversion.IsImplicit && conversion.IsIdentity; + return conversion.IsIdentity; } protected override bool ShouldAnalyzeDeclarationExpression(DeclarationExpressionSyntax declaration, SemanticModel semanticModel, CancellationToken cancellationToken) -- GitLab